Hi Michael,

On Thu, Nov 10, 2005 at 11:42:29AM +0100, Michael Schmitz wrote:
> -     newinput = kmalloc(sizeof(struct input_dev), GFP_KERNEL);
> +     newinput = input_allocate_device();
>       if (!newinput)
>               goto cleanup;
> -     memset(newinput, 0, sizeof(struct input_dev));
> 
>       newdev->dev = newinput;
> 
> @@ -373,7 +372,6 @@ static int uinput_burn_device(struct uin
> 
>       kfree(udev->dev->name);
>       kfree(udev->dev->phys);
> -     kfree(udev->dev);
>       kfree(udev);
Won't you need to explicitly free this device somewhere?

I hope this helps,
Jochen
-- 
http://seehuhn.de/

Attachment: signature.asc
Description: Digital signature

Reply via email to