Sven Luther wrote:
On Fri, Nov 11, 2005 at 10:00:06AM +0100, Eugen Dedu wrote:
I'm just curious about why powerpc kernel is not compiled with IDE LED
About a year ago I remember having tried to make BLINK_IDE a sysctl option.
It was very simple to replace the compilation option (#define) with a
variable. The problem I had (and I didn't succeed to solve it) is how
to link this variable to a sysctl option :o( Also, I asked myself about
how can I avoid the following race condition: when someone modify the
sysctl option, the led is on state on.
Can you not just modify it when the led is off ?
Note that I do not know the kernel internals, this would have been my
first kernel hack...
Do you still have that code ? What about the version using a kernel command
line parameter ?
My code ressembles to Cedric's code, I think it's better to use it instead.
In fact, my patch replaces in pmac.c the #define ..._BLINK_PMAC with a
variable, and the #define ..._BLINK_PMAC with "if (variable)". I can do
it again if necessary, but I think Cedric's code is better.
Kernel command line parameters: I do not know how to use them...
--
Eugen
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
