Note that the raising of PATH_MAX to 65536 is very important, otherwise
for certain drivers many jobs (especially all jobs from Mac OS X
clients) will not print.
I have used this not very elegant solution for now as I use it also as a
Stable Release Update for Ubuntu Precise. Going the proper way with
foomatic-rip's dynamic-length strings had a too high regression potential.
If you think that the transition of foomatic-filters 4.0.16 to 4.0.17 is
too invasive for the new Debian, please at least only apply the raising
of PATH_MAX as a distro patch (this I do in the Stable Release Update
for Ubuntu Precise). Patch attached.
I suggest to go with 4.0.17 as the Coverity warning fixes can prevent
potential crashes.
Till
On 07/03/2012 06:34 PM, Didier Raboud wrote:
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: freeze-exception
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi,
foomatic-filters' upstream just released 4.0.17 with two small changes that
should go into Wheezy. From the upstream changelog:
foomatic-filters_Raised_PATH_MAX.diff:
* foomaticrip.h: Raised PATH_MAX to 65536 bytes so that CUPS
filter calls with many command line options work (Ubuntu bug
#1019662).
(FWIW, I know that rising PATH_MAX is not a very elegant solution, but it's
upstream's…)
foomatic-filters_Fix_Free_Coverity.diff
* options.c, renderer.c: Fixed problems discovered by a Coverity scan
(Bug #752).
These two changes are shipped in the 4.0.17 upstream tarball together with all
the s/4.0.16/4.0.17/ changes and some whitespace Changelog fixes. The debdiff
for an eventual 4.0.17-1 is also attached, with the following beautyfied
diiffstat (11 files changed, 301 insertions(+), 266 deletions(-))
- ------------------|
Relevant changes |
- ------------------|
debian/changelog | 11 +
options.c | 4
renderer.c | 9
- ------------------|
Version changes |
- ------------------|
ChangeLog | 511
++++++++++++++++++++++++++++---------------------------
README | 2
USAGE | 2
VERSION | 2
VERSION.full | 2
configure | 20 +-
configure.ac | 2
foomaticrip.h | 2
So, what would you accept ? Just the patches for a 4.0.16-2 or the new
upstream release 4.0.17-1 ?
Cheers,
OdyX
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQGcBAEBCAAGBQJP8x8IAAoJEIvPpx7KFjRV/kAL/jzuknntSh3PzdEyKICGI43z
wjmaUdxSEX5EKpz6d4UfCz7QYin1BgKvPyyjiH5wlj65wT1xEh0SVPpviwC/6Dq/
40YjWWcoSorTTEXaaT1YsXF8Fpc/f0yn4+LUiaclJfAb82sK6+REj4UsjwuDQKN8
BIwvzFzrijP4F26E3XLiJXWqJgJkHtCFWcSx9xNTv+Q37gIppcKuLmu4bv7HsqGw
PIhFeykzYvQUQtxwko2rw7GFUrPThLhx3GE4DhjWNvPmEQ/prXn3Gh9pcePoEudU
7FiEvI6RIm/nJa0Id8a65rd/nS4VCEmZDXcZV7GozyDNW8gSlJ3i2s90rzQ3vq2A
Ru4LxlAVSPOmJ/46sLN/C23cOrftgWM5bR8P7mwqZHbJp2yVcp8Uv5sfnc86kWEl
sgQ5l1Y7fbUFsNDghHfZGowFkCIX5X2iYqUuvFUwZd9PoscMdUHdQDLkOEODvR78
dfIdCD6IeMbzVPAWumrQQCY7WBK9GS6Dn+gRQUUPeQ==
=dTNe
-----END PGP SIGNATURE-----
--- a/foomaticrip.h
+++ b/foomaticrip.h
@@ -93,7 +93,7 @@
extern int spooler;
-#define PATH_MAX 1024
+#define PATH_MAX 65536
typedef struct {
char printer[256];
