Your message dated Thu, 06 Mar 2014 16:38:55 +0000
with message-id <[email protected]>
and subject line Bug#740789: fixed in ptouch-driver 1.3-8
has caused the Debian Bug report #740789,
regarding ptouch-driver: driver sends QL-specific commands to PT-series printers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
740789: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740789
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ptouch-driver
Version: 1.3-7
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu trusty ubuntu-patch
Dear Maintainer,
In Ubuntu, the attached patch was applied to achieve the following:
The attached patch resolves an issue whereby ptouch-driver sends a
QL-specific command (ESC i A "Enable Cutter") to all printers, not just
QL-series devices. This causes printing to fail on the PT-2450DX (with
an Interface Error shown on the panel) and probably other printers in
the Brother P-Touch series too.
* Add patch send-esc-i-A-for-QL-only.patch
Thanks for considering the patch.
-- System Information:
Debian Release: wheezy/sid
APT prefers saucy-updates
APT policy: (500, 'saucy-updates'), (500, 'saucy-security'), (500, 'saucy'),
(100, 'saucy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.11.0-17-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2011-08-29 12:27:35 +0000
+++ .pc/applied-patches 2014-03-04 22:51:59 +0000
@@ -1,2 +1,3 @@
foomatic-data-fixes.patch
send-esc-i-A.patch
+send-esc-i-A-for-QL-only.patch
=== modified file 'debian/changelog'
=== modified file 'debian/control'
--- debian/control 2012-09-26 14:34:28 +0000
+++ debian/control 2014-03-04 22:50:44 +0000
@@ -9,7 +9,7 @@
libcups2-dev,
libcupsimage2-dev,
foomatic-db-engine,
- pyppd (>= 0.4.9-6~)
+ pyppd (>= 1.0.1)
Vcs-Git: git://anonscm.debian.org/collab-maint/ptouch-driver.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/ptouch-driver.git
Homepage: http://www.diku.dk/hjemmesider/ansatte/panic/P-touch/
=== added file 'debian/patches/send-esc-i-A-for-QL-only.patch'
--- debian/patches/send-esc-i-A-for-QL-only.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/send-esc-i-A-for-QL-only.patch 2014-03-04 20:27:25 +0000
@@ -0,0 +1,50 @@
+Index: ptouch-driver/rastertoptch.c
+===================================================================
+--- ptouch-driver.orig/rastertoptch.c 2014-03-04 20:06:59.000000000 +0000
++++ ptouch-driver/rastertoptch.c 2014-03-04 20:27:19.000000000 +0000
+@@ -685,7 +685,8 @@
+ inline void
+ emit_feed_cut_mirror (bool do_feed, unsigned feed,
+ bool do_cut,
+- bool do_mirror) {
++ bool do_mirror,
++ bool is_ulp) {
+ /* Determine feed nibble */
+ unsigned feed_nibble;
+ if (do_feed) {
+@@ -698,7 +699,14 @@
+ /* Determine mirror print bit*/
+ unsigned char mirror_bit = do_mirror ? 0x80 : 0x00;
+ /* Combine & emit printer command code */
+- putchar (ESC); putchar ('i'); putchar ('A'); putchar ((char) (do_cut ? 0x01 : 0x00));
++ if (is_ulp) {
++ /* ESC i A is Enable Cutter -- used for QL-560 only, according to
++ * <http://www.undocprint.org/formats/page_description_languages/brother_p-touch>
++ * The QL-560 (actually the whole QL series) uses ULP mode, so we check for that.
++ * The PT2450DX uses RLE and throw an INTERFACE ERROR if it sees this command.
++ */
++ putchar (ESC); putchar ('i'); putchar ('A'); putchar ((char) (do_cut ? 0x01 : 0x00));
++ }
+ putchar (ESC); putchar ('i'); putchar ('M');
+ putchar ((char) (feed & 0x1f) | auto_cut_bit | mirror_bit);
+ }
+@@ -807,7 +815,8 @@
+ /* We only know how to feed after each page */
+ emit_feed_cut_mirror (perform_feed == CUPS_ADVANCE_PAGE, feed,
+ cut_media == CUPS_CUT_PAGE,
+- mirror == CUPS_TRUE);
++ mirror == CUPS_TRUE,
++ job_options->pixel_xfer == ULP);
+ /* Set media and quality if label preamble is requested */
+ unsigned page_size_y = new_page_options->page_size [1];
+ unsigned image_height_px = lrint (page_size_y * vres / 72.0);
+@@ -1527,7 +1536,8 @@
+ perform_feed == CUPS_ADVANCE_JOB,
+ new_page_options->feed,
+ cut_media == CUPS_CUT_PAGE || cut_media == CUPS_CUT_JOB,
+- new_page_options->mirror == CUPS_TRUE);
++ new_page_options->mirror == CUPS_TRUE,
++ job_options->pixel_xfer == ULP);
+ /* Emit eject marker */
+ putchar (PTC_EJECT);
+ }
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-09-13 10:00:00 +0000
+++ debian/patches/series 2014-03-04 22:51:47 +0000
@@ -1,2 +1,3 @@
foomatic-data-fixes.patch
send-esc-i-A.patch
+send-esc-i-A-for-QL-only.patch
=== modified file 'rastertoptch.c'
--- rastertoptch.c 2011-08-29 12:27:35 +0000
+++ rastertoptch.c 2014-03-04 22:51:59 +0000
@@ -685,7 +685,8 @@
inline void
emit_feed_cut_mirror (bool do_feed, unsigned feed,
bool do_cut,
- bool do_mirror) {
+ bool do_mirror,
+ bool is_ulp) {
/* Determine feed nibble */
unsigned feed_nibble;
if (do_feed) {
@@ -698,7 +699,14 @@
/* Determine mirror print bit*/
unsigned char mirror_bit = do_mirror ? 0x80 : 0x00;
/* Combine & emit printer command code */
- putchar (ESC); putchar ('i'); putchar ('A'); putchar ((char) (do_cut ? 0x01 : 0x00));
+ if (is_ulp) {
+ /* ESC i A is Enable Cutter -- used for QL-560 only, according to
+ * <http://www.undocprint.org/formats/page_description_languages/brother_p-touch>
+ * The QL-560 (actually the whole QL series) uses ULP mode, so we check for that.
+ * The PT2450DX uses RLE and throw an INTERFACE ERROR if it sees this command.
+ */
+ putchar (ESC); putchar ('i'); putchar ('A'); putchar ((char) (do_cut ? 0x01 : 0x00));
+ }
putchar (ESC); putchar ('i'); putchar ('M');
putchar ((char) (feed & 0x1f) | auto_cut_bit | mirror_bit);
}
@@ -807,7 +815,8 @@
/* We only know how to feed after each page */
emit_feed_cut_mirror (perform_feed == CUPS_ADVANCE_PAGE, feed,
cut_media == CUPS_CUT_PAGE,
- mirror == CUPS_TRUE);
+ mirror == CUPS_TRUE,
+ job_options->pixel_xfer == ULP);
/* Set media and quality if label preamble is requested */
unsigned page_size_y = new_page_options->page_size [1];
unsigned image_height_px = lrint (page_size_y * vres / 72.0);
@@ -1527,7 +1536,8 @@
perform_feed == CUPS_ADVANCE_JOB,
new_page_options->feed,
cut_media == CUPS_CUT_PAGE || cut_media == CUPS_CUT_JOB,
- new_page_options->mirror == CUPS_TRUE);
+ new_page_options->mirror == CUPS_TRUE,
+ job_options->pixel_xfer == ULP);
/* Emit eject marker */
putchar (PTC_EJECT);
}
--- End Message ---
--- Begin Message ---
Source: ptouch-driver
Source-Version: 1.3-8
We believe that the bug you reported is fixed in the latest version of
ptouch-driver, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Didier Raboud <[email protected]> (supplier of updated ptouch-driver package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 06 Mar 2014 16:23:54 +0100
Source: ptouch-driver
Binary: printer-driver-ptouch ptouch-driver
Architecture: source amd64 all
Version: 1.3-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Printing Team <[email protected]>
Changed-By: Didier Raboud <[email protected]>
Description:
printer-driver-ptouch - printer driver Brother P-touch label printers
ptouch-driver - transitional dummy package for ptouch printer driver
Closes: 740789
Changes:
ptouch-driver (1.3-8) unstable; urgency=medium
.
[ Philip Pemberton ]
* Rewrite the patch to send the 'ESC i A' command to only let rastertoptch
send it to printers that do support it (Closes: #740789, LP: #1287971)
.
[ Didier Raboud ]
* Move the repository from collab-maint to printing; update the VCS-* fields
accordingly
Checksums-Sha1:
a1fdff25d64e22426a856dd63ddd7c495f349756 1940 ptouch-driver_1.3-8.dsc
191ae7115ebdaaf127919d5ef22b0f81518bf06f 6056 ptouch-driver_1.3-8.debian.tar.xz
215256238a3f903dec89dbb744e10486f337cc8c 28878
printer-driver-ptouch_1.3-8_amd64.deb
c1a2c91dbdd7095f9f8b80b4237728e828bddb72 5582 ptouch-driver_1.3-8_all.deb
Checksums-Sha256:
6dccb4e0292cc1936d875b76f35c01f32e755bfd1fa01301b2da30a93a077d41 1940
ptouch-driver_1.3-8.dsc
9daf182cdac2e03eb926bee5eb10f34ed340c3345bb7aa7794ee69b63c51ac84 6056
ptouch-driver_1.3-8.debian.tar.xz
1839ba1c217c3a4d942a3e406951f8cb4c9fff9062c82e67e099250fe6012a3d 28878
printer-driver-ptouch_1.3-8_amd64.deb
4aaa8a703945abdccbbedcbb884850b9ad49e73e790172950225e92a36582034 5582
ptouch-driver_1.3-8_all.deb
Files:
07b49683346c7bb741a96dd7cae31b7f 1940 text optional ptouch-driver_1.3-8.dsc
da108baa547273fa1ccfce9f580f8b0e 6056 text optional
ptouch-driver_1.3-8.debian.tar.xz
46a4f5a0839c8af462043ba41ae3c5f7 28878 text optional
printer-driver-ptouch_1.3-8_amd64.deb
dc1102c3d21b743f7b660f5e98431d4a 5582 oldlibs extra ptouch-driver_1.3-8_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQGcBAEBCAAGBQJTGJcGAAoJEIvPpx7KFjRVdyAMAJPWxE+Lq3WgggY/WqSJ+nPR
GYWA5hvtzwzfVRkwARAnnX9T8+gn4ODBdDHjxmGQPQiA6wTXcHo9M1BC8BJlWxSA
XxHl9+q+Li/mRdky9WRkca93kBBRK+zUN1fZWkAWFXl1QX0f70rhELr7AbCUAEQG
k9Dzwmv0GPg3hdgTRPTYUl+yIjoRUttKsa6kADsBQ4VzkSZieym3GzUI9Z5jfxdt
48yBGG+nNiuZhiaQxT11dML+IYIedKx5mGtn/xmgPAu/OslXajHSJd7KmTp6kmGZ
hL8e8EiURdBUk8my+Kndc5mTuIRHEbfGmA4bm/jBZ61KhKa9d7jAgwYaUUEZOG9a
OJjqjry+6C/kQl2/kutYYMk1a07w1pE3CojnKC8e0G0OaLQPzIV+J+H4jC/C4MV7
f4EYzY2ywg0F8L3df6Q13E30h/CJG8gb5u6ZM1gzo+u6Mf1YuS7vK4m8JnvJ81Mw
91O+vLCWEc5sGkP+2MViOwaJMqWIrn1KthCu3UbDRQ==
=CYLT
-----END PGP SIGNATURE-----
--- End Message ---
