Source: ifhp
Version: 3.5.20+dfsg-1
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: origin-ubuntu stonking ubuntu-patch
Hi,
debian/rules calls
$(MAKE) LDFLAGS=$(LDFLAGS)
where LDFLAGS is `dpkg-buildflags --get LDFLAGS` (expanded by the
shell), without quoting. Only the first word ends up in LDFLAGS; the
following words are passed to make as command line arguments. It works
today because all the other words happen to start with -W, which make
accepts as "-W FILE" (mark FILE as new), so those linker flags are
silently dropped instead.
Any flag that doesn't start with -W breaks the build. In Ubuntu, the
amd64v3 variant appends -march=x86-64-v3 to LDFLAGS and the build fails
with:
/usr/bin/make: invalid option -- 'a'
/usr/bin/make: invalid option -- 'c'
...
The attached patch quotes the variable, so all the flags are actually
passed to the link.
Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/ifhp/+bug/2170781
Thanks,
Sebastien Bacher
-- System Information:
Debian Release: forky/sid
APT prefers resolute-updates
APT policy: (500, 'resolute-updates'), (500, 'resolute-security'), (500,
'resolute'), (100, 'resolute-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 7.0.0-38-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- a/debian/rules
+++ b/debian/rules
@@ -34,7 +34,7 @@
build-indep: build-stamp
build-stamp: configure-stamp
dh_testdir
- $(MAKE) LDFLAGS=$(LDFLAGS)
+ $(MAKE) LDFLAGS="$(LDFLAGS)"
touch $@
clean:
