Colin Watson <cjwat...@debian.org> writes:

> On Tue, Dec 17, 2024 at 08:44:39AM +0100, Simon Josefsson wrote:
>> I noticed that 1.2.0-1 migrated to testing, so I did an upload to
>> finalize the packaging move and it now live here:
>> 
>> https://salsa.debian.org/python-team/packages/securesystemslib/
>> 
>> Python team, please review packaging if you have cycles!  I am not up to
>> speed up all python group best practices.
>
> The random Dockerfile is anomalous (though not forbidden) and wouldn't
> be used by most of the members of the DPT, so I haven't reviewed it.

I removed that file -- I didn't notice that file myself.  Upstream seems
to have stopped using that process over a year ago and have made several
upstream releases after that.  The file is still present upstream and in
git history if anyone is curious.  I prefer if packaging follows Debian
practices in general and Debian Python packaging team in particular,
let's make it easy for people to help.

> The rest looks OK from a quick visual inspection.

Thank you!  It really helps to have review of new things.

>  * It's a shame that the basename of the git repository URL doesn't
>    match the source package name.  If it's practical to rename the
>    repository without too much trouble, that would be good.

Done.

>  * You could depend on dh-sequence-python3 instead of dh-python, and
>    drop "--with python3" from debian/rules.

Done.

> Oh, also, DPT practice is to use pristine-tar, so please do that.  See
> https://wiki.debian.org/Python/GitPackaging.

Done.

There is a reproducability FTBFS on armhf that I'm trying to debug, but
hopefully I'll do another upload shortly.

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to