On 2026-11-05 10:30, Pieter Lenaerts wrote: > On Wed Nov 4, 2026 at 11:35 PM CET, Emmanuel Arias wrote: > > Hi Emmanuel! > > > I took monty from #debian-python team irc topic. > > > > I'm leaving some comments: > > > > - Regarding popitem_may_be_fifo_or_lifo.patch, patch can be forward to > > upstream? > > Yes. Honestly, I tend to be so happy I'm almost finished with a package that I > forget to forward patches. > > I forwarded it and marked others as not-needed if they were debian specific. > > > - NIT, It would be better if you commit the change per sé and the > > changelog entry in the same commit. E.g > > 60732a335b542b3a36762e3ffd683fef98a58ffb and > > 16c7fcc10321fdb8357e45a2878c47d51fb7781a can be the same. Do you > > know debcommit? > > Cool. I didn't know it. Will try it out. > > > - NIT, New upstream version 2026.10.21, is superfluous mentions the > > version IMHO. > > Okay. Will take that into account in the future.
Sorry for don't be clear. The 'new upstream release', is okey (and it
should be in the changelog). Mentioning the <version> IMO, can be ignored.
>
> > Let me know if we should send the patch to upstream, the rest are nit.
>
> Thanks for your time!
Uploaded!
Thanks for your contributions to Debian!
>
> Pieter
--
cheers,
Emmanuel Arias
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ [email protected]
⢿⡄⠘⠷⠚⠋⠀ OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1
⠈⠳⣄
signature.asc
Description: PGP signature
