hi Lester, I reviewed the python-neo4j package, up for sponsorship in the Python team. Nice work, just some fairly minor stuff:
* the documentation files are pretty big and make up the bulk of the binary package; please split off into a separate package. * control: [already fixed in git] I added a test-only build-dep on python3-pyarrow to allow more test in test_vector.py to run. Note that the dependency is restricted to architectures supported by pyarrow (amd64, arm64, loong64, ppc64el, riscv64) so that neo4j still builds on everything else. * tests: I noticed some networking-related issues with test_adressing when building locally in a pbuilder without network access. They try to resolve "127.0.0.1", which may be undefined on runners without ipv4. Consider disabling the affected tests as a preventive measure: FAILED tests/unit/async_/test_addressing.py::test_address_resolve_with_custom_resolver[sync] FAILED tests/unit/async_/test_addressing.py::test_address_resolve_with_custom_resolver[async] FAILED tests/unit/async_/test_addressing.py::test_address_unresolve - Asserti... FAILED tests/unit/sync/test_addressing.py::test_address_resolve_with_custom_resolver[sync] FAILED tests/unit/sync/test_addressing.py::test_address_resolve_with_custom_resolver[async] FAILED tests/unit/sync/test_addressing.py::test_address_unresolve - Assertion... Once the above comments have been addressed, simply re-add the package to the IRC channel topic and/or ping me by e-mail.
pgpipl7oNule_.pgp
Description: OpenPGP digital signature
