Your message dated Fri, 15 Nov 2024 19:19:32 +0000 with message-id <e1tc1qu-004msg...@fasolo.debian.org> and subject line Bug#693484: fixed in couriergraph 0.25-7 has caused the Debian Bug report #693484, regarding couriergraph: stop action of initscript might kill unrelated process to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 693484: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693484 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: couriergraph Version: 0.25-4 Severity: normal Tags: patch -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi The stop action of couriergraph's init script might kill an unrelated process (e.g. if couriergraph daemon dies, and the stop action is later on invoked, and some other process get's the pid from the original running couriergraph.pl process). This is also something start-stop-daemon manpage states: MATCHING OPTIONS -p, --pidfile pid-file Check whether a process has created the file pid-file. Note: using this matching option alone might cause unintended processes to be acted on, if the old process terminated without being able to remove the pid-file. So best would be to also (like 0.25-4.3 for start) to use --name. And per [1], it might be also good suggestion to use --retry and to not sleep for the restart action between start and stop. [1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692496#27 Julien Cristau <jcris...@debian.org> suggested that this could be improved. Regards, Salvatore - -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJQpsimAAoJEHidbwV/2GP+tWgP/1RnIbCAxhY21oKHU/Gt/5+x eojrjxe8X3t4upEgo1IpEFqoh8ayW9lnuC5/B6YqCBmoPqEN/eA/a/Sl2KAzak/v 82GBn4NFu6V+PKmmF9fYEIe7k/K2zGLqfdV+TBMeio8Q6h7IEbJGTx3q46GELx+4 8eurkhx5oiylQ8p9esuVhaZjbgAYAe2LTsYWd40C1r8+BE9UECATkZAo0pvUhLmB MG7bb2mW0mDsCVYz3iJg/yhrBlHB6+Swd0sZ3IRtVZ57QFI3S9shf9CphiRsCTf3 +Kao7v4FHbbTatP/JBt5CFol3yYJYfIdInG2E/5rRPU4etFRij98UKBTdFUYxefz dx16SnDxfhKDFveKnKadOg26YiZxvQHthUmBpzHVqqHUgqHJ3dUeq/sf4FMAXqkU nc1ICDiwGJtEWkMNP5De0CKfd79OzQd8POxX3cphHdjFWKXr/4oBjkKrmmwiJL+M 1QT0yeO5Ev72J7Fg5VlDB7ubgSco8+xsjqCRHluv5pToa1KY1Fo5cE1C8jgdOBoH 14IG3omb97bSbCodBRGxVoZcoRzlGwnIRkp1/BjBqff57yGs3CN7RGWJ5RtXTi+e NH99MJuIR1PftzLTHVyXb4HQ+dszPLpzI/mUpLFx6CdlMI4XYoIKKxXOQ5ZvB5oM r4wHCXQHBZQtdhc6qxP+ =xnI8 -----END PGP SIGNATURE----->From d000539173e8de112c804c47b9cea525d25be0f8 Mon Sep 17 00:00:00 2001 From: Salvatore Bonaccorso <car...@debian.org> Date: Sat, 17 Nov 2012 00:08:53 +0100 Subject: [PATCH] Improve init script stop and restart action Use --name to killing an unrelated process. Furthermore use --retry to wait for the process to actually die. Don't sleep during restart action. --- debian/init | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/debian/init b/debian/init index 8c24b29..d9d0121 100644 --- a/debian/init +++ b/debian/init @@ -41,14 +41,13 @@ case "$1" in stop) echo -n "Stopping $DESC: " - start-stop-daemon --stop --oknodo --pidfile $PIDFILE + start-stop-daemon --stop --oknodo --pidfile $PIDFILE --name couriergraph.pl --retry 1 rm -f $PIDFILE echo "$NAME." ;; restart|force-reload) $0 stop - sleep 1 $0 start ;; -- 1.7.10.4
--- End Message ---
--- Begin Message ---Source: couriergraph Source-Version: 0.25-7 Done: Petter Reinholdtsen <p...@debian.org> We believe that the bug you reported is fixed in the latest version of couriergraph, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 693...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Petter Reinholdtsen <p...@debian.org> (supplier of updated couriergraph package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Fri, 15 Nov 2024 19:56:30 +0100 Source: couriergraph Architecture: source Version: 0.25-7 Distribution: unstable Urgency: medium Maintainer: Debian QA Group <packa...@qa.debian.org> Changed-By: Petter Reinholdtsen <p...@debian.org> Closes: 559278 693484 Changes: couriergraph (0.25-7) unstable; urgency=medium . * QA upload. . [ Petter Reinholdtsen ] * Added d/gbp.conf to describe branch layout. * Updated vcs in d/control to Salsa. * Updated d/gbp.conf to enforce the use of pristine-tar. * Updated Standards-Version from 3.7.3 to 4.7.0. * Use wrap-and-sort -at for debian control files. * Trim trailing whitespace. * Add missing ${misc:Depends} to Depends for couriergraph. * debian/rules: Use dh_prep rather than "dh_clean -k". * Bump debhelper from deprecated 9 to 13. * Set debhelper-compat version in Build-Depends. * Change priority extra to priority optional. * Fix day-of-week for changelog entries 0.25-1, 0.24-1. * Added 1020-courier-process-names.patch to look for the correct syslog filter (Closes: #559278). * Use ${misc:Pre-Depends} in d/control. . [ Salvatore Bonaccorso ] * Improve init script stop and restart action (Closes: #693484). Checksums-Sha1: b114339d52e879784f0c9c21115ee60677a8a775 1861 couriergraph_0.25-7.dsc 349ca287aa33f4538be668065920f65bd08731e3 18752 couriergraph_0.25-7.debian.tar.xz a716995ed4b84faffed20c401f8bddb577c2ba98 6387 couriergraph_0.25-7_source.buildinfo Checksums-Sha256: 8a1927d5c2e7f161592470ddc73f00347a38596835f84160f7de22bbab8d73f3 1861 couriergraph_0.25-7.dsc b91f5b052a676900672122a78126604afd965dfbd5566b5f9556004f286cce7c 18752 couriergraph_0.25-7.debian.tar.xz 5957b98cb42f4bf4b42c21a71cd7f1e8bef2314983a95637a7899291d4b789ff 6387 couriergraph_0.25-7_source.buildinfo Files: 7d43bcdca6da0e76f4fa93216a9f4b70 1861 admin optional couriergraph_0.25-7.dsc 51d5d29795d83c687de97219037a338c 18752 admin optional couriergraph_0.25-7.debian.tar.xz 071c5548a21f4e0a2749e13e78de2e59 6387 admin optional couriergraph_0.25-7_source.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEERqLf4owIeylOb9kkgSgKoIe6+w4FAmc3mdAACgkQgSgKoIe6 +w4WxxAAsNMUeMhlIQVXSclfC0o8duHW3YaWpj3BRyu1TKGUVx7mh6f2pvN8Q42m LydpaLGGaIwX/zFKhZsHWvd207mgpKHk0ggmIsnOfI7iEo42ePKIs7c/3B5h3OcI fvALkr1kFF6wutKEZG5Un7nzqp1t4wI9+d/PMCDps5K4t7Hv4CeJl7o9hw7FJ9N4 Fn1oWWtAi/vp6XfsKx+ce5bl4T5DkTogmxNPQu4eSdrQCUi8ZA1VtnV0pfhHjEZz DUGTaPjuBoC7FdOkW0rfbesJuobmHBkZRkFaVUYAEClS7Vg0F0J/D5OFGxLfwiqO kf59sPI1V8bmFe5Vs/HxT1AyUjA2Kh8ohUmawpi/KjV+zBPZEokB7UWwzCyRQjuo YP0by1T15o0zXNCgWluAAGNRfS6bPZg8TOHIWMvjg2PS+kHHTD+UnYuEgoicEdYU SMu/sVFWhWn2vyWOsbDNz/XqI44RzZhbAdcnUDtnYRGh0QIIZS1sGe3CCOoWK+VR BjHZakdKxnnX316A5bAfNDLc4ahiRmDL/+11B3/PlTG9/RNA3xwLOfVE1OWkUzrz 8nUWbf7HELQqjnNwPrxZN0wKKGBrLCU9TELM4djvO2wrO7CMdAQ2sx3Iso1BhaH6 aY/iwRPaKdtszhlsjnzSCShy3E2u6WersztSawg3wZGb7niPtXk= =7ooA -----END PGP SIGNATURE-----
pgpv0sigqhKdx.pgp
Description: PGP signature
--- End Message ---
