Source: photopc
Version: 3.07-4
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20241223 ftbfs-trixie
Hi,
During a rebuild of all packages in sid, this package failed to build
on armhf.
This package currently has binary packages on armhf, so this is a regression.
Also, there are no known issues on amd64 or arm64 according to recent (a couple
days ago) rebuilds.
The rebuild was done using an armhf chroot on an AWS "m6g" instance (Graviton2
CPU).
Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32 -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g
> -O2 -Werror=implicit-function-declaration
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
> -fstack-clash-protection -Wformat -Werror=format-security -Wall -c -o
> ctimez.o ctimez.c
> a12scan.c: In function ‘a12search’:
> a12scan.c:114:29: warning: pointer targets in passing argument 1 of ‘strncmp’
> differ in signedness [-Wpointer-sign]
> 114 | if (strncmp(p,key,strlen(key)) == 0) break;
> | ^
> | |
> | unsigned char *
> In file included from a12scan.c:70:
> /usr/include/string.h:159:33: note: expected ‘const char *’ but argument is
> of type ‘unsigned char *’
> 159 | extern int strncmp (const char *__s1, const char *__s2, size_t __n)
> | ~~~~~~~~~~~~^~~~
> fnames.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
> 2 | static char *rcsid="$Id: fnames.c,v 1.7 2001/01/11 06:49:57 crosser
> Exp $";
> | ^~~~~
> a12scan.c: At top level:
> a12scan.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
> 2 | static char *rcsid="$Id: a12scan.c,v 1.13 1999/08/01 21:36:54 crosser
> Exp $";
> | ^~~~~
> ctimez.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
> 2 | static char *rcsid="$Id: ctimez.c,v 1.7 1999/11/09 18:55:03 crosser
> Exp $";
> | ^~~~~
> photopc.c: In function ‘listfiles’:
> photopc.c:1539:52: error: passing argument 1 of ‘ctimetz’ from incompatible
> pointer type [-Wincompatible-pointer-types]
> 1539 | if (res > 0L) printf("%8s",ctimetz(&res,usetimezone));
> | ^~~~
> | |
> | long int *
> In file included from photopc.c:368:
> ctimez.h:38:23: note: expected ‘time_t *’ {aka ‘long long int *’} but
> argument is of type ‘long int *’
> 38 | char *ctimetz(time_t *clock,int usetimezone);
> | ~~~~~~~~^~~~~
> photopc.c: In function ‘llistfiles’:
> photopc.c:1619:21: warning: pointer targets in assignment from ‘char *’ to
> ‘unsigned char *’ differ in signedness [-Wpointer-sign]
> 1619 | ress=buffer;
> | ^
> photopc.c:1622:18: warning: pointer targets in assignment from ‘unsigned char
> *’ to ‘char *’ differ in signedness [-Wpointer-sign]
> 1622 | p=a12search("Resolution",ress,ressize);
> | ^
> photopc.c:1629:18: warning: pointer targets in assignment from ‘unsigned char
> *’ to ‘char *’ differ in signedness [-Wpointer-sign]
> 1629 | p=a12search("Flash",ress,ressize);
> | ^
> photopc.c:1636:18: warning: pointer targets in assignment from ‘unsigned char
> *’ to ‘char *’ differ in signedness [-Wpointer-sign]
> 1636 | p=a12search("Shutter",ress,ressize);
> | ^
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32 -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g
> -O2 -Werror=implicit-function-declaration
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
> -fstack-clash-protection -Wformat -Werror=format-security -Wall -c -o
> filetime.o filetime.c
> photopc.c:1643:18: warning: pointer targets in assignment from ‘unsigned char
> *’ to ‘char *’ differ in signedness [-Wpointer-sign]
> 1643 | p=a12search("TimeDate",ress,ressize);
> | ^
> photopc.c:1648:56: error: passing argument 1 of ‘ctimetz’ from incompatible
> pointer type [-Wincompatible-pointer-types]
> 1648 | if (res != -1L)
> printf("%8s\n",ctimetz(&res,usetimezone));
> | ^~~~
> | |
> | long int *
> ctimez.h:38:23: note: expected ‘time_t *’ {aka ‘long long int *’} but
> argument is of type ‘long int *’
> 38 | char *ctimetz(time_t *clock,int usetimezone);
> | ~~~~~~~~^~~~~
> photopc.c: In function ‘retrfile’:
> photopc.c:1784:56: warning: format ‘%lu’ expects argument of type ‘long
> unsigned int’, but argument 2 has type ‘time_t’ {aka ‘long long int’}
> [-Wformat=]
> 1784 | if (debug) printf("got timestamp from reg47: %lu\n",
> | ~~^
> | |
> | long unsigned
> int
> | %llu
> 1785 | pictime);
> | ~~~~~~~
> | |
> | time_t {aka long long int}
> photopc.c:1873:20: warning: pointer targets in assignment from ‘char *’ to
> ‘unsigned char *’ differ in signedness [-Wpointer-sign]
> 1873 | res=buffer;
> | ^
> photopc.c:1876:18: warning: pointer targets in assignment from ‘unsigned char
> *’ to ‘char *’ differ in signedness [-Wpointer-sign]
> 1876 | p=a12search("TimeDate",res,ressize);
> | ^
> photopc.c:1879:41: warning: format ‘%lu’ expects argument of type ‘long
> unsigned int *’, but argument 3 has type ‘time_t *’ {aka ‘long long int *’}
> [-Wformat=]
> 1879 | if (sscanf(p,"%lu",&pictime) != 1)
> | ~~^ ~~~~~~~~
> | | |
> | | time_t * {aka long long
> int *}
> | long unsigned int *
> | %llu
> photopc.c:1882:63: warning: format ‘%lu’ expects argument of type ‘long
> unsigned int’, but argument 2 has type ‘time_t’ {aka ‘long long int’}
> [-Wformat=]
> 1882 | if (debug) printf("got timestamp from file: %lu\n",
> | ~~^
> | |
> | long
> unsigned int
> | %llu
> 1883 | pictime);
> | ~~~~~~~
> | |
> | time_t {aka long long int}
> photopc.c:1916:25: warning: this ‘if’ clause does not guard...
> [-Wmisleading-indentation]
> 1916 | if (fname) free(fname); fname=NULL;
> | ^~
> photopc.c:1916:49: note: ...this statement, but the latter is misleadingly
> indented as if it were guarded by the ‘if’
> 1916 | if (fname) free(fname); fname=NULL;
> | ^~~~~
> filetime.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
> 2 | static char *rcsid="$Id: filetime.c,v 1.7 1999/12/11 14:10:15 crosser
> Exp $";
> | ^~~~~
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32 -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g
> -O2 -Werror=implicit-function-declaration
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
> -fstack-clash-protection -Wformat -Werror=format-security -Wall -c -o
> exifscan.o exifscan.c
> photopc.c: In function ‘main’:
> photopc.c:2443:23: warning: ignoring return value of ‘seteuid’ declared with
> attribute ‘warn_unused_result’ [-Wunused-result]
> 2443 | (void)seteuid(getuid());
> | ^~~~~~~~~~~~~~~~~
> photopc.c: At top level:
> photopc.c:2:14: warning: ‘rcsid’ defined but not used [-Wunused-variable]
> 2 | static char *rcsid="$Id: photopc.c,v 2.87 2003/03/14 15:25:36 crosser
> Exp $";
> | ^~~~~
> gcc -DHAVE_CONFIG_H -I. -I./dos -I./win32 -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g
> -O2 -Werror=implicit-function-declaration
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong
> -fstack-clash-protection -Wformat -Werror=format-security -Wall -c -o
> eph_read.o eph_read.c
> make[2]: *** [Makefile:599: photopc.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/12/23/photopc_3.07-4_unstable-armhf.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20241223;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20241223&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
