Hi Soren! On Wed, Dec 20, 2023 at 12:23:15PM -0700, Soren Stoutner wrote: > On Wednesday, December 20, 2023 7:01:47 AM MST Dmitry Shachnev wrote: > > Using a stub header results in dependency on private ABI just like including > > a normal header. > > I wonder if that just happens for the QML version of WebEngineDownloadItem. > > https://doc.qt.io/qt-5/qml-qtwebengine-webenginedownloaditem.html > > It doesn’t affect Privacy Browser, but I use the C++ version of > WebEngineDownloadItem. > > https://doc.qt.io/qt-5/qwebenginedownloaditem.html > > $ nm -D /usr/bin/privacybrowser | grep Qt_5_PRIVATE_API > $
Yes, it affects only the Qt Quick version. The C++ version is public: $ dpkg -L qtwebengine5-dev | grep -i downloaditem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineWidgets/QWebEngineDownloadItem /usr/include/x86_64-linux-gnu/qt5/QtWebEngineWidgets/qwebenginedownloaditem.h $ dpkg -L qtwebengine5-private-dev | grep -i downloaditem /usr/include/x86_64-linux-gnu/qt5/QtWebEngine/5.15.15/QtWebEngine/private/qquickwebenginedownloaditem_p.h /usr/include/x86_64-linux-gnu/qt5/QtWebEngine/5.15.15/QtWebEngine/private/qquickwebenginedownloaditem_p_p.h /usr/include/x86_64-linux-gnu/qt5/QtWebEngineWidgets/5.15.15/QtWebEngineWidgets/private/qwebenginedownloaditem_p.h > > I think that angelfish developers should ask Qt upstream to make that class > > public, explaining how and why they use it. > > That makes sense to me. I have filed a Debian bug and an upstream bug > against Angelfish. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059164 > > https://bugs.kde.org/show_bug.cgi?id=478783 Small correction for your bug report. You write: “Qt 6 has a public version of this API: https://doc.qt.io/qt-6/qml-qtwebengine-webenginedownloadrequest.html” However, that link is for the QML interface documentation. But what angelfish actually does is using the Qt Quick class from the C++ code. As I understand, you have to do such things when you have mixed QML and C++ code, and want to interact with QML components from the C++ part. -- Dmitry Shachnev
signature.asc
Description: PGP signature
