On Wed, Oct 19, 2016 at 09:24:45AM +0200, Maximiliano Curia wrote:
> ¡Hola Marcos!
Hey chango....
> El 2016-10-18 a las 20:25 +0200, Marcos Dione escribió:
> > marble has for ages disabled symlinks traversal in a great part of
> > the local cache code. I know for certain that developers have decided to
> > do so to avoid user reports related to dangling symlinks (sorry, I can't
> > find a reference now).
>
> This also avoids the "recursion too deep" problems.
>
> > This bug report is to see if the Debian maintainers agree this is wrong.
>
> What's the benefit that you seek by enabling symlinks?
>
> As package maintainers we prefer to avoid diverging too much from upstream.
>
> In particular, this patch is simple enough, but it creates a vector for the
> kind of bugs that upstream wants to avoid. How would we avoid dangling
> symlinks problems?
I'm using symlinks to cache tiles in a particular storage
device/filesystem. I could bind-mount directories, but that complicates
the setup a little. I think that those who are using symlinks (which
involves investigating how marble stores the caches and other data) are
clever enough to dig themselves out of the holes they dug... but I could
be mistaken.
> > Attached you'll find a patch that removes all the references to
> > QDir::NoSymLinks from the code. I tested it and it works fine now. I
> > will keep having this patch around, but I hope you find it useful too,
> > so everyone else can profit from it, and I don't have to recompile
> > marble from time to time :)
>
> How about trying to send this upstream, maybe making this an option?
I think I did a couple of years ago, and I got the answer I mentioned
in the bug report. Yes, I could do it again. I'll try; if I don't
succeed, I think I'll go the bind-mount way... or keep compiling with my
patch.
Thanks for your time. Cheers,
-- Marcos.
--
(Not so) Random fortune:
Terrorism isn't a crime against people or property. It's a crime against
our minds, using the death of innocents and destruction of property to
make us fearful.
-- Bruce Schneier
