Hi, On Thu, Sep 16, 2004 at 12:41:22AM -0700, Steve Langasek wrote: > Feedback on the combined patch: > > debian/rules -- > > Setting -D_REENTRANT here is odd, you normally want this in the > upstream Makefiles (particularly since not everything built by this > package is a library). Not new, though, just moved around, so this is > just a comment.
We have not changed that, I don't want to get bite by that at this time. :> > Setting INSTALL_PROGRAM += -s is redundant, debhelper will strip (or > not) for you automatically. Yes, well it does not harm. :> > debian/gpm.postinst -- > > +# Remove leftover file from an old version > +if [ -e /etc/gpm-root.conf ]; then > + rm -f /etc/gpm-root.conf || true > +fi > > This seems like a questionable change for a t-p-u upload, considering > configuration files are normally only removed on package *purge*. Peter has removed that part. I've found as well that we didn't Build-Depends on debhelper 4, so I've changed that. And Peter has removed a stale and not used patch debian/read. We have tested it on several boxes with sarge and sid systems/chroots and I've upload just a few minutes ago. regards, guillem
