Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock

Hi,

Please unblock package gnome-power-manager

With the current version in testing, (3.22.2-1) the application is not
being associated properly with the .desktop file meaning that its icon
and name are not properly set in the gnome-shell top bar.

The attached patch (already pushed upstream) fixes this by setting the
application id to the desktop file name

unblock gnome-power-manager/3.22.2-2

Regards,

Laurent Bigonville

-- System Information:
Debian Release: 9.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru gnome-power-manager-3.22.2/debian/changelog 
gnome-power-manager-3.22.2/debian/changelog
--- gnome-power-manager-3.22.2/debian/changelog 2016-11-08 16:04:50.000000000 
+0100
+++ gnome-power-manager-3.22.2/debian/changelog 2017-02-23 16:37:20.000000000 
+0100
@@ -1,3 +1,12 @@
+gnome-power-manager (3.22.2-2) unstable; urgency=medium
+
+  * d/p/0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch: Fix
+    the program name so it matches the .desktop file
+  * debian/control.in: Drop the Suggests against policykit-1, pkexec is not
+    used anymore.
+
+ -- Laurent Bigonville <[email protected]>  Thu, 23 Feb 2017 16:37:20 +0100
+
 gnome-power-manager (3.22.2-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru gnome-power-manager-3.22.2/debian/control 
gnome-power-manager-3.22.2/debian/control
--- gnome-power-manager-3.22.2/debian/control   2016-11-08 16:04:50.000000000 
+0100
+++ gnome-power-manager-3.22.2/debian/control   2017-02-23 16:37:20.000000000 
+0100
@@ -6,7 +6,7 @@
 Section: gnome
 Priority: optional
 Maintainer: Debian GNOME Maintainers 
<[email protected]>
-Uploaders: Andreas Henriksson <[email protected]>, Michael Biebl 
<[email protected]>
+Uploaders: Andreas Henriksson <[email protected]>, Laurent Bigonville 
<[email protected]>, Michael Biebl <[email protected]>
 Build-Depends: debhelper (>= 10),
                gnome-pkg-tools (>= 0.10),
                autoconf-archive,
@@ -32,7 +32,6 @@
          default-dbus-session-bus | dbus-session-bus,
          upower (>= 0.99),
          gnome-settings-daemon (>= 3.2)
-Suggests: policykit-1
 Description: power management tool for the GNOME desktop
  GNOME Power Manager is a session daemon for the GNOME desktop
  that takes care of system or desktop events related to power, and
diff -Nru gnome-power-manager-3.22.2/debian/control.in 
gnome-power-manager-3.22.2/debian/control.in
--- gnome-power-manager-3.22.2/debian/control.in        2016-09-19 
23:18:48.000000000 +0200
+++ gnome-power-manager-3.22.2/debian/control.in        2017-02-23 
16:37:20.000000000 +0100
@@ -28,7 +28,6 @@
          default-dbus-session-bus | dbus-session-bus,
          upower (>= 0.99),
          gnome-settings-daemon (>= 3.2)
-Suggests: policykit-1
 Description: power management tool for the GNOME desktop
  GNOME Power Manager is a session daemon for the GNOME desktop
  that takes care of system or desktop events related to power, and
diff -Nru 
gnome-power-manager-3.22.2/debian/patches/0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch
 
gnome-power-manager-3.22.2/debian/patches/0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch
--- 
gnome-power-manager-3.22.2/debian/patches/0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch
   1970-01-01 01:00:00.000000000 +0100
+++ 
gnome-power-manager-3.22.2/debian/patches/0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch
   2017-02-23 16:35:12.000000000 +0100
@@ -0,0 +1,31 @@
+From 9c91bf6ed47265466f06677fddb1940bebfd6e9e Mon Sep 17 00:00:00 2001
+From: Laurent Bigonville <[email protected]>
+Date: Mon, 20 Feb 2017 11:15:48 +0100
+Subject: [PATCH] Rename the application id passed to the gtk_application_new()
+ function
+
+The application id and the desktop file need to match, rename the
+application id here instead of renaming all the other icon and .desktop
+files
+
+https://bugzilla.gnome.org/show_bug.cgi?id=778945
+---
+ src/gpm-statistics.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gpm-statistics.c b/src/gpm-statistics.c
+index b10a9004..ab970fab 100644
+--- a/src/gpm-statistics.c
++++ b/src/gpm-statistics.c
+@@ -1923,7 +1923,7 @@ main (int argc, char *argv[])
+       settings = g_settings_new (GPM_SETTINGS_SCHEMA);
+ 
+       /* are we already activated? */
+-      application = gtk_application_new ("org.gnome.PowerManager.Statistics",
++      application = gtk_application_new ("org.gnome.PowerStats",
+                                          G_APPLICATION_HANDLES_COMMAND_LINE);
+       g_signal_connect (application, "startup",
+                         G_CALLBACK (gpm_stats_startup_cb), NULL);
+-- 
+2.11.0
+
diff -Nru gnome-power-manager-3.22.2/debian/patches/series 
gnome-power-manager-3.22.2/debian/patches/series
--- gnome-power-manager-3.22.2/debian/patches/series    1970-01-01 
01:00:00.000000000 +0100
+++ gnome-power-manager-3.22.2/debian/patches/series    2017-02-23 
16:36:19.000000000 +0100
@@ -0,0 +1 @@
+0001-Rename-the-application-id-passed-to-the-gtk_applicat.patch

Reply via email to