Wouter Verhelst: > Control: tags -1 - moreinfo > Control: retitle -1 unblock: logtool/1.2.8-10 > thanks > > On Thu, Mar 30, 2017 at 08:15:00PM +0000, Niels Thykier wrote: >> 1) Please undo the compat bump; it causes actions at a distance that >> hard to reason about from a diff and as such we have it as a defacto >> policy to reject that kind of change > > Fair enough; uploaded -10 with that reverted. > >> 2) src/Makefile makes an explicit reference to your build path >> (/home). Given it is autotools, I assume that file replaced during >> build and therefore it will "just work(tm)". > > Yes. The only reference to build path is in an explicit setting of > CFLAGS. It's not quite autotools, it uses autoconf but no automake; the > build system doesn't entirely clean up after itself, but I don't think > that's critical (the Makefile does get regenerated). > >> Without the compat bump (and you signing off on the src/Makefile thing), >> I am happy to accept the change. > > Thank you. >
Unblocked, thanks. Btw, I think you may have wanted to run clean before downgrading debhelper. :) At least, I doubt you wanted to include the following files in the source. debian/autoreconf.after | 104 debian/autoreconf.before | 96 We can fix them in a later upload (or post release if there is no other reason for updating logtool in stretch) ~Niels
