Your message dated Tue, 30 May 2017 22:30:02 +0100
with message-id <[email protected]>
and subject line Re: Bug#863730: unblock: gnome-calendar/3.22.4-2
has caused the Debian Bug report #863730,
regarding unblock: gnome-calendar/3.22.4-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
863730: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863730
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package gnome-calendar
It's a targetted two-line fix for a crasher bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=858924
The patch is from upstream, the package has already been uploaded and
was successfully built everywhere.
Full debdiff is attached.
Regards,
Michael
unblock gnome-calendar/3.22.4-2
-- System Information:
Debian Release: 9.0
APT prefers unstable
APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8),
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru gnome-calendar-3.22.4/debian/changelog
gnome-calendar-3.22.4/debian/changelog
--- gnome-calendar-3.22.4/debian/changelog 2017-03-29 23:00:23.000000000
+0200
+++ gnome-calendar-3.22.4/debian/changelog 2017-05-30 10:15:57.000000000
+0200
@@ -1,3 +1,11 @@
+gnome-calendar (3.22.4-2) unstable; urgency=medium
+
+ [ Jason Crain ]
+ * Add debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch:
+ fix crash when creating a new event. (Closes: #858924)
+
+ -- Michael Biebl <[email protected]> Tue, 30 May 2017 10:15:57 +0200
+
gnome-calendar (3.22.4-1) unstable; urgency=medium
* New upstream release.
diff -Nru gnome-calendar-3.22.4/debian/control
gnome-calendar-3.22.4/debian/control
--- gnome-calendar-3.22.4/debian/control 2017-03-29 23:00:23.000000000
+0200
+++ gnome-calendar-3.22.4/debian/control 2017-05-30 10:15:57.000000000
+0200
@@ -6,7 +6,7 @@
Section: gnome
Priority: optional
Maintainer: Debian GNOME Maintainers
<[email protected]>
-Uploaders: Andreas Henriksson <[email protected]>, Iain Lane
<[email protected]>, Michael Biebl <[email protected]>
+Uploaders: Andreas Henriksson <[email protected]>, Michael Biebl
<[email protected]>
Build-Depends: appstream-util,
autoconf-archive,
debhelper (>= 10),
diff -Nru
gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch
gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch
---
gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch
1970-01-01 01:00:00.000000000 +0100
+++
gnome-calendar-3.22.4/debian/patches/0003-set-edit-dialogs-event-to-NULL-after-saving.patch
2017-05-30 09:50:28.000000000 +0200
@@ -0,0 +1,39 @@
+From: Yash Singh <[email protected]>
+Date: Fri, 10 Mar 2017 17:58:52 +0530
+Subject: window: set edit dialog's event to NULL after saving
+
+Earlier the app used to crash when a new event was added using the
+'Edit Details' buttion/dialog. This was happening because edit dialog's
+event was set to NULL before the event was being stored in the calendar
+through the 'edit_dialog' and hence the app was crashing.
+
+This patch fixes the above-mentioned issue by saving the event before
+setting the edit dialog's event to NULL.
+
+Origin: upstream,
https://git.gnome.org/browse/gnome-calendar/commit/?id=6f87ada70dbeae71e3428ee3a63f79b8c918f121
+Bug: https://bugzilla.gnome.org/779733
+Bug-Debian: https://bugs.debian.org/858924
+Last-Update: 2017-05-28
+---
+ src/gcal-window.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/src/gcal-window.c
++++ b/src/gcal-window.c
+@@ -1102,7 +1102,6 @@
+ event = gcal_edit_dialog_get_event (edit_dialog);
+ view = GCAL_VIEW (window->views[window->active_view]);
+
+- gcal_edit_dialog_set_event (edit_dialog, NULL);
+ gtk_widget_hide (GTK_WIDGET (dialog));
+
+ switch (response)
+@@ -1149,6 +1148,8 @@
+ break;
+
+ }
++
++ gcal_edit_dialog_set_event (edit_dialog, NULL);
+ }
+
+ static void
diff -Nru gnome-calendar-3.22.4/debian/patches/series
gnome-calendar-3.22.4/debian/patches/series
--- gnome-calendar-3.22.4/debian/patches/series 2016-09-15 00:30:46.000000000
+0200
+++ gnome-calendar-3.22.4/debian/patches/series 2017-05-30 09:50:28.000000000
+0200
@@ -1,2 +1,3 @@
0001-Hide-GOA-sources-on-Unity.patch
0002-Spawn-Ubuntu-s-credentials-panel-instead-of-the-GOA-.patch
+0003-set-edit-dialogs-event-to-NULL-after-saving.patch
--- End Message ---
--- Begin Message ---
On Tue, May 30, 2017 at 10:08:28PM +0200, Michael Biebl wrote:
> Hm,...
> Given the tiny diff between 3.22.3 and 3.22.4 and the fact that 3.22.4
> has been in unstable for 2 months without new bug reports, maybe
> unblocking 3.22.4-1 would be the best option.
With the auto-foo out of the way, it's not *too* bad and worth getting the
fix for the crash. Unblocked, thanks for the quick turnaround.
--
Jonathan Wiltshire [email protected]
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
--- End Message ---
