Your message dated Fri, 09 Jun 2017 05:58:00 +0000
with message-id <[email protected]>
and subject line Re: Bug#864462: unblock: qla-tools/20140529-2
has caused the Debian Bug report #864462,
regarding unblock: qla-tools/20140529-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
864462: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=864462
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
unblock qla-tools/20140529-2
Hi,
please unblock package qla-tools. #834258 makes the package more or less
useless, because two of four included scripts check for a too old kernel
version. I adjust the case statement and everything is working well.
I've include the debdiff against the package in testing (20140529-1),
which show my fixing patch, a adjusted debhelper version, updated vcs
links and a updated Standards-Version.
I hope it's not to late to unblock qla-tools and ship a working version
within stretch.
Cheers,
Christoph
diff -Nru qla-tools-20140529/debian/changelog qla-tools-20140529/debian/changelog
--- qla-tools-20140529/debian/changelog 2014-08-30 13:53:49.000000000 -0400
+++ qla-tools-20140529/debian/changelog 2017-02-12 12:45:58.000000000 -0500
@@ -1,3 +1,15 @@
+qla-tools (20140529-2) unstable; urgency=medium
+
+ * [e524701] switch to debhelper 9
+ * [651a23b] bump up Standards-Version to 3.9.8
+ * [80855d7] rebuild patch queue from patch-queue branch
+ added patches:
+ - 0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch
+ (Closes: #834258)
+ * [71ccfd9] update Vcs fields
+
+ -- Christoph Goehre <[email protected]> Sun, 12 Feb 2017 12:45:58 -0500
+
qla-tools (20140529-1) unstable; urgency=low
* [9bb7193] Imported Upstream version 20140529 (Closes: #739368)
diff -Nru qla-tools-20140529/debian/compat qla-tools-20140529/debian/compat
--- qla-tools-20140529/debian/compat 2014-08-30 13:53:49.000000000 -0400
+++ qla-tools-20140529/debian/compat 2017-02-12 12:45:58.000000000 -0500
@@ -1 +1 @@
-7
+9
diff -Nru qla-tools-20140529/debian/control qla-tools-20140529/debian/control
--- qla-tools-20140529/debian/control 2014-08-30 13:53:49.000000000 -0400
+++ qla-tools-20140529/debian/control 2017-02-12 12:45:58.000000000 -0500
@@ -2,10 +2,10 @@
Section: admin
Priority: optional
Maintainer: Christoph Goehre <[email protected]>
-Build-Depends: debhelper (>= 7.0.0)
-Standards-Version: 3.9.5
-Vcs-Git: http://anonscm.debian.org/cgit/users/gris/qla-tools.git
-Vcs-Browser: http://anonscm.debian.org/cgit/users/gris/qla-tools.git
+Build-Depends: debhelper (>= 9.0.0)
+Standards-Version: 3.9.8
+Vcs-Git: git://anonscm.debian.org/users/gris/qla-tools.git
+Vcs-Browser: https://anonscm.debian.org/git/users/gris/qla-tools.git
Homepage: http://driverdownloads.qlogic.com
Package: qla-tools
diff -Nru qla-tools-20140529/debian/patches/0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch qla-tools-20140529/debian/patches/0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch
--- qla-tools-20140529/debian/patches/0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch 1969-12-31 19:00:00.000000000 -0500
+++ qla-tools-20140529/debian/patches/0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch 2017-02-12 12:45:58.000000000 -0500
@@ -0,0 +1,37 @@
+From: Christoph Goehre <[email protected]>
+Date: Sun, 12 Feb 2017 12:08:29 -0500
+Subject: let ql-hba-snapshot and ql-dynamic-tgt-lun-disc support kernels >=
+ 4.x
+
+Closes: #834258
+---
+ ql-dynamic-tgt-lun-disc/ql-dynamic-tgt-lun-disc.sh | 2 +-
+ ql-hba-snapshot/ql-hba-snapshot.sh | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/ql-dynamic-tgt-lun-disc/ql-dynamic-tgt-lun-disc.sh b/ql-dynamic-tgt-lun-disc/ql-dynamic-tgt-lun-disc.sh
+index fe03378..9b874ba 100755
+--- a/ql-dynamic-tgt-lun-disc/ql-dynamic-tgt-lun-disc.sh
++++ b/ql-dynamic-tgt-lun-disc/ql-dynamic-tgt-lun-disc.sh
+@@ -1846,7 +1846,7 @@ case ${QL_K_MAJ_MIN} in
+ fi
+ QL_FS=$QL_PROCFS
+ ;;
+- 2.6 | 3.*)
++ 2.6 | 3.* | 4.*)
+ if [ "${QL_HBA_SCAN}" -eq "${QL_FC_SCAN}" ]; then
+ QL_DRIVER=qla2xxx
+ SYS_DRIVER=qla2
+diff --git a/ql-hba-snapshot/ql-hba-snapshot.sh b/ql-hba-snapshot/ql-hba-snapshot.sh
+index 7f07b0a..5555d53 100755
+--- a/ql-hba-snapshot/ql-hba-snapshot.sh
++++ b/ql-hba-snapshot/ql-hba-snapshot.sh
+@@ -1622,7 +1622,7 @@ function print_iscsi_statistics ()
+ KERNEL_VERSION=`uname -r`
+ KERNEL_MAJ_MIN=`echo $KERNEL_VERSION | cut -d . -f -2`
+ case $KERNEL_MAJ_MIN in
+- 2.6 | 3.*)
++ 2.6 | 3.* | 4.*)
+ ;;
+ *)
+ echo "Only Kernel version 2.6 and above are supported"
diff -Nru qla-tools-20140529/debian/patches/series qla-tools-20140529/debian/patches/series
--- qla-tools-20140529/debian/patches/series 2014-08-30 13:53:49.000000000 -0400
+++ qla-tools-20140529/debian/patches/series 2017-02-12 12:45:58.000000000 -0500
@@ -1 +1,2 @@
0001-let-ql-hba-snapshot-support-kernels-3.x.patch
+0002-let-ql-hba-snapshot-and-ql-dynamic-tgt-lun-disc-supp.patch
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Christoph Goehre:
> Package: release.debian.org
> Severity: normal
> User: [email protected]
> Usertags: unblock
>
> unblock qla-tools/20140529-2
>
> Hi,
>
> please unblock package qla-tools. #834258 makes the package more or less
> useless, because two of four included scripts check for a too old kernel
> version. I adjust the case statement and everything is working well.
>
> I've include the debdiff against the package in testing (20140529-1),
> which show my fixing patch, a adjusted debhelper version, updated vcs
> links and a updated Standards-Version.
>
> I hope it's not to late to unblock qla-tools and ship a working version
> within stretch.
>
> Cheers,
> Christoph
>
Unblocked, thanks.
Please avoid debhelper compat bumps during freezes in the future. They
put an unnecessary extra burden in the review (since they change
behaviour of d/rules without showing the change in the diff). In this
case, the package was simple enough that I was willing to do the
additional review - but generally we do not do that.
Thanks,
~Niels
--- End Message ---
