Package: release.debian.org Severity: normal Tags: stretch User: [email protected] Usertags: pu
As released, opendmarc doesn't read it's configuration file which substantially limits the packages usefullness as packaged/released. The attached debdiff changes the service file so the configuration file is actually used and adjusts the configuration file to match the option values previously hard coded in the service file. This is very similar to a change I needed to make in opendkim that has gone well as a stable update, so I believe this is very low risk. The package is built and ready for upload. Scott K
diff -u opendmarc-1.3.2/debian/changelog opendmarc-1.3.2/debian/changelog --- opendmarc-1.3.2/debian/changelog +++ opendmarc-1.3.2/debian/changelog @@ -1,3 +1,12 @@ +opendmarc (1.3.2-2+deb9u1) stretch; urgency=medium + + * Update opendmarc service file so changes in opendmarc.conf are used and + update opendmarc.conf to match values previously hard-coded in the service + file (Closes: #863612) + - Thanks to Jack Bates for the patch + + -- Scott Kitterman <[email protected]> Thu, 04 Jan 2018 20:47:48 -0500 + opendmarc (1.3.2-2) unstable; urgency=medium * Do not remove /etc/default/opendkim on upgrade since it is a conffile diff -u opendmarc-1.3.2/debian/opendmarc.conf opendmarc-1.3.2/debian/opendmarc.conf --- opendmarc-1.3.2/debian/opendmarc.conf +++ opendmarc-1.3.2/debian/opendmarc.conf @@ -12,13 +12,28 @@ ## # FailureReports false -PidFile /var/run/opendmarc.pid +PidFile /var/run/opendmarc/opendmarc.pid ## RejectFailures { true | false } ## default "false" ## RejectFailures false +## Socket socketspec +## default (none) +## +## Specifies the socket that should be established by the filter to receive +## connections from sendmail(8) in order to provide service. socketspec is +## in one of two forms: local:path, which creates a UNIX domain socket at +## the specified path, or inet:port[@host] or inet6:port[@host] which creates +## a TCP socket on the specified port for the appropriate protocol family. +## If the host is not given as either a hostname or an IP address, the +## socket will be listening on all interfaces. This option is mandatory +## either in the configuration file or on the command line. If an IP +## address is used, it must be enclosed in square brackets. +# +Socket local:/var/run/opendmarc/opendmarc.sock + ## Syslog { true | false } ## default "false" ## @@ -65,7 +80,7 @@ ## The process will be assigned all of the groups and primary group ID of ## the named userid unless an alternate group is specified. # -UserID opendmarc:opendmarc +UserID opendmarc ## Path to system copy of PSL (needed to determine organizational domain) # diff -u opendmarc-1.3.2/debian/opendmarc.service opendmarc-1.3.2/debian/opendmarc.service --- opendmarc-1.3.2/debian/opendmarc.service +++ opendmarc-1.3.2/debian/opendmarc.service @@ -7,7 +7,7 @@ Type=forking PIDFile=/var/run/opendmarc/opendmarc.pid User=opendmarc -ExecStart=/usr/sbin/opendmarc -p local:/var/run/opendmarc/opendmarc.sock -u opendmarc -P /var/run/opendmarc/opendmarc.pid +ExecStart=/usr/sbin/opendmarc Restart=on-failure ExecReload=/bin/kill -USR1 $MAINPID
