Your message dated Mon, 06 May 2019 20:26:00 +0000
with message-id <[email protected]>
and subject line Re: Bug#928527: unblock: peek/1.3.1-6
has caused the Debian Bug report #928527,
regarding unblock: peek/1.3.1-6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
928527: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928527
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock peek 1.3.1-6. This upload fixes https://bugs.debian.org/926386 ,
which caused the application to crash when recording GIF using the
ffmpeg backend.
The full debdiff is pasted here.
--
Thanks,
Boyuan Yang
diff -Nru peek-1.3.1/debian/changelog peek-1.3.1/debian/changelog
--- peek-1.3.1/debian/changelog 2019-02-08 13:14:08.000000000 -0500
+++ peek-1.3.1/debian/changelog 2019-05-06 13:27:48.000000000 -0400
@@ -1,3 +1,10 @@
+peek (1.3.1-6) unstable; urgency=high
+
+ * debian/patches: Add patch 0003 to fix double free crashing when
+ passing string array to async function. (Closes: #926386)
+
+ -- Boyuan Yang <[email protected]> Mon, 06 May 2019 13:27:48 -0400
+
peek (1.3.1-5) unstable; urgency=medium
* Rebuild for Debian buster.
diff -Nru
peek-1.3.1/debian/patches/0003-avoid-double-free-when-passing-string-array-to-async-function.patch
peek-1.3.1/debian/patches/0003-avoid-double-free-when-passing-string-array-to-async-function.patch
---
peek-1.3.1/debian/patches/0003-avoid-double-free-when-passing-string-array-to-async-function.patch
1969-12-31 19:00:00.000000000 -0500
+++
peek-1.3.1/debian/patches/0003-avoid-double-free-when-passing-string-array-to-async-function.patch
2019-05-06 13:27:48.000000000 -0400
@@ -0,0 +1,43 @@
+From: Bernhard Übelacker <[email protected]>
+Date: Mon, 6 May 2019 13:29:50 -0400
+Subject: Avoid double free when passing string array to async function
+
+Bug-Debian: https://bugs.debian.org/926386
+Last-Update: 2019-04-20
+Forwarded: https://github.com/phw/peek/issues/419
+---
+ src/post-processing/ffmpeg-post-processor.vala | 20 ++++++++++++--------
+ 1 file changed, 12 insertions(+), 8 deletions(-)
+
+diff --git a/src/post-processing/ffmpeg-post-processor.vala
b/src/post-processing/ffmpeg-post-processor.vala
+index c9727c0..1a3d59c 100644
+--- a/src/post-processing/ffmpeg-post-processor.vala
++++ b/src/post-processing/ffmpeg-post-processor.vala
+@@ -79,15 +79,19 @@ namespace Peek.PostProcessing {
+ var extension = Utils.get_file_extension_for_format
(config.output_format);
+ var output_file = Utils.create_temp_file (extension);
+
+- string[] args = {
+- "ffmpeg", "-y",
+- "-i", input_file.get_path (),
+- "-i", palette_file.get_path (),
+- "-filter_complex", "fps=%d,paletteuse".printf (config.framerate)
+- };
+-
+ var argv = new Array<string> ();
+- argv.append_vals (args, args.length);
++
++ argv.append_val ("ffmpeg");
++ argv.append_val ("-y");
++
++ argv.append_val ("-i");
++ argv.append_val (input_file.get_path ());
++
++ argv.append_val ("-i");
++ argv.append_val (palette_file.get_path ());
++
++ argv.append_val ("-filter_complex");
++ argv.append_val ("fps=%d,paletteuse".printf (config.framerate));
+
+ if (config.output_format == OutputFormat.APNG) {
+ argv.append_val ("-plays");
diff -Nru peek-1.3.1/debian/patches/series peek-1.3.1/debian/patches/series
--- peek-1.3.1/debian/patches/series 2019-02-08 13:13:19.000000000 -0500
+++ peek-1.3.1/debian/patches/series 2019-05-06 13:27:48.000000000 -0400
@@ -1,2 +1,3 @@
0001-src-Backport-upstream-trunk-code-till-20190121.patch
0002-appdata-Fix-validation-warning-The-summary-tag-must-.patch
+0003-avoid-double-free-when-passing-string-array-to-async-function.patch
--- End Message ---
--- Begin Message ---
Boyuan Yang:
> Package: release.debian.org
> Severity: normal
> User: [email protected]
> Usertags: unblock
>
> Please unblock peek 1.3.1-6. This upload fixes https://bugs.debian.org/926386
> ,
> which caused the application to crash when recording GIF using the
> ffmpeg backend.
>
> The full debdiff is pasted here.
>
> --
> Thanks,
> Boyuan Yang
>
> [...]
>
Unblocked, thanks.
~Niels
--- End Message ---
