Your message dated Fri, 17 May 2019 12:43:00 +0000
with message-id <[email protected]>
and subject line Re: Bug#929033: unblock: lxqt-session/0.14.1-2
has caused the Debian Bug report #929033,
regarding unblock: lxqt-session/0.14.1-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
929033: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929033
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package lxqt-session
Fixes the memory leak described in the commit message. The leak can allocate
in rare cases nearly all available RAM and make the machine unusable, original
upstream bug was about games running in wine and was reproducible without
introducing wine and games.
(https://github.com/lxqt/lxqt-session/pull/256)
commit c1e17fdc6344b9108b5cde7d31c5ad1f12a114b6
Author: Alf Gaida <[email protected]>
Date: Sat May 11 15:30:24 2019 +0200
Fixes memory leak in lxqt-session
lxqt-session allocates memory for process output never read (Closes:
#928804)
diff --git a/debian/changelog b/debian/changelog
index 23a2adf..c92df90 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+lxqt-session (0.14.1-2) unstable; urgency=medium
+
+ * Fixes memory leak in lxqt-session, lxqt-session allocates memory for
process
+ output never read (Closes: #928804)
+
+ -- Alf Gaida <[email protected]> Sat, 11 May 2019 15:30:08 +0200
+
lxqt-session (0.14.1-1) unstable; urgency=medium
* Cherry-picking new upstream version 0.14.1.
diff --git a/debian/patches/forward-process-output.patch
b/debian/patches/forward-process-output.patch
new file mode 100644
index 0000000..e8e2faf
--- /dev/null
+++ b/debian/patches/forward-process-output.patch
@@ -0,0 +1,20 @@
+Author: Luís Pereira <[email protected]>
+Date: Thu May 9 21:14:08 2019 +0100
+
+ Don't throw stderr/stdout to a black hole
+ Implement the consensus solution achieved described in
https://github.com/lxqt/lxqt-session/pull/256.
+ It was, actually, one the alternative proposed by
https://github.com/keturn.
+
+diff --git a/lxqt-session/src/lxqtmodman.cpp b/lxqt-session/src/lxqtmodman.cpp
+index 2beff61..d11ffc0 100644
+--- a/lxqt-session/src/lxqtmodman.cpp
++++ b/lxqt-session/src/lxqtmodman.cpp
+@@ -467,6 +467,7 @@ LXQtModule::LXQtModule(const XdgDesktopFile& file,
QObject* parent) :
+ fileName(QFileInfo(file.fileName()).fileName()),
+ mIsTerminating(false)
+ {
++ QProcess::setProcessChannelMode(QProcess::ForwardedChannels);
+ connect(this, SIGNAL(stateChanged(QProcess::ProcessState)),
SLOT(updateState(QProcess::ProcessState)));
+ }
+
+
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..05bd07f
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+forward-process-output.patch
unblock lxqt-session/0.14.1-2
-- System Information:
Debian Release: 10.0
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500,
'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (500,
'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.1.2-towo.2-siduction-amd64 (SMP w/8 CPU cores; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
--- End Message ---
--- Begin Message ---
Alf Gaida:
> Package: release.debian.org
> Severity: normal
> User: [email protected]
> Usertags: unblock
>
> Please unblock package lxqt-session
>
> Fixes the memory leak described in the commit message. The leak can allocate
> in rare cases nearly all available RAM and make the machine unusable, original
> upstream bug was about games running in wine and was reproducible without
> introducing wine and games.
>
> (https://github.com/lxqt/lxqt-session/pull/256)
>
> [...]
>
>
> unblock lxqt-session/0.14.1-2
>
> [...]
Unblocked, thanks.
~Niels
--- End Message ---
