Your message dated Sat, 25 May 2019 19:11:28 +0100
with message-id <[email protected]>
and subject line Re: Bug#928967: unblock: needrestart/3.4-4
has caused the Debian Bug report #928967,
regarding unblock: needrestart/3.4-4
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
928967: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928967
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package needrestart
It fixes an upstream bug which leads to a false positive, see #928225
diff -Naur '--exclude=.svn' 3.4-3/debian/changelog 3.4-4/debian/changelog
--- 3.4-3/debian/changelog 2019-04-18 11:17:08.756032831 +0200
+++ 3.4-4/debian/changelog 2019-05-09 11:26:38.505949290 +0200
@@ -1,3 +1,18 @@
+needrestart (3.4-4) unstable; urgency=medium
+
+ * Add upstream patch 05-strip-leading-zeroes to remove leading zero before
+ testing in map_files.
+ Closes: #928225
+ * Merge 3.4-3~bpo9+1 changelog.
+
+ -- Patrick Matthäi <[email protected]> Thu, 09 May 2019 11:18:46 +0200
+
+needrestart (3.4-3~bpo9+1) stretch-backports; urgency=medium
+
+ * Rebuild for stretch-backports.
+
+ -- Patrick Matthäi <[email protected]> Wed, 24 Apr 2019 10:04:02 +0200
+
needrestart (3.4-3) unstable; urgency=medium
* Add upstream patch 04-restore-cwd to restore the cwd when skipping
diff -Naur '--exclude=.svn' 3.4-3/debian/patches/05-strip-leading-zeroes.diff
3.4-4/debian/patches/05-strip-leading-zeroes.diff
--- 3.4-3/debian/patches/05-strip-leading-zeroes.diff 1970-01-01
01:00:00.000000000 +0100
+++ 3.4-4/debian/patches/05-strip-leading-zeroes.diff 2019-05-09
11:26:38.541949067 +0200
@@ -0,0 +1,23 @@
+From 017c9a11d9a3961477ed79200b2bce8963483575 Mon Sep 17 00:00:00 2001
+From: Thomas Liske <[email protected]>
+Date: Fri, 3 May 2019 22:28:21 +0200
+Subject: [PATCH] [Core] Remove leading zero before testing in map_files
+ (Debian Bug#928225 by Alexander Galanin <[email protected]>).
+
+---
+ needrestart | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/needrestart b/needrestart
+index 2fc3379..ed18920 100755
+--- a/needrestart
++++ b/needrestart
+@@ -504,6 +504,8 @@ if(defined($opt_l)) {
+
+ # check for outdated lib mappings
+ unless($nrconf{skip_mapfiles} == 1) {
++ $maddr =~ s/^0+([^-])/$1/;
++ $maddr =~ s/-0+(.)/-$1/;
+ my @paths = ("/proc/$pid/map_files/$maddr",
"/proc/$pid/root/$path");
+ my ($testp) = grep { -e $_; } @paths;
+ unless($testp) {
diff -Naur '--exclude=.svn' 3.4-3/debian/patches/series
3.4-4/debian/patches/series
--- 3.4-3/debian/patches/series 2019-04-18 11:17:08.756032831 +0200
+++ 3.4-4/debian/patches/series 2019-05-09 11:26:38.517949215 +0200
@@ -2,3 +2,4 @@
02-ignore-networking.diff
03-typo-env-var.diff
04-restore-cwd.diff
+05-strip-leading-zeroes.diff
unblock needrestart/3.4-4
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
--- End Message ---
--- Begin Message ---
Control: tag -1 - moreinfo
On Fri, May 24, 2019 at 12:02:52PM +0200, Patrick Matthäi wrote:
> Am 14.05.2019 um 19:45 schrieb Jonathan Wiltshire:
> > Control: tag -1 moreinfo
> >
> > On Tue, May 14, 2019 at 11:25:57AM +0200, Patrick Matthäi wrote:
> >> +needrestart (3.4-3~bpo9+1) stretch-backports; urgency=medium
> >> +
> >> + * Rebuild for stretch-backports.
> >> +
> >> + -- Patrick Matthäi <[email protected]> Wed, 24 Apr 2019 10:04:02
> >> +0200
> >> +
> > This changelog entry should not be present; 3.4-3~bpo9+1 is not an
> > ancestor of 3.4-4.
> >
> > Thanks,
>
> Wow. For me it is important to have the whole history present in the
> changelog. That this is a blocker...
History, yes, but not metadata for other branches. Tools including the BTS
use changelogs to track ancestry and therefore applied fixes, so the
metadata matters.
> So just for this I have uploaded now 3.4-5 which is more funnier, since
> now the 3.4-3~bpo9+1 changelog entry is mentioned twice:
Unblocked; thanks.
--
Jonathan Wiltshire [email protected]
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
--- End Message ---
