Your message dated Sat, 08 Jun 2019 09:51:00 +0000
with message-id <[email protected]>
and subject line Re: Bug#930135: unblock: speech-dispatcher-contrib/0.9.0-8
has caused the Debian Bug report #930135,
regarding unblock: speech-dispatcher-contrib/0.9.0-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
930135: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930135
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock

Hello,

As reported in #930132, when using the baratinoo speech synthesis, none
of the character spelling triggered by Orca works. So for instance, the
character feedback while typing and character feedback while moving
along text are not working, making the synthesis way less useful for
daily workflow.

This was fixed upstream by a one-liner, as the attached debdiff shows
(which also fixes the previously-requested changelog fixup), could you
unblock it?

unblock speech-dispatcher-contrib/0.9.0-8

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
J'ai beaucoup de mal a lire fcola quand il y a toutes les annonces de howto :
les annonces interessantes sont noyees dans les howto. Ca serait pas mal
de degager toute cette pollution dans un autre groupe.
  JLM in Guide du linuxien pervers : "Cachez ces doc que je ne saurais voir"
diff -Nru speech-dispatcher-contrib-0.9.0/debian/changelog 
speech-dispatcher-contrib-0.9.0/debian/changelog
--- speech-dispatcher-contrib-0.9.0/debian/changelog    2019-06-02 
00:29:03.000000000 +0200
+++ speech-dispatcher-contrib-0.9.0/debian/changelog    2019-06-07 
18:59:02.000000000 +0200
@@ -1,6 +1,14 @@
+speech-dispatcher-contrib (0.9.0-8) unstable; urgency=medium
+
+  * patches/git-baratinoo-char: cherry-pick upstream fix for spelling
+    characters with the baratinoo synthesis (Closes: Bug#930132).
+
+ -- Samuel Thibault <[email protected]>  Fri, 07 Jun 2019 18:59:02 +0200
+
 speech-dispatcher-contrib (0.9.0-7) unstable; urgency=medium
 
   * speech-dispatcher-pico.install: Ship pico.conf (Closes: Bug#929856).
+  * control: Fix description of speech-dispatcher-baratinoo.
 
  -- Samuel Thibault <[email protected]>  Sun, 02 Jun 2019 00:29:03 +0200
 
diff -Nru speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char 
speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char
--- speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char   
1970-01-01 01:00:00.000000000 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char   
2019-06-07 18:48:06.000000000 +0200
@@ -0,0 +1,19 @@
+commit 8018ad3ac98a93a0f64adeca79b0877e9d59e655
+Author: Samuel Thibault <[email protected]>
+Date:   Mon Apr 15 17:41:30 2019 +0200
+
+    baratinoo: do not assume that CHAR commands contain SSML
+
+diff --git a/src/modules/baratinoo.c b/src/modules/baratinoo.c
+index 46fdec17..e1fd64b9 100644
+--- a/src/modules/baratinoo.c
++++ b/src/modules/baratinoo.c
+@@ -472,7 +472,7 @@ int module_speak(gchar *data, size_t bytes, SPDMessageType 
msgtype)
+       case SPD_MSGTYPE_SPELL: /* FIXME: use \spell one day? */
+       case SPD_MSGTYPE_CHAR:
+               g_string_append(buffer, "\\sayas<{characters}");
+-              append_ssml_as_proprietary(engine, buffer, data, bytes);
++              g_string_append_len(buffer, data, bytes);
+               g_string_append(buffer, "\\sayas>{}");
+               break;
+       default: /* FIXME: */
diff -Nru speech-dispatcher-contrib-0.9.0/debian/patches/series 
speech-dispatcher-contrib-0.9.0/debian/patches/series
--- speech-dispatcher-contrib-0.9.0/debian/patches/series       2019-05-18 
17:13:38.000000000 +0200
+++ speech-dispatcher-contrib-0.9.0/debian/patches/series       2019-06-07 
18:48:13.000000000 +0200
@@ -2,3 +2,4 @@
 systemd-debian
 mbrola-paths
 ibmtts-shim
+git-baratinoo-char

--- End Message ---
--- Begin Message ---
Samuel Thibault:
> Package: release.debian.org
> Severity: normal
> User: [email protected]
> Usertags: unblock
> 
> Hello,
> 
> As reported in #930132, when using the baratinoo speech synthesis, none
> of the character spelling triggered by Orca works. So for instance, the
> character feedback while typing and character feedback while moving
> along text are not working, making the synthesis way less useful for
> daily workflow.
> 
> This was fixed upstream by a one-liner, as the attached debdiff shows
> (which also fixes the previously-requested changelog fixup), could you
> unblock it?
> 
> unblock speech-dispatcher-contrib/0.9.0-8
> 
> [...]

Unblocked, thanks.
~Niels

--- End Message ---

Reply via email to