Your message dated Wed, 12 Jun 2019 17:24:59 +0200
with message-id <[email protected]>
and subject line Re: unblock: mailman-suite/0+20180916-9
has caused the Debian Bug report #930222,
regarding unblock: mailman-suite/0+20180916-9
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
930222: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930222
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package mailman-suite
Sorry to prod you again, but while working on mailman-suite I just
realized that the build-time dependency on node-less is completely
useless. So I now dropped it in a subsequent upload. I don't plan to do
any further uploads of mailman3-web targeted for Buster.
Here's the relevant changelog:
mailman-suite (0+20180916-9) unstable; urgency=medium
* d/control, d/patches/0001_settings_py.patch:
* Remove dependency on and reference to lessc/node-less. Mailman3
django projects don't. (Related to #924961)
-- Jonas Meurer <[email protected]> Sat, 08 Jun 2019 17:29:26 +0200
I thoroughly tested the new packages.
For further context, see the discussions at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924961 and
https://mail.python.org/archives/list/[email protected]/thread/HFNP4DPZ3CLXV3OOEJVHCVOLZ7OMAI7G/#HFNP4DPZ3CLXV3OOEJVHCVOLZ7OMAI7G
The debdiff is attached to this bugreport.
unblock mailman-suite/0+20180916-9
Thanks again for your work on the Buster release!
Cheers
jonas
-- System Information:
Debian Release: 10.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set
to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru mailman-suite-0+20180916/debian/changelog
mailman-suite-0+20180916/debian/changelog
--- mailman-suite-0+20180916/debian/changelog 2019-06-07 20:03:29.000000000
+0200
+++ mailman-suite-0+20180916/debian/changelog 2019-06-08 17:29:26.000000000
+0200
@@ -1,3 +1,11 @@
+mailman-suite (0+20180916-9) unstable; urgency=medium
+
+ * d/control, d/patches/0001_settings_py.patch:
+ * Remove dependency on and reference to lessc/node-less. Mailman3
+ django projects don't. (Related to #924961)
+
+ -- Jonas Meurer <[email protected]> Sat, 08 Jun 2019 17:29:26 +0200
+
mailman-suite (0+20180916-8) unstable; urgency=critical
* d/mailman3-web.postinst:
diff -Nru mailman-suite-0+20180916/debian/control
mailman-suite-0+20180916/debian/control
--- mailman-suite-0+20180916/debian/control 2019-06-07 20:03:29.000000000
+0200
+++ mailman-suite-0+20180916/debian/control 2019-06-08 17:29:26.000000000
+0200
@@ -15,7 +15,6 @@
Architecture: all
Depends: dbconfig-sqlite3 | dbconfig-pgsql | dbconfig-mysql |
dbconfig-no-thanks,
lsb-base,
- node-less,
python3,
python3-django-hyperkitty,
python3-django-postorius,
diff -Nru mailman-suite-0+20180916/debian/patches/0001_settings_py.patch
mailman-suite-0+20180916/debian/patches/0001_settings_py.patch
--- mailman-suite-0+20180916/debian/patches/0001_settings_py.patch
2019-06-07 20:03:29.000000000 +0200
+++ mailman-suite-0+20180916/debian/patches/0001_settings_py.patch
2019-06-08 17:29:26.000000000 +0200
@@ -1,6 +1,7 @@
From: Jonas Meurer <[email protected]>
Date: Fri, 14 Sep 2018 23:34:10 +0200
Subject: Adjust settings.py for Debian mailman3-web
+
Forwarded: not-needed
Last-Update: 2019-02-22
@@ -17,12 +18,14 @@
to 0.2 seconds) to decrease the database load.
* Remove paintstore from INSTALLED_APPS, no longer used with hyperkitty
1.2.2.
+* Remove lessc from COMPRESS_COMPILERS, mailman3 django projects don't
+ use/require less at all.
---
- mailman-suite_project/settings.py | 120 +++++++++++++++++---------------------
- 1 file changed, 53 insertions(+), 67 deletions(-)
+ mailman-suite_project/settings.py | 117 +++++++++++++++++---------------------
+ 1 file changed, 51 insertions(+), 66 deletions(-)
diff --git a/mailman-suite_project/settings.py
b/mailman-suite_project/settings.py
-index fbf152b..0bb1c77 100644
+index fbf152b..7d0520a 100644
--- a/mailman-suite_project/settings.py
+++ b/mailman-suite_project/settings.py
@@ -34,7 +34,7 @@ BASE_DIR = os.path.dirname(os.path.abspath(__file__))
@@ -198,7 +201,15 @@
}
-@@ -379,7 +371,7 @@ COMPRESS_PRECOMPILERS = (
+@@ -358,7 +350,6 @@ SOCIALACCOUNT_PROVIDERS = {
+ # https://pypi.python.org/pypi/django_compressor
+ #
+ COMPRESS_PRECOMPILERS = (
+- ('text/less', 'lessc {infile} {outfile}'),
+ ('text/x-scss', 'sassc -t compressed {infile} {outfile}'),
+ ('text/x-sass', 'sassc -t compressed {infile} {outfile}'),
+ )
+@@ -379,7 +370,7 @@ COMPRESS_PRECOMPILERS = (
HAYSTACK_CONNECTIONS = {
'default': {
'ENGINE': 'haystack.backends.whoosh_backend.WhooshEngine',
@@ -207,7 +218,7 @@
# You can also use the Xapian engine, it's faster and more accurate,
# but requires another library.
#
http://django-haystack.readthedocs.io/en/v2.4.1/installing_search_engines.html#xapian
-@@ -396,6 +388,7 @@ Q_CLUSTER = {
+@@ -396,6 +387,7 @@ Q_CLUSTER = {
'timeout': 300,
'save_limit': 100,
'orm': 'default',
@@ -215,7 +226,7 @@
}
-@@ -420,9 +413,9 @@ LOGGING = {
+@@ -420,9 +412,9 @@ LOGGING = {
},
'file':{
'level': 'INFO',
@@ -228,7 +239,7 @@
'formatter': 'verbose',
},
'console': {
-@@ -433,22 +426,23 @@ LOGGING = {
+@@ -433,22 +425,23 @@ LOGGING = {
'loggers': {
'django.request': {
'handlers': ['mail_admins', 'file'],
@@ -256,7 +267,7 @@
},
},
'formatters': {
-@@ -476,14 +470,6 @@ LOGGING = {
+@@ -476,14 +469,6 @@ LOGGING = {
#}
--- End Message ---
--- Begin Message ---
Hi Ivo,
Ivo De Decker:
> On Sat, Jun 08, 2019 at 05:45:56PM +0200, Jonas Meurer wrote:
>> Sorry to prod you again, but while working on mailman-suite I just
>> realized that the build-time dependency on node-less is completely
>> useless. So I now dropped it in a subsequent upload. I don't plan to do
>> any further uploads of mailman3-web targeted for Buster.
>
> If I understand you correctly, the useless dependency is harmless. In that
> case, I'd rather not unblock it, as we are very close to the buster release.
The dependency is harmless in that it doesn't affect the functionality
of the package. Still it's useless and pulls in needless node.js packages.
> If the dependency causes serious issues, please explain and remove the
> moreinfo tag from this bug. Otherwise, please close this bug.
I understand that you don't consider this upload valid for an unblock
request that close to the release. Therefore I'm closing the bugreport.
Cheers
jonas
signature.asc
Description: OpenPGP digital signature
--- End Message ---
