Your message dated Thu, 18 Feb 2021 13:24:08 +0200
with message-id
<cam8zjqtgrnt-r4pqlfp2hwuotgaitp3buwq3mqljtyqmdg2...@mail.gmail.com>
and subject line Re: Bug#982997: unblock:
python-hdf5storage/0.1.15+git20200608.09dfc5f-2
has caused the Debian Bug report #982997,
regarding unblock: python-hdf5storage/0.1.15+git20200608.09dfc5f-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
982997: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982997
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package python-hdf5storage
[ Reason ]
Upstream has identified the problem affecting random failure of tests
reported in RC Bug#971806. It was in a random number used to label
the numpy dtype.
They have prepared a small patch, already commited to the upstream
main branch and applied in
python-hdf5storage/0.1.15+git20200608.09dfc5f-2
[ Impact ]
Preventing python-hdf5storage from migrating to bullseye will have a
negative impact on hdf5storage users attempting to upgrade from
buster, stranding them with a deprecated version of the package.
[ Tests ]
debian/tests run the affected test, which was
test_write_readback.TestPythonMatlabFormat.test_dtype_structured_with_offsets_titles
in tests/test_write_readback.py
This test is now expected to succeed reliably.
[ Risks ]
Minimal clear patch (+6-2 lines) in a leaf package not affecting other
packages. Very low risk.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[ ] attach debdiff against the package in testing
(the package is not currently in testing, the diff is taken against
the preceding version in unstable)
unblock python-hdf5storage/0.1.15+git20200608.09dfc5f-2
diff -Nru python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/changelog
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/changelog
--- python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/changelog
2020-08-07 16:39:18.000000000 +0200
+++ python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/changelog
2021-02-17 21:33:33.000000000 +0100
@@ -1,3 +1,13 @@
+python-hdf5storage (0.1.15+git20200608.09dfc5f-2) unstable; urgency=medium
+
+ * Team upload.
+ * debian patch fix_dtype_random_title_1444936.patch applies
+ upstream commit #1444936 to fix random dtype titles used in tests.
+ Closes: #971806.
+ * Standards-Version: 4.5.1
+
+ -- Drew Parsons <[email protected]> Wed, 17 Feb 2021 21:33:33 +0100
+
python-hdf5storage (0.1.15+git20200608.09dfc5f-1) unstable; urgency=medium
* Team upload.
diff -Nru python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/control
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/control
--- python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/control
2020-08-07 16:39:18.000000000 +0200
+++ python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/control
2021-02-17 21:33:33.000000000 +0100
@@ -18,7 +18,7 @@
python3-sphinx,
python3-sphinx-rtd-theme,
python3-setuptools
-Standards-Version: 4.5.0
+Standards-Version: 4.5.1
Vcs-Browser: https://salsa.debian.org/science-team/python-hdf5storage
Vcs-Git: https://salsa.debian.org/science-team/python-hdf5storage.git
Homepage: https://github.com/frejanordsiek/hdf5storage
diff -Nru
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/fix_dtype_random_title_1444936.patch
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/fix_dtype_random_title_1444936.patch
---
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/fix_dtype_random_title_1444936.patch
1970-01-01 01:00:00.000000000 +0100
+++
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/fix_dtype_random_title_1444936.patch
2021-02-17 21:33:33.000000000 +0100
@@ -0,0 +1,32 @@
+From 144493620a76e44f9012a22f163b14cd5e6cc61b Mon Sep 17 00:00:00 2001
+From: Freja Nordsiek <[email protected]>
+Date: Wed, 17 Feb 2021 19:46:07 +0100
+Subject: [PATCH] Fixed bug (Issue #104) in generating random titles for the
+ dtype fields in the unit tests, which must be unique.
+
+---
+ tests/test_write_readback.py | 8 ++++++--
+ 1 file changed, 6 insertions(+), 2 deletions(-)
+
+Index: python-hdf5storage/tests/test_write_readback.py
+===================================================================
+--- python-hdf5storage.orig/tests/test_write_readback.py 2021-02-17
21:24:21.288834712 +0100
++++ python-hdf5storage/tests/test_write_readback.py 2021-02-17
21:24:21.284834709 +0100
+@@ -846,11 +846,15 @@
+ while s in names and s[0].isdigit():
+ s = random_str_ascii(random.randint(1, 10))
+ names.append(s)
++ titles = []
++ for _ in range(len(names)):
++ s = random_str_some_unicode(random.randint(1, 10))
++ while s in titles:
++ s = random_str_some_unicode(random.randint(1, 10))
++ titles.append(s)
+ formats = [(random.choice(base_dtypes),
+ random_numpy_shape(random.randint(1, 4), 10))
+ for _ in range(len(names))]
+- titles = [random_str_some_unicode(random.randint(1, 10))
+- for _ in range(len(names))]
+ offsets = [random.randint(0, 100)
+ for _ in range(len(names))]
+ desc = {'names': names,
diff -Nru python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/series
python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/series
--- python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/series
2020-08-07 16:39:18.000000000 +0200
+++ python-hdf5storage-0.1.15+git20200608.09dfc5f/debian/patches/series
2021-02-17 21:33:33.000000000 +0100
@@ -1,2 +1,3 @@
Use-system-mathjax.patch
Make-intersphinx-use-local-inventory-files.patch
+fix_dtype_random_title_1444936.patch
--- End Message ---
--- Begin Message ---
Hi Drew
This fix needed to have been uploaded and migrated to testing before
the start of the soft freeze [1].
On Thu, 18 Feb 2021 at 00:51, Drew Parsons <[email protected]> wrote:
> Preventing python-hdf5storage from migrating to bullseye will have a
> negative impact on hdf5storage users attempting to upgrade from
> buster, stranding them with a deprecated version of the package.
Python-hdf5storage was not in buster either.
Regards
Graham
[1] https://release.debian.org/bullseye/freeze_policy.html#soft
--- End Message ---
