Your message dated Mon, 15 Mar 2021 14:47:49 +0000
with message-id <[email protected]>
and subject line unblock fsm-lite
has caused the Debian Bug report #985276,
regarding unblock: fsm-lite/1.0-5
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
985276: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985276
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
X-Debbugs-Cc: [email protected], [email protected]
Please unblock package fsm-lite
(Please provide enough (but not too much) information to help
the release team to judge the request efficiently. E.g. by
filling in the sections below.)
[ Reason ]
The version of fsm-lite i.e. 1.0-4 uses -msse4.2 flag for compiling on
amd64. This is a baseline violation.
Correspondingly, a RC bug had been reported as #985061 and fixed in version
1.0-5
as can be seen here[1]
[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985061
[ Impact ]
The program would crash for users with Illegal instruction error on
earlier versions of amd64 CPU, which do not support SSE4.2 instructions.
[ Tests ]
I do not have access to an older CPU to test this very particular
change, but it now does not use sse4.2 instrcutions for compiling, that
should mitigate the issue.
I installed the fixed version regardless, and it looks good for basic
tweaking that I did. (This package does not have autopkgtests yet, so
complete validity is a bit difficult to ascertain) For sure, there is no
"major" changes in the two versions in unstable and testing.
[ Risks ]
This is a leaf package and is also a non key package. There are no huge
changes. Low risk, I'd say
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
unblock fsm-lite/1.0-5
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 5.7.0-2-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: unable to detect
diff -Nru fsm-lite-1.0/debian/changelog fsm-lite-1.0/debian/changelog
--- fsm-lite-1.0/debian/changelog 2020-11-10 22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/changelog 2021-03-12 20:22:36.000000000 +0530
@@ -1,3 +1,13 @@
+fsm-lite (1.0-5) unstable; urgency=medium
+
+ * Team upload.
+ * debian/rules: Don't pass -msse4.2, ever. Closes: #985061
+ * Standards-Version: 4.5.1 (routine-update)
+ * watch file standard 4 (routine-update)
+ * debian/upstream/metadata: add GitHub repo
+
+ -- Michael R. Crusoe <[email protected]> Fri, 12 Mar 2021 15:52:36 +0100
+
fsm-lite (1.0-4) unstable; urgency=medium
[ Andrius Merkys ]
diff -Nru fsm-lite-1.0/debian/control fsm-lite-1.0/debian/control
--- fsm-lite-1.0/debian/control 2020-11-10 22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/control 2021-03-12 20:22:36.000000000 +0530
@@ -5,7 +5,7 @@
Priority: optional
Build-Depends: debhelper-compat (= 13),
libsdsl-dev
-Standards-Version: 4.5.0
+Standards-Version: 4.5.1
Vcs-Browser: https://salsa.debian.org/med-team/fsm-lite
Vcs-Git: https://salsa.debian.org/med-team/fsm-lite.git
Homepage: https://github.com/nvalimak/fsm-lite
diff -Nru fsm-lite-1.0/debian/patches/fix_makefile.patch
fsm-lite-1.0/debian/patches/fix_makefile.patch
--- fsm-lite-1.0/debian/patches/fix_makefile.patch 2020-11-10
22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/patches/fix_makefile.patch 2021-03-12
20:22:36.000000000 +0530
@@ -1,17 +1,16 @@
Description: Support more architectures
Bug-Debian: http://bugs.debian.org/824368
Author: Andreas Tille <[email protected]>
-Last-Update: Sun, 15 May 2016 09:04:46 +0200
-
---- a/Makefile
-+++ b/Makefile
-@@ -1,11 +1,11 @@
+Last-Update: 2021-03-12
+Forwarded: not-needed
+--- fsm-lite.orig/Makefile
++++ fsm-lite/Makefile
+@@ -1,11 +1,10 @@
-SDSL_INSTALL_PREFIX=${HOME}/software
-
-CPPFLAGS=-std=c++11 -I$(SDSL_INSTALL_PREFIX)/include -DNDEBUG -O3 -msse4.2
+CPPFLAGS+=-DNDEBUG
-+CXXFLAGS+=-std=c++11
-+# -O3 -msse4.2
++CXXFLAGS+=-std=c++11 -O3
LIBS=-lsdsl -ldivsufsort -ldivsufsort64
OBJ = configuration.o input_reader.o fsm-lite.o
@@ -21,7 +20,7 @@
test: fsm-lite
./fsm-lite -l test.list -t tmp -v --debug -m 1
-@@ -14,6 +14,6 @@ clean:
+@@ -14,6 +13,6 @@
$(RM) fsm-lite *.o *~
depend:
diff -Nru fsm-lite-1.0/debian/patches/use_debian_packaged_libsdsl.patch
fsm-lite-1.0/debian/patches/use_debian_packaged_libsdsl.patch
--- fsm-lite-1.0/debian/patches/use_debian_packaged_libsdsl.patch
2020-11-10 22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/patches/use_debian_packaged_libsdsl.patch
2021-03-12 20:22:36.000000000 +0530
@@ -1,6 +1,7 @@
Author: Andreas Tille <[email protected]>
Last-Update: Fri, 08 Apr 2016 10:01:02 +0200
Description: Upstream hardcodes local path to libsdsl which is removed here
+Forwarded: not-needed
--- a/dependencies.mk
+++ b/dependencies.mk
diff -Nru fsm-lite-1.0/debian/rules fsm-lite-1.0/debian/rules
--- fsm-lite-1.0/debian/rules 2020-11-10 22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/rules 2021-03-12 20:21:11.000000000 +0530
@@ -2,20 +2,11 @@
# DH_VERBOSE := 1
-include /usr/share/dpkg/architecture.mk
-
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-ifeq ($(DEB_BUILD_ARCH), amd64)
- CPPFLAGS += -msse4.2
-endif
-
%:
dh $@
-override_dh_auto_build:
- dh_auto_build -- CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)"
-
override_dh_auto_test:
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
echo "Upstream source is lacking file test.list which is needed for
testing."
diff -Nru fsm-lite-1.0/debian/upstream/metadata
fsm-lite-1.0/debian/upstream/metadata
--- fsm-lite-1.0/debian/upstream/metadata 2020-11-10 22:06:49.000000000
+0530
+++ fsm-lite-1.0/debian/upstream/metadata 2021-03-12 20:22:36.000000000
+0530
@@ -1,5 +1,7 @@
Bug-Database: https://github.com/nvalimak/fsm-lite/issues
Bug-Submit: https://github.com/nvalimak/fsm-lite/issues/new
+Repository-Browse: https://github.com/nvalimak/fsm-lite
+Repository: https://github.com/nvalimak/fsm-lite.git
Registry:
- Name: OMICtools
Entry: OMICS_28406
diff -Nru fsm-lite-1.0/debian/watch fsm-lite-1.0/debian/watch
--- fsm-lite-1.0/debian/watch 2020-11-10 22:06:49.000000000 +0530
+++ fsm-lite-1.0/debian/watch 2021-03-12 20:22:36.000000000 +0530
@@ -1,3 +1,3 @@
-version=3
+version=4
https://github.com/nvalimak/fsm-lite/releases
.*/archive/v(\d[\d.-]+)-stable\.(?:tar(?:\.gz|\.bz2)?|tgz)
--- End Message ---
--- Begin Message ---
Unblocked.
--- End Message ---
