Your message dated Sun, 21 Mar 2021 17:43:13 +0000
with message-id <[email protected]>
and subject line unblock gimp
has caused the Debian Bug report #985662,
regarding unblock: gimp/2.10.22-3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
985662: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985662
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package gimp
[ Reason ]
gimp now needs a hard dependency on graphviz as it uses an optional
feature of libgegl that requires the "dot" executable. Adding an hard
dependency on graphviz in libgegl package looks overkill as the other
packages dont seem to use that feature.
I also added a patch that define PATH_MAX for hurd, this is not changing
anything on the release architectures.
[ Impact ]
Without the graphviz package installed, gimp fails to start
[ Tests ]
Gimp now starts, this has been confirmed by some users.
[ Risks ]
Adding the dependency has no risk
PATH_MAX should already be defined in all other architectures than hurd,
so there is also no risks possible here either
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
This has been reported multiple times on the r/debian subreddit, so
there are actuall users impacted by this
unblock gimp/2.10.22-3
diff -Nru gimp-2.10.22/debian/changelog gimp-2.10.22/debian/changelog
--- gimp-2.10.22/debian/changelog 2020-11-24 10:25:51.000000000 +0100
+++ gimp-2.10.22/debian/changelog 2021-03-20 12:21:08.000000000 +0100
@@ -1,3 +1,13 @@
+gimp (2.10.22-3) unstable; urgency=medium
+
+ * debian/control.in: Add graphviz to the dependencies.
+ Some optional functionality of libgegl used in gimp now requires the dot
+ executable shipped in the graphviz package (Closes: #985317)
+ * debian/patches/02_hurd_ftbfs.patch: Fix FTBFS on hurd-i386.
+ Thanks to Svante Signell <[email protected]> (Closes: #934077)
+
+ -- Laurent Bigonville <[email protected]> Sat, 20 Mar 2021 12:21:08 +0100
+
gimp (2.10.22-2) unstable; urgency=medium
* Team upload
diff -Nru gimp-2.10.22/debian/control gimp-2.10.22/debian/control
--- gimp-2.10.22/debian/control 2020-11-24 10:25:51.000000000 +0100
+++ gimp-2.10.22/debian/control 2021-03-20 12:21:08.000000000 +0100
@@ -6,7 +6,7 @@
Priority: optional
Section: graphics
Maintainer: Debian GNOME Maintainers
<[email protected]>
-Uploaders: Iain Lane <[email protected]>, Jeremy Bicha <[email protected]>, Ari
Pollak <[email protected]>
+Uploaders: Iain Lane <[email protected]>, Jeremy Bicha <[email protected]>,
Laurent Bigonville <[email protected]>, Ari Pollak <[email protected]>
Build-Depends: debhelper-compat (= 13),
desktop-file-utils <!nocheck>,
dh-sequence-gnome,
@@ -74,6 +74,7 @@
libgimp2.0 (<= ${source:Upstream-Version}-z),
gimp-data (>= ${source:Upstream-Version}),
gimp-data (<= ${source:Upstream-Version}-z),
+ graphviz,
xdg-utils,
${shlibs:Depends},
${misc:Depends}
diff -Nru gimp-2.10.22/debian/control.in gimp-2.10.22/debian/control.in
--- gimp-2.10.22/debian/control.in 2020-11-24 10:25:51.000000000 +0100
+++ gimp-2.10.22/debian/control.in 2021-03-20 12:21:08.000000000 +0100
@@ -70,6 +70,7 @@
libgimp2.0 (<= ${source:Upstream-Version}-z),
gimp-data (>= ${source:Upstream-Version}),
gimp-data (<= ${source:Upstream-Version}-z),
+ graphviz,
xdg-utils,
${shlibs:Depends},
${misc:Depends}
diff -Nru gimp-2.10.22/debian/patches/02_hurd_ftbfs.patch
gimp-2.10.22/debian/patches/02_hurd_ftbfs.patch
--- gimp-2.10.22/debian/patches/02_hurd_ftbfs.patch 1970-01-01
01:00:00.000000000 +0100
+++ gimp-2.10.22/debian/patches/02_hurd_ftbfs.patch 2021-03-20
12:21:08.000000000 +0100
@@ -0,0 +1,12 @@
+--- a/plug-ins/common/qbist.c
++++ b/plug-ins/common/qbist.c
+@@ -38,6 +38,9 @@
+
+ #include "libgimp/stdplugins-intl.h"
+
++#ifndef PATH_MAX
++#define PATH_MAX 4096
++#endif
+
+ /** qbist renderer
***********************************************************/
+
diff -Nru gimp-2.10.22/debian/patches/series gimp-2.10.22/debian/patches/series
--- gimp-2.10.22/debian/patches/series 2020-11-24 10:25:51.000000000 +0100
+++ gimp-2.10.22/debian/patches/series 2021-03-20 12:21:08.000000000 +0100
@@ -1 +1,2 @@
01_hurd_ftbfs.patch
+02_hurd_ftbfs.patch
--- End Message ---
--- Begin Message ---
Unblocked.
--- End Message ---
