Ah, formally speaking this would also need an ack for the d-i side. Samuel
Samuel Thibault, le jeu. 22 avril 2021 18:33:05 +0200, a ecrit: > Package: release.debian.org > Severity: normal > User: [email protected] > Usertags: unblock > > Hello, > > Please unblock package at-spi2-core > > [ Reason ] > The following bug report: > https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/35 > explains that when using accerciser (the tool to investigate the > accessibility of application), if one closes the application being > investigated, accerciser crashes immediately. This is due to a missing > unlink in the underlying at-spi2-core library, fixed by the proposed > changes. > > [ Impact ] > People working on accessibility usually want to repeat > stopping/restarting the application they hack on, and to avoid > accerciser crashing they would have to remember to always switch > accerciser toward another application before stopping/restarting their > application. Or else have to restart accerciser each time. There is no > real data loss here, but it's very inconvenient > > [ Tests ] > I could test by hand the behavior getting fixed, as well as the bug > reporter. There is no automatic test covering that part of the code > unfortunately, that is why it went mostly unnoticed so far. > > [ Risks ] > The code change is a one-liner, made by upstream. > > [ Checklist ] > [X] all changes are documented in the d/changelog > [X] I reviewed all changes and I approve them > [X] attach debdiff against the package in testing > > Thanks! > > unblock at-spi2-core/2.38.0-4 > diff -Nru at-spi2-core-2.38.0/debian/changelog > at-spi2-core-2.38.0/debian/changelog > --- at-spi2-core-2.38.0/debian/changelog 2020-09-12 23:07:32.000000000 > +0200 > +++ at-spi2-core-2.38.0/debian/changelog 2021-04-22 13:10:24.000000000 > +0200 > @@ -1,3 +1,16 @@ > +at-spi2-core (2.38.0-4) unstable; urgency=medium > + > + * Re-upload to get arch:all built on buildd. > + > + -- Samuel Thibault <[email protected]> Thu, 22 Apr 2021 13:10:24 +0200 > + > +at-spi2-core (2.38.0-3) unstable; urgency=medium > + > + * patches/double-free: Fix double free. Fixes crash of accerciser when > + closing an application. > + > + -- Samuel Thibault <[email protected]> Wed, 21 Apr 2021 23:44:28 +0200 > + > at-spi2-core (2.38.0-2) unstable; urgency=medium > > * Upload to unstable. > diff -Nru at-spi2-core-2.38.0/debian/patches/double-free > at-spi2-core-2.38.0/debian/patches/double-free > --- at-spi2-core-2.38.0/debian/patches/double-free 1970-01-01 > 01:00:00.000000000 +0100 > +++ at-spi2-core-2.38.0/debian/patches/double-free 2021-04-22 > 00:09:27.000000000 +0200 > @@ -0,0 +1,24 @@ > +commit 0b551954386543e97370d97ea1b78dd096edb14e > +Author: Mike Gorse <[email protected]> > +Date: Wed Apr 21 16:37:14 2021 -0500 > + > + Fix double free when removing event listeners > + > + Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/35 > + > +diff --git a/atspi/atspi-event-listener.c b/atspi/atspi-event-listener.c > +index ca6828f..5455b58 100644 > +--- a/atspi/atspi-event-listener.c > ++++ b/atspi/atspi-event-listener.c > +@@ -798,7 +798,10 @@ atspi_event_listener_deregister_from_callback > (AtspiEventListenerCB callback, > + DBusMessage *message, *reply; > + l = g_list_next (l); > + if (in_send) > +- pending_removals = g_list_append (pending_removals, e); > ++ { > ++ pending_removals = g_list_remove (pending_removals, e); > ++ pending_removals = g_list_append (pending_removals, e); > ++ } > + else > + event_listeners = g_list_remove (event_listeners, e); > + for (i = 0; i < matchrule_array->len; i++) > diff -Nru at-spi2-core-2.38.0/debian/patches/series > at-spi2-core-2.38.0/debian/patches/series > --- at-spi2-core-2.38.0/debian/patches/series 2020-09-12 23:07:32.000000000 > +0200 > +++ at-spi2-core-2.38.0/debian/patches/series 2021-04-22 00:09:27.000000000 > +0200 > @@ -2,3 +2,4 @@ > disable-test-that-needs-installed-dbus-service.patch > test_disable_teamspaces > tests > +double-free > _______________________________________________ > Pkg-a11y-devel mailing list > [email protected] > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-a11y-devel
