Your message dated Wed, 12 May 2021 21:08:22 +0000
with message-id <[email protected]>
and subject line unblock linbox
has caused the Debian Bug report #988296,
regarding [pre-approval] unblock: linbox/1.6.3-3
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
988296: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988296
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
X-Debbugs-Cc: [email protected], [email protected],
[email protected]
Please unblock package linbox
[ Reason ]
linbox is scheduled to be removed from testing on June 15 due to RC bug
#987921. The package FTBFS on i386 when compiling with gcc 10 due to an
ambiguous overload error. A fix has been proposed upstream
(https://github.com/linbox-team/linbox/pull/274) and a patch has been written
for the Debian package
(https://salsa.debian.org/science-team/linbox/-/commit/f630fb1). It should
arrive in unstable soon, pending review and sponsorship.
[ Impact ]
The change between the version of the package currently in testing and the
proposed version is minimal (one patch affecting two lines of code) and also
prevents FTBFS on i386.
[ Tests ]
The affected code is covered in test-qlub from the upstream test suite, which
is run during build.
[ Risks ]
Minimal risk -- patch is trivial.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
Thank you!
unblock linbox/1.6.3-3
diff -Nru linbox-1.6.3/debian/changelog linbox-1.6.3/debian/changelog
--- linbox-1.6.3/debian/changelog 2020-02-01 15:09:26.000000000 -0500
+++ linbox-1.6.3/debian/changelog 2021-05-09 12:28:04.000000000 -0400
@@ -1,3 +1,11 @@
+linbox (1.6.3-3) unstable; urgency=medium
+
+ * debian/patches/iterator-difference-type.patch
+ - New patch; use std::ptrdiff_t for vector iterator difference
+ type (Closes: #987921).
+
+ -- Doug Torrance <[email protected]> Sun, 09 May 2021 12:28:04 -0400
+
linbox (1.6.3-2) unstable; urgency=medium
* Team upload.
diff -Nru linbox-1.6.3/debian/patches/iterator-difference-type.patch
linbox-1.6.3/debian/patches/iterator-difference-type.patch
--- linbox-1.6.3/debian/patches/iterator-difference-type.patch 1969-12-31
19:00:00.000000000 -0500
+++ linbox-1.6.3/debian/patches/iterator-difference-type.patch 2021-05-09
12:26:48.000000000 -0400
@@ -0,0 +1,27 @@
+Description: Use std::ptrdiff_t for vector iterator difference type
+Bug: https://github.com/linbox-team/linbox/issues/273
+Bug-Debian: https://bugs.debian.org/987921
+Origin: https://github.com/linbox-team/linbox/pull/274
+Author: Doug Torrance <[email protected]>
+Last-Update: 2021-05-09
+
+--- a/linbox/vector/bit-vector.inl
++++ b/linbox/vector/bit-vector.inl
+@@ -46,7 +46,7 @@
+ typedef LinBox::BitVector::reference reference;
+ typedef bool *pointer;
+ typedef bool value_type;
+- typedef long difference_type;
++ typedef std::ptrdiff_t difference_type;
+ };
+
+ template <>
+@@ -56,7 +56,7 @@
+ typedef LinBox::BitVector::const_reference reference;
+ typedef const bool *pointer;
+ typedef bool value_type;
+- typedef long difference_type;
++ typedef std::ptrdiff_t difference_type;
+ };
+ }
+
diff -Nru linbox-1.6.3/debian/patches/series linbox-1.6.3/debian/patches/series
--- linbox-1.6.3/debian/patches/series 2020-02-01 15:06:40.000000000 -0500
+++ linbox-1.6.3/debian/patches/series 2021-05-09 12:24:55.000000000 -0400
@@ -4,3 +4,4 @@
fix-RR-RecCounter.patch
pkgconfig.patch
replace-dangerous-pointer-casts-with-memcpy.patch
+iterator-difference-type.patch
--- End Message ---
--- Begin Message ---
Unblocked.
--- End Message ---
