Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
Please unblock package golang-go.opencensus [ Reason ] Bug#988250 was marked RC, reporting that Test_Worker_MultiExport occasionally fails in debci testing (approx 1 test in 15 fails, the failure is not reliably reproducible). This patch simply skips the flaky test. [ Impact ] Not much impact if not accepted, only that bullseye debci tests might intermittently fail from time to time which is against Policy. [ Tests ] debci autopkgtests continue to run successfully. [ Risks ] Small patch, simply adds t.Skip() to the flaky test. No other changes, so low risk. [ Checklist ] [x ] all changes are documented in the d/changelog [x ] I reviewed all changes and I approve them [x ] attach debdiff against the package in testing unblock golang-go.opencensus/0.22.4-2
diff -Nru golang-go.opencensus-0.22.4/debian/changelog golang-go.opencensus-0.22.4/debian/changelog --- golang-go.opencensus-0.22.4/debian/changelog 2020-09-30 05:43:15.000000000 +0200 +++ golang-go.opencensus-0.22.4/debian/changelog 2021-05-14 23:11:30.000000000 +0200 @@ -1,3 +1,12 @@ +golang-go.opencensus (0.22.4-2) unstable; urgency=medium + + * Team upload. + * debian patch skip_flaky_test.patch skips Test_Worker_MultiExport + in stats/view. The test is flaky, occasionally failing. + See Debian Bug#988250, upstream Issue#1259. + + -- Drew Parsons <[email protected]> Fri, 14 May 2021 23:11:30 +0200 + golang-go.opencensus (0.22.4-1) unstable; urgency=medium * Team upload. diff -Nru golang-go.opencensus-0.22.4/debian/patches/series golang-go.opencensus-0.22.4/debian/patches/series --- golang-go.opencensus-0.22.4/debian/patches/series 2020-09-30 05:43:15.000000000 +0200 +++ golang-go.opencensus-0.22.4/debian/patches/series 2021-05-14 23:11:30.000000000 +0200 @@ -1 +1,2 @@ 001-disable-test-GET-POST-calls-to-example-com.patch +skip_flaky_test.patch diff -Nru golang-go.opencensus-0.22.4/debian/patches/skip_flaky_test.patch golang-go.opencensus-0.22.4/debian/patches/skip_flaky_test.patch --- golang-go.opencensus-0.22.4/debian/patches/skip_flaky_test.patch 1970-01-01 01:00:00.000000000 +0100 +++ golang-go.opencensus-0.22.4/debian/patches/skip_flaky_test.patch 2021-05-14 23:11:30.000000000 +0200 @@ -0,0 +1,12 @@ +Index: golang-go.opencensus/stats/view/worker_test.go +=================================================================== +--- golang-go.opencensus.orig/stats/view/worker_test.go 2021-05-14 22:49:44.463748299 +0200 ++++ golang-go.opencensus/stats/view/worker_test.go 2021-05-14 23:07:57.578785283 +0200 +@@ -122,6 +122,7 @@ + } + + func Test_Worker_MultiExport(t *testing.T) { ++ t.Skip("Skipping flaky MultiExport test. See Debian Bug#988250.") + restart() + + // This test reports the same data for the default worker and a secondary
