Your message dated Mon, 2 Aug 2021 10:17:52 +0200
with message-id <[email protected]>
and subject line Re: Bug#991701: unblock: python-a38/0.1.3-2
has caused the Debian Bug report #991701,
regarding unblock: python-a38/0.1.3-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
991701: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991701
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: [email protected]
Usertags: unblock
Please unblock package python-a38
[ Reason ]
The attached debdiff provides a fix for bug
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991648 , a test suite
failure caused by an expired certificate that causes an FTBFS.
Upstream fixed this by updating the certificate used by the tests, but
as in this context a certificate with no expiration wouldn't work they
also added code to let the tests be skipped when even that certificate
expires.
Since backporting that patch resulted in an unwieldy debdiff, I opted to
just skip the affected tests in the resulting package.
Both upstream and me are sure that this is purely a broken test issue,
and not a hint of a problem in the code.
[ Tests ]
[ Risks ]
The change only affects the unit tests of the package, and won't change
the behaviour of the library.
The only risk I can see is that this would make the automated tests less
effective at detecting potential future breakage, but I'd expect that to
happen in testing rather than stable, and I intend to upload a version
that re-enables the tests (by using the upstream fix) as soon as
development for bookworm starts.
[ Checklist ]
[✓] all changes are documented in the d/changelog
[✓] I reviewed all changes and I approve them
[✓] attach debdiff against the package in testing
[ Other info ]
thanks in advance
unblock python-a38/0.1.3-2
diff -Nru python-a38-0.1.3/debian/changelog python-a38-0.1.3/debian/changelog
--- python-a38-0.1.3/debian/changelog 2020-12-18 11:44:31.000000000 +0100
+++ python-a38-0.1.3/debian/changelog 2021-07-30 12:01:58.000000000 +0200
@@ -1,3 +1,9 @@
+python-a38 (0.1.3-2) unstable; urgency=medium
+
+ * Skip tests that fail because of an expired certificate. (Closes: #991648)
+
+ -- Elena Grandi <[email protected]> Fri, 30 Jul 2021 12:01:58 +0200
+
python-a38 (0.1.3-1) unstable; urgency=medium
[ Ondřej Nový ]
diff -Nru
python-a38-0.1.3/debian/patches/0001-Skip-tests-that-fail-because-of-an-expired-certifica.patch
python-a38-0.1.3/debian/patches/0001-Skip-tests-that-fail-because-of-an-expired-certifica.patch
---
python-a38-0.1.3/debian/patches/0001-Skip-tests-that-fail-because-of-an-expired-certifica.patch
1970-01-01 01:00:00.000000000 +0100
+++
python-a38-0.1.3/debian/patches/0001-Skip-tests-that-fail-because-of-an-expired-certifica.patch
2021-07-30 12:01:58.000000000 +0200
@@ -0,0 +1,30 @@
+From: Elena Grandi <[email protected]>
+Date: Fri, 30 Jul 2021 12:00:27 +0200
+Forwarded: not-needed
+Subject: Skip tests that fail because of an expired certificate.
+
+---
+ tests/test_p7m.py | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/tests/test_p7m.py b/tests/test_p7m.py
+index e955bd4..fe982e7 100644
+--- a/tests/test_p7m.py
++++ b/tests/test_p7m.py
+@@ -1,4 +1,4 @@
+-from unittest import TestCase
++from unittest import TestCase, skip
+ import tempfile
+ from contextlib import contextmanager
+ import os
+@@ -39,7 +39,9 @@ WGPH+t5X7ZMMERXn8Z/2LTYWuj9w1+WeieY=
+
+ CA_CERT_HASH = "af603d58.0"
+
+-
++# The following tests are failing because of an expired certificate, and
++# a certificate with no expiration wouldn't work in this context.
++@skip("certificate expired")
+ class TestAnagrafica(TestCase):
+ @contextmanager
+ def capath(self):
diff -Nru python-a38-0.1.3/debian/patches/series
python-a38-0.1.3/debian/patches/series
--- python-a38-0.1.3/debian/patches/series 1970-01-01 01:00:00.000000000
+0100
+++ python-a38-0.1.3/debian/patches/series 2021-07-30 12:01:58.000000000
+0200
@@ -0,0 +1 @@
+0001-Skip-tests-that-fail-because-of-an-expired-certifica.patch
--- End Message ---
--- Begin Message ---
Hi Elena,
On 31-07-2021 17:25, Sebastian Ramacher wrote:
> This appears to be a pre-approval request. Please go ahead, but keep in
> mind that the window for bullseye is closing.
unblocked.
Paul
OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
