On 3 December 2021 9:41:48 pm IST, Julien Cristau <[email protected]> wrote: >On Tue, Sep 07, 2021 at 12:27:05AM +0530, Nilesh Patra wrote: >> diff -Nru segemehl-0.3.4/debian/patches/arm64.patch >> segemehl-0.3.4/debian/patches/arm64.patch >> --- segemehl-0.3.4/debian/patches/arm64.patch 1970-01-01 >> 05:30:00.000000000 +0530 >> +++ segemehl-0.3.4/debian/patches/arm64.patch 2021-09-06 >> 23:43:50.000000000 +0530 >> @@ -0,0 +1,75 @@ >> +Description: Change the signed-ness for several chars to fix segfault >> +Author: Nilesh Patra <[email protected]> >> +Last-Update: 2021-08-24 >> +--- a/libs/biofiles.c >> ++++ b/libs/biofiles.c >> +@@ -1916,7 +1916,7 @@ >> + Uint max, Uint *minlen, Uint *maxlen, unsigned char *minq, unsigned >> char *maxq) >> + { >> + >> +- char ch; >> ++ signed char ch; >> + char idchar=0; >> + int ret=0; >> + off_t curseqoffset, lastindexoffset=0; > >Shouldn't `ch` be an `int` instead, to match the return value of getc, >and type of EOF? > >Anyway, I guess this is fine if it works...
Should I upload this to p-u?
