Control: tags -1 confirmed Control: tags 1017412 confirmed On 2022-08-17 03:42:18 +0800, Shengjing Zhu wrote: > On Wed, Aug 17, 2022 at 3:07 AM Sebastian Ramacher <[email protected]> > wrote: > > > > On 2022-08-15 20:35:49 +0800, Shengjing Zhu wrote: > > > CC spdlog maintainer as well. > > > > > > On Mon, Aug 15, 2022 at 01:45:32PM +0200, Sebastian Ramacher wrote: > > > > Let's note hide spdlog's ABI breakage that is unreleated to the fmtlib > > > > transition. Please fix this issue first and remove the moreinfo tag once > > > > that's done. > > > > > > What's your suggestions to fix the spdlog ABI breakage? > > > > The ABI breakage was caused by adding a new argument to some functions > > with a default argument. This could be fixed by keeping the old > > functions around. > > > > TBH, given libspdlog1.10 is in experimental, I feel it's more correct > to just do a spdlog transition.
Please go ahead with both uploads. Cheers -- Sebastian Ramacher
