Your message dated Sun, 30 Apr 2023 08:21:30 +0200
with message-id <[email protected]>
and subject line Re: unblock: image-factory/1.0.2-1.1
has caused the Debian Bug report #1034786,
regarding unblock: image-factory/1.0.2-1.1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1034786: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034786
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: [email protected], [email protected],
[email protected]
User: [email protected]
Usertags: unblock
Please unblock package image-factory.
[ Reason ]
This update allows the python package to build without error by passing
test_pylint, the only failed test during dh_auto_test. The failed test
was fixed by replacing the broad exception types with appropriate error
types (see #1033424).
[ Impact ]
With this fix, the package does not FTBFS from failing test_pylint. The
python package now builds as expected. image-factory has no
reverse-dependencies, so there is no impact on other packages.
[ Tests ]
dh_auto_test runs during the build and would fail the build if tests
failed. I installed the new .deb and ran `image-factory --help` in a
terminal and got the expected output. The updates were also reviewed by
the DD who signed and uploaded the package.
[ Risks ]
image-factory has no reverse-dependencies so there are no risks.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
unblock: image-factory/1.0.2-1.1
--
Josef Schneider
GPG Fingerprint 3267 0331 DB61 A817 7D25 4D05 5A44 BC12 F2A8 E58F
diff -Nru image-factory-1.0.2/debian/changelog
image-factory-1.0.2/debian/changelog
--- image-factory-1.0.2/debian/changelog 2021-11-12 16:52:40.000000000
+0100
+++ image-factory-1.0.2/debian/changelog 2023-04-12 15:50:18.000000000
+0200
@@ -1,3 +1,11 @@
+image-factory (1.0.2-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches: Add 0001-replace-broad-exceptions.patch.
+ + Pass pylint test and fix FTBFS (Closes: #1033424).
+
+ -- Josef Schneider <[email protected]> Wed, 12 Apr 2023 15:50:18 +0200
+
image-factory (1.0.2-1) unstable; urgency=medium
* New upstream release
diff -Nru
image-factory-1.0.2/debian/patches/0001-replace-broad-exceptions.patch
image-factory-1.0.2/debian/patches/0001-replace-broad-exceptions.patch
--- image-factory-1.0.2/debian/patches/0001-replace-broad-exceptions.patch
1970-01-01 01:00:00.000000000 +0100
+++ image-factory-1.0.2/debian/patches/0001-replace-broad-exceptions.patch
2023-04-12 15:50:18.000000000 +0200
@@ -0,0 +1,43 @@
+From a32952d31c02d2ce2425032e1960c0c292a29855 Mon Sep 17 00:00:00 2001
+From: Josef Schneider <[email protected]>
+Date: Wed, 12 Apr 2023 15:49:41 +0200
+Subject: [PATCH] replace broad exceptions
+
+---
+ image-factory | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/image-factory b/image-factory
+index f8dffe0..5130fd7 100755
+--- a/image-factory
++++ b/image-factory
+@@ -61,7 +61,7 @@ def get_config():
+ if env_name in os.environ:
+ config_files = [os.environ[env_name]]
+ if not os.path.isfile(config_files[0]):
+- raise Exception(
++ raise FileNotFoundError(
+ "'" + config_files[0] + "' (set in " + env_name + ") is not a
valid file."
+ )
+ else:
+@@ -135,7 +135,7 @@ def cache_file(cache_dir, source):
+ elif source.startswith("rsync:"):
+ call_command(["rsync", "--no-motd", source, destination])
+ else:
+- raise Exception(f"No download handler for file '{source}' found.")
++ raise ValueError(f"No download handler for file '{source}' found.")
+ return relative_destination
+
+
+@@ -163,7 +163,7 @@ def download_and_publish(config, image, source, filename):
+ elif source.startswith("rsync:"):
+ call_command(["rsync", "--no-motd", source, destination])
+ else:
+- raise Exception(f"No download handler for file '{source}' found.")
++ raise ValueError(f"No download handler for file '{source}' found.")
+ return destination
+
+
+--
+2.38.1
+
diff -Nru image-factory-1.0.2/debian/patches/series
image-factory-1.0.2/debian/patches/series
--- image-factory-1.0.2/debian/patches/series 1970-01-01 01:00:00.000000000
+0100
+++ image-factory-1.0.2/debian/patches/series 2023-04-12 15:50:18.000000000
+0200
@@ -0,0 +1 @@
+0001-replace-broad-exceptions.patch
OpenPGP_0x5A44BC12F2A8E58F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Hi,
On 24-04-2023 14:45, Josef Schneider wrote:
unblock: image-factory/1.0.2-1.1
done.
Paul
OpenPGP_signature
Description: OpenPGP digital signature
--- End Message ---
