Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: Andreas Tille <ti...@debian.org>

Please unblock package r-cran-pander

[ Reason ]
r-cran-pander needs jquery-1.7.2.js (it is unknown whether newer
versions would work, too), but that is no longer available in the Debian
archive, causing the package to ship a broken symlink.
Therefore let the package ship a copy of the old jquery version.

[ Impact ]
Some r-cran-pander functionality may be missing and/or cause errors due
to missing .js files.

[ Tests ]
piuparts stops reporting a broken symlink (in a lot of packages
depending on this one).

[ Risks ]
testing/porting r-cran-pander for use with newer jquery versions might
be more difficult and risky than using a known good version.
The node-jquery-ui dependency might now be superfluous.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [ ] attach debdiff against the package in testing

[ Other info ]

$ diffstat r-cran-pander_0.6.5+dfsg-3.dsc.diff.xz
 changelog                                  |    8
 missing-sources/jquery/get                 |    2
 missing-sources/jquery/jquery-1.7.2.js     | 9404 +++++++++++++++++++++++++++++
 missing-sources/jquery/jquery-1.7.2.min.js |   23
 rules                                      |    4
 5 files changed, 9438 insertions(+), 3 deletions(-)
(compressed diff is still > 90kb)

$ filterdiff -x '*.js' r-cran-pander_0.6.5+dfsg-3.dsc.diff
diff -Nru r-cran-pander-0.6.5+dfsg/debian/changelog 
r-cran-pander-0.6.5+dfsg/debian/changelog
--- r-cran-pander-0.6.5+dfsg/debian/changelog   2023-02-21 21:25:31.000000000 
+0100
+++ r-cran-pander-0.6.5+dfsg/debian/changelog   2023-05-19 12:38:06.000000000 
+0200
@@ -1,3 +1,11 @@
+r-cran-pander (0.6.5+dfsg-3) unstable; urgency=medium
+
+  * Provide source and compressed JS of jquery 1.7.2 since it is not
+    provided by any other package any more
+    Closes: #1035855
+
+ -- Andreas Tille <ti...@debian.org>  Fri, 19 May 2023 12:38:06 +0200
+
 r-cran-pander (0.6.5+dfsg-2) unstable; urgency=medium

   * Pre-compress jcaption.js to avoid calling closure-compiler at
diff -Nru r-cran-pander-0.6.5+dfsg/debian/missing-sources/jquery/get 
r-cran-pander-0.6.5+dfsg/debian/missing-sources/jquery/get
--- r-cran-pander-0.6.5+dfsg/debian/missing-sources/jquery/get  1970-01-01 
01:00:00.000000000 +0100
+++ r-cran-pander-0.6.5+dfsg/debian/missing-sources/jquery/get  2023-05-19 
12:38:06.000000000 +0200
@@ -0,0 +1,2 @@
+wget http://code.jquery.com/jquery-1.7.2.js
+yui-compressor  jquery-1.7.2.js > jquery-1.7.2.min.js
diff -Nru r-cran-pander-0.6.5+dfsg/debian/rules 
r-cran-pander-0.6.5+dfsg/debian/rules
--- r-cran-pander-0.6.5+dfsg/debian/rules       2023-02-21 21:25:31.000000000 
+0100
+++ r-cran-pander-0.6.5+dfsg/debian/rules       2023-05-19 12:38:06.000000000 
+0200
@@ -8,6 +8,7 @@
 override_dh_install:
        dh_install
        dh_install debian/missing-sources/jcaption/jcaption.min.js      
$(debRdir)/$(cranNameOrig)/includes/javascripts/
+       dh_install debian/missing-sources/jquery/jquery-1.7.2.min.js    
$(debRdir)/$(cranNameOrig)/includes/javascripts/
        dh_install debian/missing-sources/rapporter.net/*.gif           
$(debRdir)/$(cranNameOrig)/includes/images/
        dh_install debian/missing-sources/stylesheets/*.css             
$(debRdir)/$(cranNameOrig)/includes/stylesheets/
        sed -i \
@@ -18,6 +19,3 @@
            -e '/html5shim/d' \
            $(debRlib)/$(cranNameOrig)/includes/html/header.html
        find  debian -name index.html | xargs sed -i 's|library|site-library|g'
-
-override_dh_link:
-       dh_link /usr/share/nodejs/jquery-ui/ui/jquery-1-7.min.js 
$(debRdir)/$(cranNameOrig)/includes/javascripts/jquery-1.7.2.min.js

unblock r-cran-pander/0.6.5+dfsg-3

Andreas

Reply via email to