Your message dated Wed, 18 Jun 2025 10:06:16 +0000
with message-id <[email protected]>
and subject line unblock lomiri-indicator-location
has caused the Debian Bug report #1107851,
regarding unblock: lomiri-indicator-location/25.4.22-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
1107851: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107851
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: [email protected]
Control: affects -1 + src:lomiri-indicator-location
User: [email protected]
Usertags: unblock

Please unblock package lomiri-indicator-location

[ Reason ]

+  * debian/patches:
+    + Add 0001_Fix-desktop-profiles-and-add-greeter-support.patch. Let location
+      indicator alreay appear in Lomiri Greeter (and allow enabling/disabling
+      location service access before login).

-> Add a patch that makes the enable/disable toggle switch available
prior to session login. This allows disabling (or enabling) location
service before user login (i.e. before any user data/service can access
the location service in the background and reveal location data).

[ Impact ]
-> No such privacy enhancement.

[ Tests ]
Manual tests in a VM.

[ Risks ]
Minimal, only for Lomiri / Lomiri Greeter users.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
Relevant for Lomiri in Debian.

unblock lomiri-indicator-location/25.4.22-2
diff -Nru lomiri-indicator-location-25.4.22/debian/changelog 
lomiri-indicator-location-25.4.22/debian/changelog
--- lomiri-indicator-location-25.4.22/debian/changelog  2025-04-22 
10:25:02.000000000 +0200
+++ lomiri-indicator-location-25.4.22/debian/changelog  2025-06-15 
21:31:22.000000000 +0200
@@ -1,3 +1,12 @@
+lomiri-indicator-location (25.4.22-2) unstable; urgency=medium
+
+  * debian/patches:
+    + Add 0001_Fix-desktop-profiles-and-add-greeter-support.patch. Let location
+      indicator alreay appear in Lomiri Greeter (and allow enabling/disabling
+      location service access before login).
+
+ -- Mike Gabriel <[email protected]>  Sun, 15 Jun 2025 21:31:22 +0200
+
 lomiri-indicator-location (25.4.22-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru 
lomiri-indicator-location-25.4.22/debian/patches/0001_Fix-desktop-profiles-and-add-greeter-support.patch
 
lomiri-indicator-location-25.4.22/debian/patches/0001_Fix-desktop-profiles-and-add-greeter-support.patch
--- 
lomiri-indicator-location-25.4.22/debian/patches/0001_Fix-desktop-profiles-and-add-greeter-support.patch
    1970-01-01 01:00:00.000000000 +0100
+++ 
lomiri-indicator-location-25.4.22/debian/patches/0001_Fix-desktop-profiles-and-add-greeter-support.patch
    2025-06-15 21:29:38.000000000 +0200
@@ -0,0 +1,47 @@
+From 3ce84bedcdcf13febc0644f3a5d20c90c0b97f98 Mon Sep 17 00:00:00 2001
+From: Robert Tari <[email protected]>
+Date: Mon, 2 Jun 2025 06:22:56 +0200
+Subject: [PATCH] Fix desktop profiles
+
+Signed-off-by: Mike Gabriel <[email protected]>
+---
+ data/com.lomiri.indicator.location | 8 ++++++++
+ src/phone.cc                       | 8 +++++++-
+ 2 files changed, 15 insertions(+), 1 deletion(-)
+
+diff --git a/data/com.lomiri.indicator.location 
b/data/com.lomiri.indicator.location
+index 6de45fa..b91030c 100644
+--- a/data/com.lomiri.indicator.location
++++ b/data/com.lomiri.indicator.location
+@@ -11,3 +11,11 @@ Position=60
+ ObjectPath=/com/lomiri/indicator/location/phone
+ Position=60
+ 
++[desktop]
++ObjectPath=/com/lomiri/indicator/location/phone
++Position=60
++
++[desktop_greeter]
++ObjectPath=/com/lomiri/indicator/location/phone
++Position=60
++
+diff --git a/src/phone.cc b/src/phone.cc
+index 59e3578..a0df212 100644
+--- a/src/phone.cc
++++ b/src/phone.cc
+@@ -306,5 +306,11 @@ void Phone::rebuild_submenu()
+     g_menu_append_item(submenu.get(), location);
+     g_object_unref(location);
+ 
+-    g_menu_append(submenu.get(), _("Location settings…"), "indicator." 
SETTINGS_ACTION_KEY "::location");
++    const gchar *sUserName = g_get_user_name ();
++    gboolean bGreeter = g_str_equal (sUserName, "lightdm");
++
++    if (!bGreeter)
++    {
++        g_menu_append(submenu.get(), _("Location settings…"), "indicator." 
SETTINGS_ACTION_KEY "::location");
++    }
+ }
+-- 
+2.47.2
+
diff -Nru lomiri-indicator-location-25.4.22/debian/patches/series 
lomiri-indicator-location-25.4.22/debian/patches/series
--- lomiri-indicator-location-25.4.22/debian/patches/series     2025-04-22 
10:25:02.000000000 +0200
+++ lomiri-indicator-location-25.4.22/debian/patches/series     2025-06-15 
21:30:14.000000000 +0200
@@ -1 +1,2 @@
 1002_use-pkgconf-systemd-user-dir.patch
+0001_Fix-desktop-profiles-and-add-greeter-support.patch

--- End Message ---
--- Begin Message ---
Unblocked lomiri-indicator-location.

--- End Message ---

Reply via email to