Your message dated Mon, 30 Jun 2025 21:03:11 +0200
with message-id <[email protected]>
and subject line Re: Bug#1108520: unblock: feedbackd-device-themes/0.8.3-2
has caused the Debian Bug report #1108520,
regarding unblock: feedbackd-device-themes/0.8.3-2
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1108520: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108520
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: [email protected]
Control: affects -1 + src:feedbackd-device-themes
User: [email protected]
Usertags: unblock
Please unblock package feedbackd-device-themes
[ Reason ]
Fixes haptic feedback for on screen keyboard key presses on Pixel 3A
phones (which are popular in Mobian)
[ Impact ]
Only affects the Pixel 3A
[ Tests ]
Verified feedback is now noticeable again, feedbackd tests passed
[ Risks ]
It's a configuration change, no code changes and affects only one
particular device (determined by device tree compatible)
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
The patch is identical to what is used upstream for 0.8.4.
unblock feedbackd-device-themes/0.8.3-2
diff --git a/debian/changelog b/debian/changelog
index 3c94c3f..286aad3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+feedbackd-device-themes (0.8.3-2) unstable; urgency=medium
+
+ * Backport upstream fix to make key-press feedback stronger
+ on google,sargo
+
+ -- Guido Günther <[email protected]> Fri, 30 May 2025 17:57:44 +0200
+
feedbackd-device-themes (0.8.3-1) unstable; urgency=medium
* New upstream release
diff --git a/debian/patches/google-sargo-Make-feedback-stronger.patch b/debian/patches/google-sargo-Make-feedback-stronger.patch
new file mode 100644
index 0000000..ea191d1
--- /dev/null
+++ b/debian/patches/google-sargo-Make-feedback-stronger.patch
@@ -0,0 +1,47 @@
+From: =?utf-8?q?Guido_G=C3=BCnther?= <[email protected]>
+Date: Tue, 13 May 2025 16:57:23 +0200
+Subject: google,sargo: Make feedback stronger
+MIME-Version: 1.0
+Content-Type: text/plain; charset="utf-8"
+Content-Transfer-Encoding: 8bit
+
+The current value is still not sufficient.
+
+Fixes a04694f ("data: Add google sargo")
+
+Closes: https://gitlab.freedesktop.org/agx/feedbackd/-/issues/90
+Signed-off-by: Guido Günther <[email protected]>
+(cherry picked from commit b8347f83f08b5fe4345c86f80ab1a40b2a21abd9)
+---
+ data/google,sargo.json | 6 +++---
+ data/meson.build | 1 +
+ 2 files changed, 4 insertions(+), 3 deletions(-)
+
+diff --git a/data/google,sargo.json b/data/google,sargo.json
+index 85136b3..b122694 100644
+--- a/data/google,sargo.json
++++ b/data/google,sargo.json
+@@ -6,10 +6,10 @@
+ "name" : "quiet",
+ "feedbacks" : [
+ {
+- "event-name" : "button-press-event",
++ "event-name" : "button-pressed",
+ "type" : "VibraPattern",
+- "magnitudes" : [ 0.4 ],
+- "durations" : [ 7 ]
++ "magnitudes" : [ 0.5 ],
++ "durations" : [ 15 ]
+ }
+ ]
+ }
+diff --git a/data/meson.build b/data/meson.build
+index f67819f..8d38c3a 100644
+--- a/data/meson.build
++++ b/data/meson.build
+@@ -1,4 +1,5 @@
+ theme_json = [
++ 'google,sargo.json',
+ 'oneplus,enchilada.json',
+ 'oneplus,fajita.json',
+ 'pine64,pinephone.json',
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..1064f6b
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+google-sargo-Make-feedback-stronger.patch
--- End Message ---
--- Begin Message ---
On 2025-06-30 14:37:28 +0200, Guido G�nther wrote:
> Package: release.debian.org
> Severity: normal
> X-Debbugs-Cc: [email protected]
> Control: affects -1 + src:feedbackd-device-themes
> User: [email protected]
> Usertags: unblock
>
> Please unblock package feedbackd-device-themes
The package has succesful autopkgtests and is not a ky package. It will
migrate without an action from our side.
Cheers
>
> [ Reason ]
> Fixes haptic feedback for on screen keyboard key presses on Pixel 3A
> phones (which are popular in Mobian)
>
> [ Impact ]
> Only affects the Pixel 3A
>
> [ Tests ]
> Verified feedback is now noticeable again, feedbackd tests passed
>
> [ Risks ]
> It's a configuration change, no code changes and affects only one
> particular device (determined by device tree compatible)
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in testing
>
> The patch is identical to what is used upstream for 0.8.4.
>
> unblock feedbackd-device-themes/0.8.3-2
>
> diff --git a/debian/changelog b/debian/changelog
> index 3c94c3f..286aad3 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,10 @@
> +feedbackd-device-themes (0.8.3-2) unstable; urgency=medium
> +
> + * Backport upstream fix to make key-press feedback stronger
> + on google,sargo
> +
> + -- Guido G�nther <[email protected]> Fri, 30 May 2025 17:57:44 +0200
> +
> feedbackd-device-themes (0.8.3-1) unstable; urgency=medium
>
> * New upstream release
> diff --git a/debian/patches/google-sargo-Make-feedback-stronger.patch
> b/debian/patches/google-sargo-Make-feedback-stronger.patch
> new file mode 100644
> index 0000000..ea191d1
> --- /dev/null
> +++ b/debian/patches/google-sargo-Make-feedback-stronger.patch
> @@ -0,0 +1,47 @@
> +From: =?utf-8?q?Guido_G=C3=BCnther?= <[email protected]>
> +Date: Tue, 13 May 2025 16:57:23 +0200
> +Subject: google,sargo: Make feedback stronger
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset="utf-8"
> +Content-Transfer-Encoding: 8bit
> +
> +The current value is still not sufficient.
> +
> +Fixes a04694f ("data: Add google sargo")
> +
> +Closes: https://gitlab.freedesktop.org/agx/feedbackd/-/issues/90
> +Signed-off-by: Guido G�nther <[email protected]>
> +(cherry picked from commit b8347f83f08b5fe4345c86f80ab1a40b2a21abd9)
> +---
> + data/google,sargo.json | 6 +++---
> + data/meson.build | 1 +
> + 2 files changed, 4 insertions(+), 3 deletions(-)
> +
> +diff --git a/data/google,sargo.json b/data/google,sargo.json
> +index 85136b3..b122694 100644
> +--- a/data/google,sargo.json
> ++++ b/data/google,sargo.json
> +@@ -6,10 +6,10 @@
> + "name" : "quiet",
> + "feedbacks" : [
> + {
> +- "event-name" : "button-press-event",
> ++ "event-name" : "button-pressed",
> + "type" : "VibraPattern",
> +- "magnitudes" : [ 0.4 ],
> +- "durations" : [ 7 ]
> ++ "magnitudes" : [ 0.5 ],
> ++ "durations" : [ 15 ]
> + }
> + ]
> + }
> +diff --git a/data/meson.build b/data/meson.build
> +index f67819f..8d38c3a 100644
> +--- a/data/meson.build
> ++++ b/data/meson.build
> +@@ -1,4 +1,5 @@
> + theme_json = [
> ++ 'google,sargo.json',
> + 'oneplus,enchilada.json',
> + 'oneplus,fajita.json',
> + 'pine64,pinephone.json',
> diff --git a/debian/patches/series b/debian/patches/series
> new file mode 100644
> index 0000000..1064f6b
> --- /dev/null
> +++ b/debian/patches/series
> @@ -0,0 +1 @@
> +google-sargo-Make-feedback-stronger.patch
--
Sebastian Ramacher
--- End Message ---
