Package: release.debian.org Severity: normal User: [email protected] Usertags: freeze-exception
Dear Release Team Please unblock package libdbd-sqlite3-perl This is a request to unblock libdbd-sqlite3-perl if we can upload it. Niko Tyni found a patch for the FTBFS in #591111. I attach the debdiff between current version in testing and the version we have in the Debian Perl svn repository. Would it be possible to unblock it and can we procede with the upload? unblock libdbd-sqlite3-perl/1.29-3 Bests Salvatore -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-2-amd64 (SMP w/8 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash
diffstat for libdbd-sqlite3-perl-1.29 libdbd-sqlite3-perl-1.29 changelog | 21 ++++ control | 15 +-- copyright | 43 +++++--- patches/0001-Don-t-clean-temporary-files-in-child-processes.patch | 49 ++++++++++ patches/series | 1 rules | 10 -- 6 files changed, 103 insertions(+), 36 deletions(-) diff -Nru libdbd-sqlite3-perl-1.29/debian/changelog libdbd-sqlite3-perl-1.29/debian/changelog --- libdbd-sqlite3-perl-1.29/debian/changelog 2010-04-24 08:39:43.000000000 +0200 +++ libdbd-sqlite3-perl-1.29/debian/changelog 2010-08-23 13:40:29.000000000 +0200 @@ -1,3 +1,24 @@ +libdbd-sqlite3-perl (1.29-3) unstable; urgency=low + + [ Ansgar Burchardt ] + * Use perl_dbi addon for dh. + * Bump build-dependency on libdbi-perl to >= 1.612. + * No longer run release tests. + * Remove build-dep on libpod-simple-perl, libperl-minimumversion-perl, + libtest-cpan-meta-perl, libtest-minimumversion-perl, libtest-pod-perl. + * Bump Standards-Version to 3.9.0 (no changes). + + [ Salvatore Bonaccorso ] + * Add 0001-Don-t-clean-temporary-files-in-child-processes.patch patch: + Fixes FTBFS due failure in tests. Thanks to Niko Tyni for the + investigation and patch (Closes: #591111). + * Refresh debian/copyright and explicitly refer to GPL-1 license text + in common-licenses. + * Bump Standards-Version to 3.9.1. + * Add myself to Uploaders. + + -- Salvatore Bonaccorso <[email protected]> Mon, 23 Aug 2010 13:40:21 +0200 + libdbd-sqlite3-perl (1.29-2) unstable; urgency=low * Add dependency on perl-dbdapi-* (see #577209). (Closes: #578429) diff -Nru libdbd-sqlite3-perl-1.29/debian/control libdbd-sqlite3-perl-1.29/debian/control --- libdbd-sqlite3-perl-1.29/debian/control 2010-04-19 16:14:09.000000000 +0200 +++ libdbd-sqlite3-perl-1.29/debian/control 2010-08-23 13:39:44.000000000 +0200 @@ -1,26 +1,23 @@ Source: libdbd-sqlite3-perl Section: perl Priority: optional -Build-Depends: perl, debhelper (>= 7.0.50~), - libdbi-perl (>= 1.610.90+is+1.609-1~), - libsqlite3-dev (>> 3.6.0), perl (>= 5.10.1) | libpod-simple-perl (>= 3.07), - libperl-minimumversion-perl, libtest-cpan-meta-perl, - libtest-minimumversion-perl, libtest-pod-perl (>= 1.26) +Build-Depends: perl, debhelper (>= 7.0.50~), libdbi-perl (>= 1.612), + libsqlite3-dev (>> 3.6.0) Maintainer: Debian Perl Group <[email protected]> Uploaders: Krzysztof Krzyżaniak (eloy) <[email protected]>, Niko Tyni <[email protected]>, gregor herrmann <[email protected]>, Maximilian Gass <[email protected]>, Gunnar Wolf <[email protected]>, Ryan Niebur <[email protected]>, - Jonathan Yu <[email protected]>, Ansgar Burchardt <[email protected]> -Standards-Version: 3.8.4 + Jonathan Yu <[email protected]>, Ansgar Burchardt <[email protected]>, + Salvatore Bonaccorso <[email protected]> +Standards-Version: 3.9.1 Homepage: http://search.cpan.org/dist/DBD-SQLite/ Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libdbd-sqlite3-perl/ Vcs-Browser: http://svn.debian.org/viewsvn/pkg-perl/trunk/libdbd-sqlite3-perl/ Package: libdbd-sqlite3-perl Architecture: any -Depends: ${misc:Depends}, ${perl:Depends}, ${shlibs:Depends}, - ${libdbi-perl:Depends} +Depends: ${misc:Depends}, ${perl:Depends}, ${shlibs:Depends} Description: Perl DBI driver with a self-contained RDBMS DBD::SQLite is a Perl DBI driver with a self-contained relational database management system. It embeds a small and fast embedded SQL database engine diff -Nru libdbd-sqlite3-perl-1.29/debian/copyright libdbd-sqlite3-perl-1.29/debian/copyright --- libdbd-sqlite3-perl-1.29/debian/copyright 2010-04-19 16:14:09.000000000 +0200 +++ libdbd-sqlite3-perl-1.29/debian/copyright 2010-08-23 13:39:44.000000000 +0200 @@ -3,6 +3,7 @@ Source: http://search.cpan.org/dist/DBD-SQLite/ Name: DBD-SQLite +Files: * Copyright: 2002 - 2007 Matt Sergeant Some parts copyright 2008 Francis J. Lacoste and Wolfgang Sourdeau. Some parts copyright 2008 - 2010 Adam Kennedy. @@ -27,27 +28,33 @@ License: Artistic or GPL-1+ Files: debian/* -Copyright: 2009-2010, Jonathan Yu <[email protected]> - 2009, Ryan Niebur <[email protected]> - 2003-2009, Krzysztof Krzyżaniak (eloy) <[email protected]> - 2006-2010, gregor herrmann <[email protected]> - 2006-2008, Niko Tyni <[email protected]> - 2007, David Paleino <[email protected]> - 2006, Andreas Barth <[email protected]> +Copyright: 2002, 2003, Ardo van Rangelrooij <[email protected]> + 2003, 2004, 2005, 2006, 2009, Krzysztof Krzyżaniak (eloy) <[email protected]> 2005, Marcelo E. Magallon <[email protected]> - 2002-2003, Ardo van Rangelrooij <[email protected]> + 2006, 2007, 2008, 2009, gregor herrmann <[email protected]> + 2006, Andreas Barth <[email protected]> + 2006, 2008, Niko Tyni <[email protected]> + 2007, David Paleino <[email protected]> + 2009, 2010, Jonathan Yu <[email protected]> + 2009, Gunnar Wolf <[email protected]> + 2009, Maximilian Gass <[email protected]> + 2009, Ryan Niebur <[email protected]> + 2010, Ansgar Burchardt <[email protected]> + 2010, Salvatore Bonaccorso <[email protected]> License: Artistic or GPL-1+ License: Artistic - This program is free software; you can redistribute it and/or modify - it under the terms of the Artistic License, which comes with Perl. - On Debian GNU/Linux systems, the complete text of the Artistic License - can be found in `/usr/share/common-licenses/Artistic' + This program is free software; you can redistribute it and/or modify + it under the terms of the Artistic License, which comes with Perl. + . + On Debian GNU/Linux systems, the complete text of the Artistic License + can be found in `/usr/share/common-licenses/Artistic'. License: GPL-1+ - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 1, or (at your option) - any later version. - On Debian GNU/Linux systems, the complete text of the GNU General - Public License can be found in `/usr/share/common-licenses/GPL' + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 1, or (at your option) + any later version. + . + On Debian GNU/Linux systems, the complete text of version 1 of the + General Public License can be found in `/usr/share/common-licenses/GPL-1'. diff -Nru libdbd-sqlite3-perl-1.29/debian/patches/0001-Don-t-clean-temporary-files-in-child-processes.patch libdbd-sqlite3-perl-1.29/debian/patches/0001-Don-t-clean-temporary-files-in-child-processes.patch --- libdbd-sqlite3-perl-1.29/debian/patches/0001-Don-t-clean-temporary-files-in-child-processes.patch 1970-01-01 01:00:00.000000000 +0100 +++ libdbd-sqlite3-perl-1.29/debian/patches/0001-Don-t-clean-temporary-files-in-child-processes.patch 2010-08-23 13:39:44.000000000 +0200 @@ -0,0 +1,49 @@ +From 89c8a661e61bbf0fb1d1e5050262390649e13f2a Mon Sep 17 00:00:00 2001 +From: Niko Tyni <[email protected]> +Date: Mon, 23 Aug 2010 08:15:15 +0300 +Subject: [PATCH] Don't clean temporary files in child processes + +As of SQLite 3.7.0, write locks try to stat() the database +file and fail with a 'Disk I/O error' if it is missing. This +breaks those tests that fork child processes (namely 08_busy.t +and t/28_schemachange.t) because the child process removes +the database file in the END block. + +The fix is to disable the clean() function for child processes. + +See <http://bugs.debian.org/591111> +--- + t/lib/Test.pm | 3 +++ + 1 files changed, 3 insertions(+), 0 deletions(-) + +diff --git a/t/lib/Test.pm b/t/lib/Test.pm +index 80e50ce..8d1be25 100644 +--- a/t/lib/Test.pm ++++ b/t/lib/Test.pm +@@ -7,6 +7,7 @@ use Exporter (); + use File::Spec (); + use Test::More (); + ++my $parent; + use vars qw{$VERSION @ISA @EXPORT @CALL_FUNCS}; + BEGIN { + $VERSION = '1.29'; +@@ -15,6 +16,7 @@ BEGIN { + + # Allow tests to load modules bundled in /inc + unshift @INC, 'inc'; ++ $parent = $$; + } + + # Always load the DBI module +@@ -22,6 +24,7 @@ use DBI (); + + # Delete temporary files + sub clean { ++ return if $$ != $parent; + unlink( 'foo' ); + unlink( 'foo-journal' ); + } +-- +1.7.1 + diff -Nru libdbd-sqlite3-perl-1.29/debian/patches/series libdbd-sqlite3-perl-1.29/debian/patches/series --- libdbd-sqlite3-perl-1.29/debian/patches/series 2010-02-07 09:08:20.000000000 +0100 +++ libdbd-sqlite3-perl-1.29/debian/patches/series 2010-08-23 13:39:44.000000000 +0200 @@ -1,2 +1,3 @@ fix-pod-spelling.patch use_system_sqlite +0001-Don-t-clean-temporary-files-in-child-processes.patch diff -Nru libdbd-sqlite3-perl-1.29/debian/rules libdbd-sqlite3-perl-1.29/debian/rules --- libdbd-sqlite3-perl-1.29/debian/rules 2010-04-19 16:14:09.000000000 +0200 +++ libdbd-sqlite3-perl-1.29/debian/rules 2010-08-23 13:39:44.000000000 +0200 @@ -1,12 +1,4 @@ #!/usr/bin/make -f -include /usr/share/libdbi-perl/perl-dbdabi.make - %: - dh $@ - -override_dh_gencontrol: - dh_gencontrol -- -V"libdbi-perl:Depends=libdbi-perl, $(PERL_DBDABI_DEPENDS)" - -override_dh_auto_test: - RELEASE_TESTING=1 dh_auto_test + dh $@ --with perl_dbi
