On Sat, 2010-09-04 at 22:55 +0200, Julien Cristau wrote:
> On Sun, Aug 22, 2010 at 16:09:11 +0100, Adam D. Barratt wrote:
> diffstat and debdiff follow. Most of the changes had been sitting in
> git since May, but not uploaded due to Raphael not having access to the
> hw anymore. I'm quite happy Julien volunteered to maintain this
> package.
Please go ahead with the upload.
A few quick comments - all on comments, as it happens :-)
> diff -Nru xserver-xorg-video-openchrome-0.2.904+svn827/src/via_cursor.c
> xserver-xorg-video-openchrome-0.2.904+svn842/src/via_cursor.c
> --- xserver-xorg-video-openchrome-0.2.904+svn827/src/via_cursor.c
> 2010-01-11 21:34:09.000000000 +0100
> +++ xserver-xorg-video-openchrome-0.2.904+svn842/src/via_cursor.c
> 2010-04-22 07:32:27.000000000 +0200
> @@ -319,13 +322,19 @@
[...]
> + /* FIXME For CLE266 nad KM400 try to enable 32x32 cursor
> size [bit1] */
s/nad/and/
> @@ -471,11 +498,17 @@
> }
> }
>
> +/*
> + Set the cursor foreground and background colors. In 8bpp, fg and
> + bg are indicies into the current colormap unless the
s/indicies/indices/
> diff -Nru xserver-xorg-video-openchrome-0.2.904+svn827/src/via_driver.c
> xserver-xorg-video-openchrome-0.2.904+svn842/src/via_driver.c
> --- xserver-xorg-video-openchrome-0.2.904+svn827/src/via_driver.c
> 2010-01-11 21:34:09.000000000 +0100
> +++ xserver-xorg-video-openchrome-0.2.904+svn842/src/via_driver.c
> 2010-04-22 07:32:27.000000000 +0200
> @@ -654,6 +655,12 @@
> vbeInfoPtr pVbe;
>
> if (xf86LoadSubModule(pScrn, "vbe")) {
> + /* FIXME This line should be replaced to:
"replaced with"
> @@ -2016,40 +2023,56 @@
[...]
> + /* CR34 are fire bits. Must be writed after CR0C CR0D CR48. */
s/writed/written/
> @@ -2166,14 +2201,23 @@
[...]
> + /* CR34 are fire bits. Must be writed after CR0C CR0D CR48. */
Same here.
Regards,
Adam
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive:
http://lists.debian.org/[email protected]
