Le dimanche 09 décembre 2012 à 12:41 +0100, Niels Thykier a écrit :
>
> +-gjs_context_print_stack_to_buffer(GjsContext* context, GString *buf)
> ++gjs_context_print_stack_to_buffer(GjsContext* context, void
> *initial, GString *buf)
> + {
> + JSContext *js_context =
> (JSContext*)gjs_context_get_native_context(context);
> +- JSStackFrame* fp;
> +- JSStackFrame* iter = NULL;
> ++ JSStackFrame* fp = initial;
> ^^^^^^^^^^^^
> Seems to me that gjs_context_print_stack_to_buffer is (more or less) a
> NO-OP if intial is NULL. (/me read "topmost" as the
> "deepest/innermost" frame, so I was expecting it to dump the "entire"
> stack. If "topmost" has a different meaning here or I missed
> something in the diff, please do correct me)
Awesome review, thanks for noticing.
I’ll reupload with that additional patch.
http://git.gnome.org/browse/gjs/commit/?id=5c90e776ce3c
Cheers,
--
.''`. Josselin Mouette
: :' :
`. `'
`-
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/1355129290.14201.1.camel@tomoyo
