Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
Hi, I would like to upload poppler 0.18.4-5, which would initialize two class members of PSOutputDev to avoid crashing in the destructor if the initialization of the output device is not "ok" (e.g. when the requested output file name cannot be opened, like in #699421). This bug, other than hitting that pdftops case, can hit library users of PSOutputDev, and its poppler-glib wrapping (such as epdfview). Attached the proposed debdiff. Thanks, -- Pino
diff -Nru poppler-0.18.4/debian/changelog poppler-0.18.4/debian/changelog --- poppler-0.18.4/debian/changelog 2012-11-27 16:24:20.000000000 +0100 +++ poppler-0.18.4/debian/changelog 2013-01-31 14:03:45.000000000 +0100 @@ -1,3 +1,12 @@ +poppler (0.18.4-5) UNRELEASED; urgency=low + + [ Pino Toscano ] + * Correctly initialize PSOutputDev::fontFileNameLen and + PSOutputDev::psFileNames; patch psoutputdev-initialize-vars.diff. + (Closes: #699421) + + -- Pino Toscano <[email protected]> Thu, 31 Jan 2013 13:19:35 +0100 + poppler (0.18.4-4) unstable; urgency=low * Backport upstream commits 7ba15d11e56175601104d125d5e4a47619c224bf and diff -Nru poppler-0.18.4/debian/patches/psoutputdev-initialize-vars.diff poppler-0.18.4/debian/patches/psoutputdev-initialize-vars.diff --- poppler-0.18.4/debian/patches/psoutputdev-initialize-vars.diff 1970-01-01 01:00:00.000000000 +0100 +++ poppler-0.18.4/debian/patches/psoutputdev-initialize-vars.diff 2013-01-31 13:58:06.000000000 +0100 @@ -0,0 +1,41 @@ +Author: Pino Toscano <[email protected]> +Description: initialize PSOutputDev::fontFileNameLen and PSOutputDev::psFileNames + Avoid crashing in ~PSOutputDev when the PSOutputDev instance is not "ok". +Applied-Upstream: not-needed +Last-Update: 2013-01-31 +Bug-Debian: http://bugs.debian.org/699421 + +--- a/poppler/PSOutputDev.cc ++++ b/poppler/PSOutputDev.cc +@@ -1012,6 +1012,7 @@ PSOutputDev::PSOutputDev(const char *fil + fontIDs = NULL; + fontFileIDs = NULL; + fontFileNames = NULL; ++ fontFileNameLen = 0; + font8Info = NULL; + font16Enc = NULL; + imgIDs = NULL; +@@ -1022,6 +1023,7 @@ PSOutputDev::PSOutputDev(const char *fil + haveTextClip = gFalse; + haveCSPattern = gFalse; + t3String = NULL; ++ psFileNames = NULL; + + forceRasterize = forceRasterizeA; + +@@ -1077,6 +1079,7 @@ PSOutputDev::PSOutputDev(PSOutputFunc ou + fontIDs = NULL; + fontFileIDs = NULL; + fontFileNames = NULL; ++ fontFileNameLen = 0; + font8Info = NULL; + font16Enc = NULL; + imgIDs = NULL; +@@ -1087,6 +1090,7 @@ PSOutputDev::PSOutputDev(PSOutputFunc ou + haveTextClip = gFalse; + haveCSPattern = gFalse; + t3String = NULL; ++ psFileNames = NULL; + + forceRasterize = forceRasterizeA; + diff -Nru poppler-0.18.4/debian/patches/series poppler-0.18.4/debian/patches/series --- poppler-0.18.4/debian/patches/series 2012-11-27 16:20:00.000000000 +0100 +++ poppler-0.18.4/debian/patches/series 2013-01-31 13:58:17.000000000 +0100 @@ -3,3 +3,4 @@ upstream_pdfinfo-decode-utf-16-surrogate-pairs.patch upstream_Change-nnnnnn-to-number.patch upstream_fix-GooString-insert.diff +psoutputdev-initialize-vars.diff
