Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package debian-installer-launcher

It fixes the grave bug #703979.

unblock debian-installer-launcher/16

Thanks,
Ben

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing'), (101, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru debian-installer-launcher-15/debian/changelog debian-installer-launcher-16/debian/changelog
--- debian-installer-launcher-15/debian/changelog	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/debian/changelog	2013-03-30 16:59:31.000000000 -0300
@@ -1,3 +1,12 @@
+debian-installer-launcher (16) unstable; urgency=low
+
+  * Use tmpfs and lazy unmount to ensure safe cleanup.
+    Thanks to Bastian Blank <wa...@debian.org>. (Closes: #703979).
+  * Ensure chroot inherits DISPLAY from caller to make
+    install from console possible again.
+
+ -- Ben Armstrong <sy...@sanctuary.nslug.ns.ca>  Sat, 30 Mar 2013 10:37:55 -0300
+
 debian-installer-launcher (15) unstable; urgency=low
 
   * Correctly identifying syslogd/klogd processes to kill when cleaning up
diff -Nru debian-installer-launcher-15/debian-installer.sh debian-installer-launcher-16/debian-installer.sh
--- debian-installer-launcher-15/debian-installer.sh	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/debian-installer.sh	2013-03-30 16:59:31.000000000 -0300
@@ -3,7 +3,7 @@
 set -e
 
 in_image () {
-	chroot /lib/live/installer /usr/bin/env -i LIVE_INSTALLER_MODE=1 DEBIAN_FRONTEND=$DI_FRONTEND DISPLAY=:0 TERM=$TERM $CMDLINE $@
+	chroot /lib/live/installer /usr/bin/env -i LIVE_INSTALLER_MODE=1 DEBIAN_FRONTEND=$DI_FRONTEND DISPLAY=$DISPLAY TERM=$TERM $CMDLINE $@
 }
 
 CMDLINE=
diff -Nru debian-installer-launcher-15/plugins/live debian-installer-launcher-16/plugins/live
--- debian-installer-launcher-15/plugins/live	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/plugins/live	2013-03-30 16:59:31.000000000 -0300
@@ -65,8 +65,9 @@
 
 	echo "Loading debian-installer..."
 
-	# Create the temporary directory
+	# Create the temporary directory and mount a tmpfs on it to ease cleanup
 	mkdir -p /lib/live/installer
+	mount -t tmpfs none /lib/live/installer
 
 	# Unpack the initrd
 	cd /lib/live/installer
@@ -100,13 +101,9 @@
 	# which is a bit of a grubby way to identify them, but holds true for now.
 	fuser -k /lib/live/installer/bin/busybox > /dev/null 2>&1 || true
 
-	# Unmounting filesystems
-	for fs in /cdrom /dev/pts /dev /proc /sys /tmp; do
-		umount -f /lib/live/installer/$fs > /dev/null 2>&1 || true
-	done
-
 	# Remove unpacked initrd
-	rm -rf /lib/live/installer
+	cd
+	umount -l /lib/live/installer
 	rm -f /tmp/debian-installer
 }
 

Reply via email to