Package: release.debian.org Severity: normal User: [email protected] Usertags: pu
Hi Stable release managers There is an annoying bug in libnet-server-perl not checking if a variable is initialized and issuing e.g. in munin-logs regularly a "use of uninitialized value in pattern match" warning. The corresponding bug for libnet-server-perl is at [1]. [1] http://bugs.debian.org/693320 This was fixed in libnet-server-perl/2.007-1 for testing and unstable already. Could you accept the attached patch for wheezy-proposed-updates? Regards, Salvatore
diff -Nru libnet-server-perl-2.006/debian/changelog libnet-server-perl-2.006/debian/changelog --- libnet-server-perl-2.006/debian/changelog 2012-06-25 15:46:18.000000000 +0200 +++ libnet-server-perl-2.006/debian/changelog 2013-11-28 09:39:23.000000000 +0100 @@ -1,3 +1,11 @@ +libnet-server-perl (2.006-1+deb7u1) wheezy; urgency=low + + * Team upload. + * Add fix-use-of-uninitialized-value-in-pattern-match.patch. + Fixes use of uninitialized value in pattern match. (Closes: #693320) + + -- Salvatore Bonaccorso <[email protected]> Thu, 28 Nov 2013 09:38:43 +0100 + libnet-server-perl (2.006-1) unstable; urgency=low * Imported Upstream version 2.006 diff -Nru libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch --- libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch 1970-01-01 01:00:00.000000000 +0100 +++ libnet-server-perl-2.006/debian/patches/fix-use-of-uninitialized-value-in-pattern-match.patch 2013-11-28 09:39:23.000000000 +0100 @@ -0,0 +1,31 @@ +Description: Fix of uninitialized value in pattern match +Origin: upstream, https://metacpan.org/diff/release/RHANDOM/Net-Server-2.006/RHANDOM/Net-Server-2.007 +Bug: https://rt.cpan.org/Public/Bug/Display.html?id=78828 +Bug-Debian: http://bugs.debian.org/693320 +Forwarded: https://rt.cpan.org/Public/Bug/Display.html?id=78828 +Author: Salvatore Bonaccorso <[email protected]> +Last-Update: 2013-11-28 +Applied-Upstream: 2.007 + +--- a/lib/Net/Server.pm ++++ b/lib/Net/Server.pm +@@ -587,7 +587,8 @@ + + # if the addr or host matches a deny, reject it immediately + foreach (@{ $prop->{'deny'} }) { +- return 0 if $prop->{'peerhost'} =~ /^$_$/ && defined $prop->{'reverse_lookups'}; ++ return 0 if $prop->{'reverse_lookups'} ++ && defined($prop->{'peerhost'}) && $prop->{'peerhost'} =~ /^$_$/; + return 0 if $peeraddr =~ /^$_$/; + } + if (@{ $prop->{'cidr_deny'} }) { +@@ -597,7 +598,8 @@ + + # if the addr or host isn't blocked yet, allow it if it is allowed + foreach (@{ $prop->{'allow'} }) { +- return 1 if $prop->{'peerhost'} =~ /^$_$/ && defined $prop->{'reverse_lookups'}; ++ return 1 if $prop->{'reverse_lookups'} ++ && defined($prop->{'peerhost'}) && $prop->{'peerhost'} =~ /^$_$/; + return 1 if $peeraddr =~ /^$_$/; + } + if (@{ $prop->{'cidr_allow'} }) { diff -Nru libnet-server-perl-2.006/debian/patches/series libnet-server-perl-2.006/debian/patches/series --- libnet-server-perl-2.006/debian/patches/series 2012-06-25 15:46:18.000000000 +0200 +++ libnet-server-perl-2.006/debian/patches/series 2013-11-28 09:39:23.000000000 +0100 @@ -1 +1,2 @@ 0001-Fix-errors-in-POD.patch +fix-use-of-uninitialized-value-in-pattern-match.patch
