Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
Please unblock package subtitleeditor due to changed handling of how to add interfaces to custom classes in glib(mm) 2.4.2.0 subtitleeditor is completely useless at the moment - it's not possible to edit/add text anymore. I prepared a patch as a user filed a bug about it. The patch itself is quite trivial as it only changes the order of ancestor classes. The solution was explained here: https://bugzilla.gnome.org/show_bug.cgi?id=697229#c29 subtitleeditor (0.33.0-3) unstable; urgency=low * Add debian/patches/02-fix-custom-class-interfaces.patch: + Need to add interfaces before class_init (closes: #767892) * Bump Standards-Version to 3.9.6 (no changes necessary). -- Philip Rinn <[email protected]> Mon, 10 Nov 2014 18:55:12 +0100 I attached the debdiff. Thanks for all your work! Philip unblock subtitleeditor/0.33.0-3 -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (700, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16-3-amd64 (SMP w/4 CPU cores)
diff -Nru subtitleeditor-0.33.0/debian/changelog subtitleeditor-0.33.0/debian/changelog --- subtitleeditor-0.33.0/debian/changelog 2013-09-30 18:17:01.000000000 +0200 +++ subtitleeditor-0.33.0/debian/changelog 2014-11-11 17:10:43.000000000 +0100 @@ -1,3 +1,11 @@ +subtitleeditor (0.33.0-3) unstable; urgency=low + + * Add debian/patches/02-fix-custom-class-interfaces.patch: + + Need to add interfaces before class_init (closes: #767892) + * Bump Standards-Version to 3.9.6 (no changes necessary). + + -- Philip Rinn <[email protected]> Mon, 10 Nov 2014 18:55:12 +0100 + subtitleeditor (0.33.0-2) unstable; urgency=low * Remove automake1.9 from Build-Depends (closes: #724438). diff -Nru subtitleeditor-0.33.0/debian/control subtitleeditor-0.33.0/debian/control --- subtitleeditor-0.33.0/debian/control 2013-09-30 18:08:40.000000000 +0200 +++ subtitleeditor-0.33.0/debian/control 2014-11-10 19:00:18.000000000 +0100 @@ -8,7 +8,7 @@ intltool, libglibmm-2.4-dev, libcairomm-1.0-dev, libgtk2.0-dev, imagemagick, libatk1.0-dev, libpango1.0-dev, libglib2.0-dev, libglademm-2.4-dev Homepage: http://home.gna.org/subtitleeditor/ -Standards-Version: 3.9.4 +Standards-Version: 3.9.6 Package: subtitleeditor Architecture: any diff -Nru subtitleeditor-0.33.0/debian/patches/02-fix-custom-class-interfaces.patch subtitleeditor-0.33.0/debian/patches/02-fix-custom-class-interfaces.patch --- subtitleeditor-0.33.0/debian/patches/02-fix-custom-class-interfaces.patch 1970-01-01 01:00:00.000000000 +0100 +++ subtitleeditor-0.33.0/debian/patches/02-fix-custom-class-interfaces.patch 2014-11-10 18:47:58.000000000 +0100 @@ -0,0 +1,26 @@ +Author: Philip Rinn <[email protected]> +Description: With glib >= 2.42.0 you need to add interfaces before class_init +--- a/src/gui/textviewcell.cc ++++ b/src/gui/textviewcell.cc +@@ -29,8 +29,8 @@ + * + */ + TextViewCell::TextViewCell() +-: Glib::ObjectBase(typeid(TextViewCell)), +- Gtk::CellEditable() ++: Gtk::CellEditable(), ++ Glib::ObjectBase(typeid(TextViewCell)) + { + se_debug(SE_DEBUG_VIEW); + +--- a/src/gui/textviewcell.h ++++ b/src/gui/textviewcell.h +@@ -29,7 +29,7 @@ + /* + * Cell text editable with multiline support. + */ +-class TextViewCell : public Gtk::TextView, public Gtk::CellEditable ++class TextViewCell : public Gtk::CellEditable, public Gtk::TextView + { + public: + diff -Nru subtitleeditor-0.33.0/debian/patches/series subtitleeditor-0.33.0/debian/patches/series --- subtitleeditor-0.33.0/debian/patches/series 2012-03-31 18:53:35.000000000 +0200 +++ subtitleeditor-0.33.0/debian/patches/series 2014-11-10 18:31:14.000000000 +0100 @@ -1 +1,2 @@ 01-glib-single-include.patch +02-fix-custom-class-interfaces.patch
