Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
Please unblock package lightdm-gtk-greeter Hi, this is a pre-approval request for an upload of lightdm-gtk-greeter targeted to Jessie. It fixes two bugs: - #750901 (sev. normal) which is really cosmetic but was applied long ago in our svn, and shouldn't be really problematic, so I kept it - #760740 (sev. important) which is about accessibility. When at-spi2-core is installed, it'll be run automatically on the greeter (through the use of a gtk adaptor), which is apparently desired, but then it'll enforce a property on the root window which then prevents the user-run at-spi2 processes to work correctly. Best fix would be to have a way to properly kill the at-spi2-core processes, but for now it seems the second best fix is to remove the property from the root window. Full debdiff is attached. unblock lightdm-gtk-greeter/1.8.5-2 -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (450, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
Differences in lightdm-gtk-greeter between 1.8.5-1 and 1.8.5-2 diff -Nru lightdm-gtk-greeter-1.8.5/debian/changelog lightdm-gtk-greeter-1.8.5/debian/changelog --- lightdm-gtk-greeter-1.8.5/debian/changelog 2014-05-06 07:43:19.000000000 +0200 +++ lightdm-gtk-greeter-1.8.5/debian/changelog 2014-11-21 16:56:00.000000000 +0100 @@ -1,3 +1,13 @@ +lightdm-gtk-greeter (1.8.5-2) UNRELEASED; urgency=medium + + * debian/control, debian/copyright: + - patch from Artur Rona to fix various lintian warnings. closes: #750901 + * debian/patches: + - 01_unset_AT_SPI_BUS-X11-property added, unset AT_SPI_BUS property from + the root window. closes: #760740 + + -- Yves-Alexis Perez <[email protected]> Wed, 11 Jun 2014 21:23:58 +0200 + lightdm-gtk-greeter (1.8.5-1) unstable; urgency=medium * New upstream release. diff -Nru lightdm-gtk-greeter-1.8.5/debian/control lightdm-gtk-greeter-1.8.5/debian/control --- lightdm-gtk-greeter-1.8.5/debian/control 2014-01-07 23:33:25.000000000 +0100 +++ lightdm-gtk-greeter-1.8.5/debian/control 2014-06-11 21:25:00.000000000 +0200 @@ -16,7 +16,6 @@ Provides: lightdm-greeter Replaces: lightdm-gtk, lightdm (<< 0.9.2-1) Breaks: lightdm-gtk, lightdm (<< 0.9.2-1) -Section: x11 Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends} Recommends: desktop-base, gnome-themes-standard, gnome-icon-theme-symbolic, policykit-1 diff -Nru lightdm-gtk-greeter-1.8.5/debian/copyright lightdm-gtk-greeter-1.8.5/debian/copyright --- lightdm-gtk-greeter-1.8.5/debian/copyright 2012-01-31 07:51:04.000000000 +0100 +++ lightdm-gtk-greeter-1.8.5/debian/copyright 2014-06-11 21:25:00.000000000 +0200 @@ -1,7 +1,5 @@ -Format-Specification: - http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=402 +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: lightdm -Upstream-Maintainer: Robert Ancell Upstream-Source: https://launchpad.net/lightdm Files: debian/* @@ -116,3 +114,12 @@ Public License version 3 can be found in `/usr/share/common-licenses/GPL-3'. +License: GPL-3+ + On Debian systems, the complete text of the GNU General + Public License version 3 can be found in + `/usr/share/common-licenses/GPL-3'. + +License: LGPL-3+ + On Debian systems, the complete text of the GNU Lesser + General Public License version 3 can be found in + `/usr/share/common-licenses/LGPL-3'. diff -Nru lightdm-gtk-greeter-1.8.5/debian/patches/01_unset_AT_SPI_BUS-X11-property.patch lightdm-gtk-greeter-1.8.5/debian/patches/01_unset_AT_SPI_BUS-X11-property.patch --- lightdm-gtk-greeter-1.8.5/debian/patches/01_unset_AT_SPI_BUS-X11-property.patch 1970-01-01 01:00:00.000000000 +0100 +++ lightdm-gtk-greeter-1.8.5/debian/patches/01_unset_AT_SPI_BUS-X11-property.patch 2014-11-21 17:17:52.000000000 +0100 @@ -0,0 +1,20 @@ +--- a/src/lightdm-gtk-greeter.c.original 2014-10-19 18:30:01.368000000 +0200 ++++ b/src/lightdm-gtk-greeter.c 2014-10-19 18:49:46.876000000 +0200 +@@ -2803,5 +2803,16 @@ + gdk_color_free (default_background_color); + #endif + ++ { ++ int screen = XDefaultScreen (display); ++ Window w = RootWindow (display, screen); ++ Atom id = XInternAtom (display, "AT_SPI_BUS", True); ++ if (id != None) ++ { ++ XDeleteProperty (display, w, id); ++ XSync (display, FALSE); ++ } ++ } ++ + return EXIT_SUCCESS; + } + diff -Nru lightdm-gtk-greeter-1.8.5/debian/patches/series lightdm-gtk-greeter-1.8.5/debian/patches/series --- lightdm-gtk-greeter-1.8.5/debian/patches/series 2014-02-12 21:04:20.000000000 +0100 +++ lightdm-gtk-greeter-1.8.5/debian/patches/series 2014-11-21 16:56:00.000000000 +0100 @@ -1 +1,2 @@ +01_unset_AT_SPI_BUS-X11-property.patch 04_default-gtk-greeter-config.patch
