Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
Please consider unblocking planned upload of package mate-utils + * debian/patches: + + Add 0001_mate-dictionary-fix-double-free-error.patch. Avoid crashes of + mate-dictionary due to double-free error. (Closes: #779856). -> Prevent crashes of mate-dictionary after error dialog box showed up. light+love, Mike unblock mate-utils/1.8.1+dfsg1-2 -- System Information: Debian Release: 8.0 APT prefers stable APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 'testing-proposed-updates'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init)
diff -Nru mate-utils-1.8.1+dfsg1/debian/changelog mate-utils-1.8.1+dfsg1/debian/changelog --- mate-utils-1.8.1+dfsg1/debian/changelog 2014-10-24 13:26:35.000000000 +0200 +++ mate-utils-1.8.1+dfsg1/debian/changelog 2015-03-09 09:15:06.000000000 +0100 @@ -1,3 +1,11 @@ +mate-utils (1.8.1+dfsg1-2) unstable; urgency=medium + + * debian/patches: + + Add 0001_mate-dictionary-fix-double-free-error.patch. Avoid crashes of + mate-dictionary due to double-free error. (Closes: #779856). + + -- Mike Gabriel <[email protected]> Mon, 09 Mar 2015 09:15:06 +0100 + mate-utils (1.8.1+dfsg1-1) unstable; urgency=medium [ Vangelis Mouhtsis ] diff -Nru mate-utils-1.8.1+dfsg1/debian/patches/0001_mate-dictionary-fix-double-free-error.patch mate-utils-1.8.1+dfsg1/debian/patches/0001_mate-dictionary-fix-double-free-error.patch --- mate-utils-1.8.1+dfsg1/debian/patches/0001_mate-dictionary-fix-double-free-error.patch 1970-01-01 01:00:00.000000000 +0100 +++ mate-utils-1.8.1+dfsg1/debian/patches/0001_mate-dictionary-fix-double-free-error.patch 2015-03-09 09:13:20.000000000 +0100 @@ -0,0 +1,34 @@ +From 65abdedc9a09e8152ffa4de442b47082e76ff49d Mon Sep 17 00:00:00 2001 +From: Monsta <[email protected]> +Date: Wed, 17 Dec 2014 12:47:48 +0300 +Subject: [PATCH] mate-dictionary: don't free GError more than once + +because that error dialog function frees it already +--- + mate-dictionary/src/gdict-source-dialog.c | 1 - + mate-dictionary/src/gdict-window.c | 1 - + 2 files changed, 2 deletions(-) + +diff --git a/mate-dictionary/src/gdict-source-dialog.c b/mate-dictionary/src/gdict-source-dialog.c +index 3468011..792677d 100644 +--- a/mate-dictionary/src/gdict-source-dialog.c ++++ b/mate-dictionary/src/gdict-source-dialog.c +@@ -477,7 +477,6 @@ gdict_source_dialog_response_cb (GtkDialog *dialog, + gdict_show_gerror_dialog (GTK_WINDOW (dialog), + _("There was an error while displaying help"), + err); +- g_error_free (err); + } + + /* we don't want the dialog to close itself */ +diff --git a/mate-dictionary/src/gdict-window.c b/mate-dictionary/src/gdict-window.c +index 58eae2e..01679ff 100644 +--- a/mate-dictionary/src/gdict-window.c ++++ b/mate-dictionary/src/gdict-window.c +@@ -1242,7 +1242,6 @@ gdict_window_cmd_help_contents (GtkAction *action, + gdict_show_gerror_dialog (GTK_WINDOW (window), + _("There was an error while displaying help"), + err); +- g_error_free (err); + } + } diff -Nru mate-utils-1.8.1+dfsg1/debian/patches/series mate-utils-1.8.1+dfsg1/debian/patches/series --- mate-utils-1.8.1+dfsg1/debian/patches/series 2014-10-24 12:58:57.000000000 +0200 +++ mate-utils-1.8.1+dfsg1/debian/patches/series 2015-03-09 09:13:32.000000000 +0100 @@ -1 +1,2 @@ +0001_mate-dictionary-fix-double-free-error.patch 2001_omit-gfdl-licensed-help-files.patch
