Martin Pitt: > Hello Niels, > > Niels Thykier [2016-11-13 12:53 +0000]: >> [...] >> * It cherry-picks 4 commits proposed by Martin Pitt to assist Ubuntu >> with refactoring some their changes into policies. >> >> Martin Pitt (4): >> Move build checks before running policies > > This needs another small refinement which we previously overlooked: > With that patch excuse.is_valid was only updated after *all* policies > ran. But the idea was that some "expensive" policy can detect whether > a previous policy already invalidated the excuse, and for that we need > to update excuse.is_valid after each policy run. > > Patch from Robert attached (I added a more complete changelog). > > I'll keep that in our branch for now, but if you take the above I > think you should also take this one so that this actually works. > > Thanks for considering, > > Martin >
Thanks, I will schedule it into the next bundle. :) Have you thought about "force" hints here? The end result for a "force" hinted item is that it will always be valid. Therefore, I would expect policies to see the item as valid, but I am not quite sure that is the case with this patch. Admittedly, other parts needs fixing as well now for this to hold, but until now we never had a policy that was "lazy" before. Thanks, ~Niels
