2011/2/15 Antonio Terceiro <[email protected]>: > Hello Vincent, > Hello Antonio and thanks for your reply. > > I cannot upload your package, but I checked it and find some minor > issues that we could consider changing. > > You package installs a useless README file that only contains build > instructions (which the Debian package users don't need at all).
The README file is shipped with the upstream sources. Should I remove it from the debian package? How? > It seems to me that libglobalhotkeys-ruby is not usable without > libgtk2-ruby. The example you install at > /usr/share/doc/libglobalhotkeys-ruby explicitly requires it, and the > sample code snippet in the rdoc does not seem to work either. Shouldn't > you upgrade the relationship between them to Depends instead of > Recommends? The code was never tested without Gtk2 but it includes no gtk functions only gdk ones (on a C level). It does not depends on the ruby binding of gtk. I suppose it could be used with an other graphical toolkit (i.e. Qt) but tests (and debugging) are needed. Should I upgrade to Depends for now? > Also, that code snippet in the documentation of the GlobalHotKeys module > has a typo: s/frome_name/from_name/ should fix it (note the extra "e"). This error is corrected (in a private git repository) but not yet included on a upstream release. Do you think I should shipped a new upstream release for a typo? > -- > Antonio Terceiro <[email protected]> > http://softwarelivre.org/terceiro -- Vincent Carmona -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
