Hi Cédric, On Fri, Jan 4, 2019 at 4:33 AM Cédric Boutillier <[email protected]> wrote:
> Hi Utkarsh, > > On Fri, Jan 04, 2019 at 01:49:10AM +0530, Utkarsh Gupta wrote: > > Hi,I've updated the Debian package of the Ruby gem *nokogiri*. The > > package wastested on sbuild and was successfully built. It was also > > lintian clean. > > I've updated the package in the salsa repo which may be found at > > https://salsa.debian.org/ruby-team/ruby-nokogiri > > This was listed under "Patch Updates" for diaspora, which may be found at > > https://git.fosscommunity.in/debian-ruby/TaskTracker/issues/133 > > > Please consider to review and upload it. > > I had a quick look at the package ruby-nokogiri. There is something a > bit akward with the new gem version 1.9.1 as upstream does not ship the > test directory. > > Could you please ask upstream to reinclude the tests in the gem? > > Another possibility is to use the git repository on Github as the source > by changing the debian/watch file (see the manpage of uscan for > example). But again there are some subtleties: > > - the git repo contains jar files that neeed to be filtered out from the > created tar ball, with the Files-Excluded: command in the copyright > file > - the git repo does not contain any gemspec (on purpose, upstream > explained it several times). This would break rubygems integration and > dependency checks for reverse dependencies. > But one could be added manually (from the gem) or programmatically. > > I started about a week ago to go with the github path, but didn't > finish. I will push my changes to a branch 'boutil' if you want to look at > it and either start from there or take some inspiration. > There was a version update in the upstream, that is, 1.10.0. And I updated the package as per that. Although the build is passing and is lintian clean, I am sure the problem still exists, right? So I think we could create an issue upstream and ask them to ship the tests in the gem. And if it remains unanswered for a couple of days, I think we should get the github path working. Moreover, I'd still like you to go through the package that I updated [1] and enlist all the possible things missing there. Hoping to get this done at the earliest. [1]: https://salsa.debian.org/ruby-team/ruby-nokogiri Cheers, > > Cédric > Best, Utkarsh
