Your message dated Tue, 29 Oct 2019 02:53:11 +0000
with message-id <[email protected]>
and subject line Bug#943313: fixed in sudo 1.8.29-1
has caused the Debian Bug report #943313,
regarding liggghts should not use MPI_C_COMPILER or MPI_CXX_COMPILER
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
943313: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943313
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: liggghts
Version: 3.8.0+repack1-4
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
liggghts uses MPI and it uses it via FindMPI.cmake, which presently
detects MPI using compiler wrappers such as mpicc. During cross
compilation these wrappers will not work and they will be unsupported on
Debian. Beyond breaking cross compilation, such wrappers break when you
need two of them (e.g. ccache/distcc/mpicc). For MPI, a good solution is
using pkg-config and doing so is well supported by all major
implementations. I'm working on a patch for FindMPI.cmake to make it
work with pkg-config. However that'll result in MPI_C_COMPILER and
MPI_CXX_COMPILER being unusable. Unfortunately, liggghts uses them.
FindMPI.cmake also provides the relevant compiler and linker flags via
other cmake variables, so you can stop using MPI_*_COMPILER today and
thus enable cross building once FindMPI.cmake gains support for it.
Please consider applying the attached patch. Doing so early helps with
developing the cmake patch. I'm attaching my current draft for
reference.
Helmut
--- liggghts-3.8.0+repack1.orig/CMakeLists.txt
+++ liggghts-3.8.0+repack1/CMakeLists.txt
@@ -58,7 +58,12 @@
#=======================================
INCLUDE(FindMPI)
-IF(MPI_C_FOUND AND MPI_CXX_FOUND)
+IF(MPI_C_FOUND AND MPI_CXX_FOUND AND MPI_C_LIB_NAMES AND MPI_CXX_LIB_NAMES)
+ SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${MPI_C_COMPILE_OPTIONS}")
+ SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${MPI_CXX_COMPILE_OPTIONS}")
+ INCLUDE_DIRECTORIES(${MPI_C_INCLUDE_PATHS})
+ INCLUDE_DIRECTORIES(${MPI_CXX_INCLUDE_PATHS})
+ELSEIF(MPI_C_FOUND AND MPI_CXX_FOUND)
SET(CMAKE_C_COMPILER ${MPI_C_COMPILER})
SET(CMAKE_CXX_COMPILER ${MPI_CXX_COMPILER})
ELSE(MPI_C_FOUND AND MPI_CXX_FOUND)
--- liggghts-3.8.0+repack1.orig/src/CMakeLists.txt
+++ liggghts-3.8.0+repack1/src/CMakeLists.txt
@@ -40,6 +40,13 @@
ENDIF(${VTK_MAJOR_VERSION} EQUAL 6)
ENDIF(VTK_FOUND)
+IF(MPI_C_LIB_NAMES)
+ TARGET_LINK_LIBRARIES(libliggghts ${MPI_C_LIB_NAMES})
+ENDIF(MPI_C_LIB_NAMES)
+IF(MPI_CXX_LIB_NAMES)
+ TARGET_LINK_LIBRARIES(libliggghts ${MPI_CXX_LIB_NAMES})
+ENDIF(MPI_CXX_LIB_NAMES)
+
INSTALL(TARGETS libliggghts DESTINATION "${CMAKE_INSTALL_LIBDIR}/")
#======================================================
--- cmake-3.13.4.orig/Modules/FindMPI.cmake
+++ cmake-3.13.4/Modules/FindMPI.cmake
@@ -247,6 +247,7 @@
cmake_policy(SET CMP0057 NEW) # if IN_LIST
include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)
+include(${CMAKE_CURRENT_LIST_DIR}/FindPkgConfig.cmake)
# Generic compiler names
set(_MPI_C_GENERIC_COMPILER_NAMES mpicc mpcc mpicc_r mpcc_r)
@@ -1459,7 +1460,40 @@
if(NOT MPI_PINNED_COMPILER AND NOT MPI_${LANG}_WRAPPER_FOUND)
# If MPI_PINNED_COMPILER wasn't given, and the MPI compiler we potentially found didn't work, we withdraw it.
set(MPI_${LANG}_COMPILER "MPI_${LANG}_COMPILER-NOTFOUND" CACHE FILEPATH "MPI compiler for ${LANG}" FORCE)
- if(NOT MPI_SKIP_GUESSING)
+
+ if(LANG STREQUAL "C")
+ set(_MPI_PKG "mpi-c")
+ elseif(LANG STREQUAL "CXX")
+ set(_MPI_PKG "mpi-cxx")
+ elseif(LANG STREQUAL "Fortran")
+ set(_MPI_PKG "mpi-fort")
+ else()
+ set(_MPI_PKG "")
+ endif()
+ if(_MPI_PKG)
+ pkg_check_modules("MPI_${LANG}_PKG" "${_MPI_PKG}")
+ if("${MPI_${LANG}_PKG_FOUND}")
+ set(MPI_${LANG}_COMPILE_OPTIONS ${MPI_${LANG}_PKG_CFLAGS} CACHE STRING "MPI ${LANG} compilation options" FORCE)
+ set(MPI_${LANG}_INCLUDE_PATH ${MPI_${LANG}_PKG_INCLUDE_DIRS} CACHE STRING "MPI ${LANG} include directories" FORCE)
+ set(MPI_${LANG}_LINK_FLAGS ${MPI_${LANG}_PKG_LDFLAGS} CACHE STRING "MPI ${LANG} linker flags" FORCE)
+ set(MPI_${LANG}_LIB_NAMES ${MPI_${LANG}_PKG_LIBRARIES} CACHE STRING "MPI ${LANG} libraries to link against" FORCE)
+ foreach(_MPI_LIB IN LISTS MPI_${LANG}_LIB_NAMES)
+ if(_MPI_LIB)
+ get_filename_component(_MPI_PLAIN_LIB_NAME "${_MPI_LIB}" NAME_WE)
+ get_filename_component(_MPI_LIB_NAME "${_MPI_LIB}" NAME)
+ get_filename_component(_MPI_LIB_DIR "${_MPI_LIB}" DIRECTORY)
+ find_library(MPI_${_MPI_PLAIN_LIB_NAME}_LIBRARY
+ NAMES "${_MPI_LIB_NAME}" "lib${_MPI_LIB_NAME}"
+ HINTS ${_MPI_LIB_DIR}
+ DOC "Location of the ${_MPI_PLAIN_LIB_NAME} library for MPI"
+ )
+ mark_as_advanced(MPI_${_MPI_PLAIN_LIB_NAME}_LIBRARY)
+ endif()
+ endforeach()
+ endif()
+ endif()
+
+ if(NOT MPI_SKIP_GUESSING AND NOT "${MPI_${LANG}_PKG_FOUND}")
# For C++, we may use the settings for C. Should a given compiler wrapper for C++ not exist, but one for C does, we copy over the
# settings for C. An MPI distribution that is in this situation would be IBM Platform MPI.
if("${LANG}" STREQUAL "CXX" AND MPI_C_WRAPPER_FOUND)
--- End Message ---
--- Begin Message ---
Source: sudo
Source-Version: 1.8.29-1
We believe that the bug you reported is fixed in the latest version of
sudo, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bdale Garbee <[email protected]> (supplier of updated sudo package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 28 Oct 2019 19:27:42 -0600
Source: sudo
Architecture: source
Version: 1.8.29-1
Distribution: unstable
Urgency: medium
Maintainer: Bdale Garbee <[email protected]>
Changed-By: Bdale Garbee <[email protected]>
Closes: 943313
Changes:
sudo (1.8.29-1) unstable; urgency=medium
.
* new upstream version
* make --libexecdir use /usr/lib instead of /usr/lib/sudo, closes: #943313
Checksums-Sha1:
72058cdfae2d0c951a1278d2cc2d50c00cf6064f 1943 sudo_1.8.29-1.dsc
fdce342856f1803478eb549479190370001dca95 3338260 sudo_1.8.29.orig.tar.gz
21b780b487906f77c4f409fc2c859f37667a1f9b 23740 sudo_1.8.29-1.debian.tar.xz
5028e2c39b8af220f3f64b45f018cb556003a440 7042 sudo_1.8.29-1_amd64.buildinfo
Checksums-Sha256:
7600751f0771d33db60ea33e180c9e40ca4848381d4e18699360edb2186e44f8 1943
sudo_1.8.29-1.dsc
ce53ffac9604e23321334d8ba8ac59ded2bcf624fdb9dbde097ab2049bf29c7c 3338260
sudo_1.8.29.orig.tar.gz
e2def05b79507df1d05cc7dd6c9f09bc4688051a78c6c062ca0f7dcb610322e3 23740
sudo_1.8.29-1.debian.tar.xz
d4091c822c034a89499b8034b72b55392c4f804b911cb5bec8ee3e7ee22a1c1e 7042
sudo_1.8.29-1_amd64.buildinfo
Files:
0f97c33d8579be24eacf23abbe2ca1e9 1943 admin optional sudo_1.8.29-1.dsc
b28dabff9c460f115fe74de4d6a6f79d 3338260 admin optional sudo_1.8.29.orig.tar.gz
dbd9ec0b19dd828f5b09a766ded30960 23740 admin optional
sudo_1.8.29-1.debian.tar.xz
520a1d0596819607b6a0fa56143d781f 7042 admin optional
sudo_1.8.29-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEHguq2FwiMqGzzpLrtwRxBYMLn6EFAl23necACgkQtwRxBYML
n6GOmA//YEhKx2DBY3K/tNrb+rloTLp3E/S930ylw1Oh0wuTI99P+9WrHbxdsclX
rC7p66FFfeB+HyThfknIKQfPCyLEs+814HCoqSp149JPL9Gnx1pXSj9GQ1kuA2yK
CZ6xrbCnsA/F8yuVmypL9uYqZ9tVslc9qzdskeQwDebpuya5F3WJaAjfrd4ExssT
aeLR0OSHPtIAKrzHPTUZA9t3aEJFX4vbkkIWtKNFobJ/S3SMSLBcxV0ueKNsfzfR
SB+F3wkJuLi/vh05yJMcJ6ZOUeb9VJp1Af+s5dPt2xtSH9YWmb6slnhxl9wTGMlH
DIZm7M2m6Mram4ptql/mNpwKntekR/rGrbM442Dn2SDbRgalQRPW4P8BbecFOQ1b
bRJN6CaqSaRDSFOzM6pvi1FH3fijruMY+icWDw9v+y7rNsZXMix8yKWWKiqL9TkM
Qen4Hvpd1kk2IvVAEFrQbfME4MFiE7OHFUSa87GLHHCLvLO2NV6ojWYWQKuC5fIz
FYM0mojGrK1h7zcPhZFxGdv/InSu05QpXciI4lyyJMZ2xWtQ8ifnactK1qQqn3oo
P8idhhYbw7Q/0K3MOT3GVsK/AtavfJf10KT6pu2jRNl/57Ukk5hmQb0hclbiwPsi
dx0JtidXnrR5grbxITV0VufCz8lnNQ0v27L6XXLonMptibkF5f4=
=37YG
-----END PGP SIGNATURE-----
--- End Message ---
--
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers
