Your message dated Fri, 26 Jun 2020 21:34:20 +0000
with message-id <[email protected]>
and subject line Bug#943313: fixed in liggghts 3.8.0+repack1-7
has caused the Debian Bug report #943313,
regarding liggghts should not use MPI_C_COMPILER or MPI_CXX_COMPILER
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
943313: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943313
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: liggghts
Version: 3.8.0+repack1-4
Tags: patch upstream
User: [email protected]
Usertags: ftcbfs
liggghts uses MPI and it uses it via FindMPI.cmake, which presently
detects MPI using compiler wrappers such as mpicc. During cross
compilation these wrappers will not work and they will be unsupported on
Debian. Beyond breaking cross compilation, such wrappers break when you
need two of them (e.g. ccache/distcc/mpicc). For MPI, a good solution is
using pkg-config and doing so is well supported by all major
implementations. I'm working on a patch for FindMPI.cmake to make it
work with pkg-config. However that'll result in MPI_C_COMPILER and
MPI_CXX_COMPILER being unusable. Unfortunately, liggghts uses them.
FindMPI.cmake also provides the relevant compiler and linker flags via
other cmake variables, so you can stop using MPI_*_COMPILER today and
thus enable cross building once FindMPI.cmake gains support for it.
Please consider applying the attached patch. Doing so early helps with
developing the cmake patch. I'm attaching my current draft for
reference.
Helmut
--- liggghts-3.8.0+repack1.orig/CMakeLists.txt
+++ liggghts-3.8.0+repack1/CMakeLists.txt
@@ -58,7 +58,12 @@
#=======================================
INCLUDE(FindMPI)
-IF(MPI_C_FOUND AND MPI_CXX_FOUND)
+IF(MPI_C_FOUND AND MPI_CXX_FOUND AND MPI_C_LIB_NAMES AND MPI_CXX_LIB_NAMES)
+ SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${MPI_C_COMPILE_OPTIONS}")
+ SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${MPI_CXX_COMPILE_OPTIONS}")
+ INCLUDE_DIRECTORIES(${MPI_C_INCLUDE_PATHS})
+ INCLUDE_DIRECTORIES(${MPI_CXX_INCLUDE_PATHS})
+ELSEIF(MPI_C_FOUND AND MPI_CXX_FOUND)
SET(CMAKE_C_COMPILER ${MPI_C_COMPILER})
SET(CMAKE_CXX_COMPILER ${MPI_CXX_COMPILER})
ELSE(MPI_C_FOUND AND MPI_CXX_FOUND)
--- liggghts-3.8.0+repack1.orig/src/CMakeLists.txt
+++ liggghts-3.8.0+repack1/src/CMakeLists.txt
@@ -40,6 +40,13 @@
ENDIF(${VTK_MAJOR_VERSION} EQUAL 6)
ENDIF(VTK_FOUND)
+IF(MPI_C_LIB_NAMES)
+ TARGET_LINK_LIBRARIES(libliggghts ${MPI_C_LIB_NAMES})
+ENDIF(MPI_C_LIB_NAMES)
+IF(MPI_CXX_LIB_NAMES)
+ TARGET_LINK_LIBRARIES(libliggghts ${MPI_CXX_LIB_NAMES})
+ENDIF(MPI_CXX_LIB_NAMES)
+
INSTALL(TARGETS libliggghts DESTINATION "${CMAKE_INSTALL_LIBDIR}/")
#======================================================
--- cmake-3.13.4.orig/Modules/FindMPI.cmake
+++ cmake-3.13.4/Modules/FindMPI.cmake
@@ -247,6 +247,7 @@
cmake_policy(SET CMP0057 NEW) # if IN_LIST
include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)
+include(${CMAKE_CURRENT_LIST_DIR}/FindPkgConfig.cmake)
# Generic compiler names
set(_MPI_C_GENERIC_COMPILER_NAMES mpicc mpcc mpicc_r mpcc_r)
@@ -1459,7 +1460,40 @@
if(NOT MPI_PINNED_COMPILER AND NOT MPI_${LANG}_WRAPPER_FOUND)
# If MPI_PINNED_COMPILER wasn't given, and the MPI compiler we potentially found didn't work, we withdraw it.
set(MPI_${LANG}_COMPILER "MPI_${LANG}_COMPILER-NOTFOUND" CACHE FILEPATH "MPI compiler for ${LANG}" FORCE)
- if(NOT MPI_SKIP_GUESSING)
+
+ if(LANG STREQUAL "C")
+ set(_MPI_PKG "mpi-c")
+ elseif(LANG STREQUAL "CXX")
+ set(_MPI_PKG "mpi-cxx")
+ elseif(LANG STREQUAL "Fortran")
+ set(_MPI_PKG "mpi-fort")
+ else()
+ set(_MPI_PKG "")
+ endif()
+ if(_MPI_PKG)
+ pkg_check_modules("MPI_${LANG}_PKG" "${_MPI_PKG}")
+ if("${MPI_${LANG}_PKG_FOUND}")
+ set(MPI_${LANG}_COMPILE_OPTIONS ${MPI_${LANG}_PKG_CFLAGS} CACHE STRING "MPI ${LANG} compilation options" FORCE)
+ set(MPI_${LANG}_INCLUDE_PATH ${MPI_${LANG}_PKG_INCLUDE_DIRS} CACHE STRING "MPI ${LANG} include directories" FORCE)
+ set(MPI_${LANG}_LINK_FLAGS ${MPI_${LANG}_PKG_LDFLAGS} CACHE STRING "MPI ${LANG} linker flags" FORCE)
+ set(MPI_${LANG}_LIB_NAMES ${MPI_${LANG}_PKG_LIBRARIES} CACHE STRING "MPI ${LANG} libraries to link against" FORCE)
+ foreach(_MPI_LIB IN LISTS MPI_${LANG}_LIB_NAMES)
+ if(_MPI_LIB)
+ get_filename_component(_MPI_PLAIN_LIB_NAME "${_MPI_LIB}" NAME_WE)
+ get_filename_component(_MPI_LIB_NAME "${_MPI_LIB}" NAME)
+ get_filename_component(_MPI_LIB_DIR "${_MPI_LIB}" DIRECTORY)
+ find_library(MPI_${_MPI_PLAIN_LIB_NAME}_LIBRARY
+ NAMES "${_MPI_LIB_NAME}" "lib${_MPI_LIB_NAME}"
+ HINTS ${_MPI_LIB_DIR}
+ DOC "Location of the ${_MPI_PLAIN_LIB_NAME} library for MPI"
+ )
+ mark_as_advanced(MPI_${_MPI_PLAIN_LIB_NAME}_LIBRARY)
+ endif()
+ endforeach()
+ endif()
+ endif()
+
+ if(NOT MPI_SKIP_GUESSING AND NOT "${MPI_${LANG}_PKG_FOUND}")
# For C++, we may use the settings for C. Should a given compiler wrapper for C++ not exist, but one for C does, we copy over the
# settings for C. An MPI distribution that is in this situation would be IBM Platform MPI.
if("${LANG}" STREQUAL "CXX" AND MPI_C_WRAPPER_FOUND)
--- End Message ---
--- Begin Message ---
Source: liggghts
Source-Version: 3.8.0+repack1-7
Done: Anton Gladky <[email protected]>
We believe that the bug you reported is fixed in the latest version of
liggghts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anton Gladky <[email protected]> (supplier of updated liggghts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 26 Jun 2020 23:24:34 +0200
Source: liggghts
Architecture: source
Version: 3.8.0+repack1-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers
<[email protected]>
Changed-By: Anton Gladky <[email protected]>
Closes: 943310 943313
Changes:
liggghts (3.8.0+repack1-7) unstable; urgency=medium
.
[ Anton Gladky ]
* [984ea96] Let reprotest fail
* [67f38aa] Add Rules-Requires-Root: no
.
[ Helmut Grohne ]
* [b510414] Support DEB_BUILD_OPTIONS=nocheck. (Closes: #943310)
* [fd665f2] Do not use not use MPI_C_COMPILER or MPI_CXX_COMPILER
(Closes: #943313)
Checksums-Sha1:
962f06460a740e7ff5a16bb346035052dca3fd64 2281 liggghts_3.8.0+repack1-7.dsc
bd3d901c62b027139c97654b803e9af5cb0c222f 10388
liggghts_3.8.0+repack1-7.debian.tar.xz
a176074cc0f77962946f9901039c44bf16893697 17469
liggghts_3.8.0+repack1-7_source.buildinfo
Checksums-Sha256:
fcdc09ab921b143efb7f829a1341c5a2b3f24a0260997868d6f783d157d14654 2281
liggghts_3.8.0+repack1-7.dsc
81bd0b1f4276ead1607092f8680109aa3e1c9c4c679fc2da87e2d34561adb371 10388
liggghts_3.8.0+repack1-7.debian.tar.xz
097975cb006eab212c9cd637219f20344b3a7f67a2e6f97212970193d80f8cdd 17469
liggghts_3.8.0+repack1-7_source.buildinfo
Files:
30d068736b65606802cbd466d3cc5cb9 2281 science optional
liggghts_3.8.0+repack1-7.dsc
e0effbb273609da4dd327a3a9eac1576 10388 science optional
liggghts_3.8.0+repack1-7.debian.tar.xz
3b3967306ba8ce1b1eb4500bbf1d5a30 17469 science optional
liggghts_3.8.0+repack1-7_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEu71F6oGKuG/2fnKF0+Fzg8+n/wYFAl72aA0ACgkQ0+Fzg8+n
/wa+rg/+MV2x+Cy/2aMc8XCebrnzPyZa57hstHV8KYyVWtc6ULuk2AEithZdPh8I
dbMVjkCwZaAfvNjnYI/2lK4jcTRewiQ4xscOr/IEeOXoRmwVFDUK4KIjUyeNSbiF
zOAu+GgXkSFgCcYfDmfQfy07jdV58QaVDU6A8DQYcIOpJTBK9J05BwvTp/EoWUWY
4skb/b//CHlpiRtsOZEWCNdqQA8Exc+ajdQ1TB/8okGH9ysAkwnvkXvrsFwlZfND
U8FsQ3mydv+bCCqlfF3ylDUbg9wzVJQXR301TwWQwZtoH4997YtItlyMicQ7xgZp
FlvEoKrvrWijXMyV8yXUtluvHtmDd/CQyUZARD1nryeDXEoMsoTM2f3br7xTdF4B
Ujfi0KFLr19JUl+grIt150saDd6K4MBSKAKrszidMm6JPXXBaz8RXe4tl4MGa9Am
dhdY7uYdpWB9oneGcYVkXYqoRJeMziXiNAV0S1ldlVjoU6hjH7Gt0yxkM/o4EVFY
lk2sry4SWg9cuYaNNCzhTbaA9QW/cwnundh/r3zW3K9i21KGdN9rcUy1OD+deM2B
AMlP0Ocx+NFVr3SGnPh9xFcsaCSBNX4FVSCfC+IvLahqOsfYKXIhFTIiAS8hMvB5
eXG/KaiQIIZKv9Tx5IkvZ/OotwwbW9bWTtbMPMxCXK+/rol73ck=
=MpL7
-----END PGP SIGNATURE-----
--- End Message ---
--
debian-science-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers
